Simplify the query to calculate lifetime emails

Get max and count of subscribers in the query.

[MAILPOET-4177]

mailpoet/lib/Subscribers/SubscribersEmailCountsController.php

@@ -107,10 +107,12 @@ class SubscribersEmailCountsController {
 
   private function countAndMaxOfSubscribersInRange(int $startId, int $batchSize): array {
     $result = $this->entityManager->getConnection()->executeQuery("
-      SELECT s.id FROM {$this->subscribersTable} as s
+      SELECT COUNT(ids.id) as count, COALESCE(MAX(ids.id), 0) as max FROM (
-      WHERE s.id >= :startId
+        SELECT s.id FROM {$this->subscribersTable} as s
-      ORDER BY s.id
+        WHERE s.id >= :startId
-      LIMIT :batchSize
+        ORDER BY s.id
+        LIMIT :batchSize
+        ) ids
     ",
       [
         'startId' => $startId,
@@ -124,16 +126,6 @@ class SubscribersEmailCountsController {
 
     $subscribersInRange = $result->fetchAllAssociative();
 
-    $countSubscribersInRange = count(array_map(
+    return [$subscribersInRange[0]['count'], $subscribersInRange[0]['max']];
-      function ($id) {
-        return (int)$id['id'];
-      },
-      $subscribersInRange
-    ));
-
-    if (!$countSubscribersInRange) {
-      return [0,0];
-    }
-    return [$countSubscribersInRange,$subscribersInRange[$countSubscribersInRange - 1]['id']];
   }
 }

mailpoet/tasks/phpstan/phpstan-7-baseline.neon

@@ -1106,11 +1106,6 @@ parameters:
 			count: 2
 			path: ../../lib/Subscribers/InactiveSubscribersController.php
 
-		-
-			message: "#^Cannot cast mixed to int\\.$#"
-			count: 1
-			path: ../../lib/Subscribers/SubscribersEmailCountsController.php
-
 		-
 			message: "#^Cannot cast mixed to int\\.$#"
 			count: 3

mailpoet/tasks/phpstan/phpstan-8-baseline.neon

@@ -1106,11 +1106,6 @@ parameters:
 			count: 2
 			path: ../../lib/Subscribers/InactiveSubscribersController.php
 
-		-
-			message: "#^Cannot cast mixed to int\\.$#"
-			count: 1
-			path: ../../lib/Subscribers/SubscribersEmailCountsController.php
-
 		-
 			message: "#^Cannot cast mixed to int\\.$#"
 			count: 3