Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Simplify the query to calculate lifetime emails

Browse Source 
Get max and count of subscribers in the query.

[MAILPOET-4177]
This commit is contained in:
Brezo Cordero
2022-04-05 17:47:19 -05:00
committed by Veljko V
parent 7ab8055b69
commit 36baf4c4e3
3 changed files with 7 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
mailpoet/lib/Subscribers/SubscribersEmailCountsController.php
View File

@ -107,10 +107,12 @@ class SubscribersEmailCountsController {
private function countAndMaxOfSubscribersInRange(int $startId, int $batchSize): array {
$result = $this->entityManager->getConnection()->executeQuery("
SELECT s.id FROM {$this->subscribersTable} as s
WHERE s.id >= :startId
ORDER BY s.id
LIMIT :batchSize
SELECT COUNT(ids.id) as count, COALESCE(MAX(ids.id), 0) as max FROM (
SELECT s.id FROM {$this->subscribersTable} as s
WHERE s.id >= :startId
ORDER BY s.id
LIMIT :batchSize
) ids
",
[
'startId' => $startId,
@ -124,16 +126,6 @@ class SubscribersEmailCountsController {
$subscribersInRange = $result->fetchAllAssociative();
$countSubscribersInRange = count(array_map(
function ($id) {
return (int)$id['id'];
},
$subscribersInRange
));
if (!$countSubscribersInRange) {
return [0,0];
}
return [$countSubscribersInRange,$subscribersInRange[$countSubscribersInRange - 1]['id']];
return [$subscribersInRange[0]['count'], $subscribersInRange[0]['max']];
}
}

5
mailpoet/tasks/phpstan/phpstan-7-baseline.neon
View File

@ -1106,11 +1106,6 @@ parameters:
count: 2
path: ../../lib/Subscribers/InactiveSubscribersController.php
-
message: "#^Cannot cast mixed to int\\.$#"
count: 1
path: ../../lib/Subscribers/SubscribersEmailCountsController.php
-
message: "#^Cannot cast mixed to int\\.$#"
count: 3

5
mailpoet/tasks/phpstan/phpstan-8-baseline.neon
View File

@ -1106,11 +1106,6 @@ parameters:
count: 2
path: ../../lib/Subscribers/InactiveSubscribersController.php
-
message: "#^Cannot cast mixed to int\\.$#"
count: 1
path: ../../lib/Subscribers/SubscribersEmailCountsController.php
-
message: "#^Cannot cast mixed to int\\.$#"
count: 3