Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Convert variable names to camel case in strings

Browse Source 
[MAILPOET-1796]
This commit is contained in:
Jan Jakeš
2020-01-09 15:10:24 +01:00
committed by Jan Jakeš
parent 8c848cfa28
commit 3bbc8ea2af
42 changed files with 116 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tasks/release/GitHubController.php
View File

@ -30,7 +30,7 @@ class GitHubController {
'headers' => [
'Accept' => 'application/vnd.github.v3+json',
],
'base_uri' => "https://api.github.com/repos/mailpoet/$github_path/",
'base_uri' => "https://api.github.com/repos/mailpoet/$githubPath/",
]);
}
@ -51,10 +51,10 @@ class GitHubController {
}
private function assignPullRequest($pullRequestNumber) {
$this->httpClient->post("pulls/$pull_request_number/requested_reviewers", [
$this->httpClient->post("pulls/$pullRequestNumber/requested_reviewers", [
'json' => ['reviewers' => [self::QA_GITHUB_LOGIN]],
]);
$this->httpClient->post("issues/$pull_request_number/assignees", [
$this->httpClient->post("issues/$pullRequestNumber/assignees", [
'json' => ['assignees' => [self::QA_GITHUB_LOGIN]],
]);
}
@ -108,7 +108,7 @@ class GitHubController {
}
private function checkPullRequestReviews($pullRequestNumber) {
$response = $this->httpClient->get("pulls/$pull_request_number/reviews");
$response = $this->httpClient->get("pulls/$pullRequestNumber/reviews");
$response = json_decode($response->getBody()->getContents(), true);
$approved = 0;
foreach ($response as $review) {