Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix subscribers' segment filter

Browse Source 
[MAILPOET-4563]
This commit is contained in:
Jan Lysý
2022-08-16 15:41:06 +02:00
committed by Veljko V
parent 6f5ddca2e9
commit 3d4f7cc33f
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mailpoet/lib/Subscribers/SubscriberListingRepository.php
View File

@@ -260,9 +260,7 @@ class SubscriberListingRepository extends ListingRepository {
$queryBuilder $queryBuilder
->select('s') ->select('s')
->from(SegmentEntity::class, 's'); ->from(SegmentEntity::class, 's');
if ($group === 'trash') { if ($group !== 'trash') {
$queryBuilder->andWhere('s.deletedAt IS NOT NULL');
} else {
$queryBuilder->andWhere('s.deletedAt IS NULL'); $queryBuilder->andWhere('s.deletedAt IS NULL');
} }
@@ -285,9 +283,13 @@ class SubscriberListingRepository extends ListingRepository {
} else { } else {
$count = $this->subscribersCountsController->getSegmentStatisticsCount($segment); $count = $this->subscribersCountsController->getSegmentStatisticsCount($segment);
} }
$subscribersCount = (float)$count[$key];
// filter segments without subscribers
if (!$subscribersCount) {
continue;
}
$segmentList[] = [ $segmentList[] = [
'label' => sprintf('%s (%s)', $segment->getName(), number_format((float)$count[$key])), 'label' => sprintf('%s (%s)', $segment->getName(), number_format($subscribersCount)),
'value' => $segment->getId(), 'value' => $segment->getId(),
]; ];
} }