Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add return typehint to check deleted segments method

Browse Source 
[MAILPOET-3418]
This commit is contained in:
Rostislav Wolny
2021-04-01 13:48:03 +02:00
committed by Veljko V
parent bbd4cb98f8
commit 3dc5c5ce80
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Cron/Workers/SendingQueue/SendingQueue.php
View File

@@ -311,9 +311,8 @@ class SendingQueue {
/** /**
* Checks whether some of segments was deleted or trashed * Checks whether some of segments was deleted or trashed
* @param int[] $segmentIds * @param int[] $segmentIds
* @return bool
*/ */
private function checkDeletedSegments(array $segmentIds) { private function checkDeletedSegments(array $segmentIds): bool {
if (count($segmentIds) === 0) { if (count($segmentIds) === 0) {
return true; return true;
} }
@@ -322,7 +321,7 @@ class SendingQueue {
// Some segment was deleted from DB // Some segment was deleted from DB
if (count($segmentIds) > count($segments)) { if (count($segmentIds) > count($segments)) {
return false; return false;
}; }
foreach ($segments as $segment) { foreach ($segments as $segment) {
if ($segment->getDeletedAt() !== null) { if ($segment->getDeletedAt() !== null) {
return false; return false;