- Encasupsulates trigger methods logic into separate classes

- Updates cron router

lib/API/Endpoints/Cron.php

@@ -28,14 +28,9 @@ class Cron {
   }
 
   function getStatus() {
-    $task_scheduler = CronTrigger::getCurrentMethod();
     $daemon = Setting::getValue(CronHelper::DAEMON_SETTING);
-    if($daemon) {
+    return ($daemon) ?
-      return $daemon;
+      $daemon :
-    }
+      array('status' => false);
-    $status = ($task_scheduler === CronTrigger::METHOD_WORDPRESS) ?
-      'wordpress_task_scheduler_enabled' :
-      false;
-    return array('status' => $status);
   }
 }

lib/Config/Initializer.php

@@ -193,8 +193,8 @@ class Initializer {
   }
 
   function setupCronTrigger() {
-    $task_scheduler = new CronTrigger();
+    $cron_trigger = new CronTrigger();
-    $task_scheduler->init();
+    $cron_trigger->init();
   }
 
   function setupImages() {

lib/Config/Populator.php

@@ -78,7 +78,7 @@ class Populator {
     if(!Setting::getValue(CronTrigger::SETTING_NAME)) {
       // disable task scheduler (cron) be default
       Setting::setValue(CronTrigger::SETTING_NAME, array(
-        'method' => CronTrigger::METHOD_WORDPRESS
+        'method' => 'WordPress'
       ));
     }
 

lib/Cron/CronTrigger.php

@@ -1,70 +1,43 @@
 <?php
 namespace MailPoet\Cron;
 
-use MailPoet\Cron\Workers\Scheduler as SchedulerWorker;
-use MailPoet\Cron\Workers\SendingQueue\SendingQueue as SendingQueueWorker;
-use MailPoet\Mailer\MailerLog;
 use MailPoet\Models\Setting;
 
 if(!defined('ABSPATH')) exit;
 
 class CronTrigger {
-  const METHOD_WORDPRESS = 'WordPress';
+  public $current_method;
-  const METHOD_MAILPOET = 'MailPoet';
+  public static $available_methods = array(
+    'mailpoet' => 'MailPoet',
+    'wordpress' => 'WordPress'
+  );
   const SETTING_NAME = 'cron_trigger';
 
   function __construct() {
-    $this->method = self::getCurrentMethod();
+    $this->current_method = self::getCurrentMethod();
+    if(!in_array($this->current_method, self::$available_methods)) {
+      throw new \Exception(__('Task scheduler is not configured'));
+    }
   }
 
   function init() {
     try {
-      // configure task scheduler only outside of cli environment
+      // configure cron trigger only outside of cli environment
       if(php_sapi_name() === 'cli') return;
-      switch($this->method) {
+      $trigger_class = __NAMESPACE__ . '\Triggers\\' . $this->current_method;
-        case self::METHOD_MAILPOET:
+      return (class_exists($trigger_class)) ?
-          return $this->configureMailpoetTrigger();
+        $trigger_class::run() :
-        case self::METHOD_WORDPRESS:
+        false;
-          return $this->configureWordpressTrigger();
-        default:
-          throw new \Exception(__('Task scheduler is not configured'));
-      };
     } catch(\Exception $e) {
-      // ignore exceptions as they should not prevent the rest of the site from loading
+      // cron exceptions should not prevent the rest of the site from loading
-    }
-  }
-
-  function configureMailpoetTrigger() {
-    $supervisor = new Supervisor();
-    $supervisor->checkDaemon();
-  }
-
-  function configureWordpressTrigger() {
-    $scheduled_queues = SchedulerWorker::getScheduledQueues();
-    $running_queues = SendingQueueWorker::getRunningQueues();
-    $sending_limit_reached = MailerLog::isSendingLimitReached();
-    // run cron only when:
-    //   1) there are scheduled queues ready to be processed
-    //   2) queues are already being processed
-    //   3) sending limit has not been reached
-    if(($scheduled_queues || $running_queues) && !$sending_limit_reached) {
-      return $this->configureMailpoetTrigger();
-    }
-    // in all other cases stop (delete) the daemon
-    $cron_daemon = CronHelper::getDaemon();
-    if($cron_daemon) {
-      CronHelper::deleteDaemon();
     }
   }
 
   static function getAvailableMethods() {
-    return array(
+    return self::$available_methods;
-      'mailpoet' => self::METHOD_MAILPOET,
-      'wordpress' => self::METHOD_WORDPRESS
-    );
   }
 
   static function getCurrentMethod() {
-    return Setting::getValue('cron_trigger.method');
+    return Setting::getValue(self::SETTING_NAME . '.method');
   }
 }

lib/Cron/Triggers/MailPoet.php

@@ -0,0 +1,13 @@
+<?php
+namespace MailPoet\Cron\Triggers;
+
+use MailPoet\Cron\Supervisor;
+
+if(!defined('ABSPATH')) exit;
+
+class MailPoet {
+  static function run() {
+    $supervisor = new Supervisor();
+    return $supervisor->checkDaemon();
+  }
+}

lib/Cron/Triggers/WordPress.php

@@ -0,0 +1,31 @@
+<?php
+namespace MailPoet\Cron\Triggers;
+
+use MailPoet\Cron\CronHelper;
+use MailPoet\Cron\Workers\Scheduler as SchedulerWorker;
+use MailPoet\Cron\Workers\SendingQueue\SendingQueue as SendingQueueWorker;
+use MailPoet\Mailer\MailerLog;
+
+if(!defined('ABSPATH')) exit;
+
+class WordPress {
+  static function run() {
+    return (self::checkExecutionRequirements()) ?
+      MailPoet::run() :
+      self::cleanup();
+  }
+
+  static function checkExecutionRequirements() {
+    $scheduled_queues = SchedulerWorker::getScheduledQueues();
+    $running_queues = SendingQueueWorker::getRunningQueues();
+    $sending_limit_reached = MailerLog::isSendingLimitReached();
+    return (($scheduled_queues || $running_queues) && !$sending_limit_reached);
+  }
+
+  static function cleanup() {
+    $cron_daemon = CronHelper::getDaemon();
+    if($cron_daemon) {
+      CronHelper::deleteDaemon();
+    }
+  }
+}

lib/Cron/Workers/SendingQueue/SendingQueue.php

@@ -2,7 +2,6 @@
 namespace MailPoet\Cron\Workers\SendingQueue;
 
 use MailPoet\Cron\CronHelper;
-use MailPoet\Cron\Workers\SendingQueue\Tasks\Cron;
 use MailPoet\Cron\Workers\SendingQueue\Tasks\Mailer as MailerTask;
 use MailPoet\Cron\Workers\SendingQueue\Tasks\Newsletter as NewsletterTask;
 use MailPoet\Cron\Workers\SendingQueue\Tasks\Subscribers as SubscribersTask;
@@ -76,7 +75,6 @@ class SendingQueue {
         CronHelper::enforceExecutionLimit($this->timer);
       }
     }
-    Cron::complete();
   }
 
   function processQueue($queue, $newsletter, $subscribers) {

lib/Cron/Workers/SendingQueue/Tasks/Cron.php

@@ -1,18 +0,0 @@
-<?php
-namespace MailPoet\Cron\Workers\SendingQueue\Tasks;
-
-use MailPoet\Cron\CronHelper;
-use MailPoet\Cron\CronTrigger;
-
-if(!defined('ABSPATH')) exit;
-
-class Cron {
-  static function complete() {
-    // when there are no more queues to process and if the task
-    // scheduler method is WP, delete the cron daemon
-    $task_scheduler = CronTrigger::getCurrentMethod();
-    if($task_scheduler === CronTrigger::METHOD_WORDPRESS) {
-      CronHelper::deleteDaemon();
-    }
-  }
-}