From 3f3b08fc27f80f9d23e3b2fa95663f021c9bed0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Lys=C3=BD?= Date: Wed, 15 Jun 2022 15:27:55 +0200 Subject: [PATCH] Remove redundant check [MAILPOET-4141] --- .../AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php | 2 +- .../lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php b/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php index 7b7fbaa844..a47eade196 100644 --- a/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php +++ b/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php @@ -176,7 +176,7 @@ class PurchasedInCategory { private function getProductCategoryIdsMatchingNewsletterTrigger(NewsletterEntity $automaticEmail, array $orderedCategoryIds): array { $automaticEmailMetaValue = $automaticEmail->getOptionValue(NewsletterOptionFieldEntity::NAME_META); - $optionValue = (is_string($automaticEmailMetaValue) && Helpers::isJson($automaticEmailMetaValue)) ? json_decode($automaticEmailMetaValue, true) : $automaticEmailMetaValue; + $optionValue = Helpers::isJson($automaticEmailMetaValue) ? json_decode($automaticEmailMetaValue, true) : $automaticEmailMetaValue; if (!is_array($optionValue) || empty($optionValue['option'])) { return []; diff --git a/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php b/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php index 142a68aaea..7a1073b364 100644 --- a/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php +++ b/mailpoet/lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php @@ -178,7 +178,7 @@ class PurchasedProduct { private function getProductIdsMatchingNewsletterTrigger(NewsletterEntity $automaticEmail, array $orderedProductIds): array { $automaticEmailMetaValue = $automaticEmail->getOptionValue(NewsletterOptionFieldEntity::NAME_META); - $optionValue = (is_string($automaticEmailMetaValue) && Helpers::isJson($automaticEmailMetaValue)) ? json_decode($automaticEmailMetaValue, true) : $automaticEmailMetaValue; + $optionValue = Helpers::isJson($automaticEmailMetaValue) ? json_decode($automaticEmailMetaValue, true) : $automaticEmailMetaValue; if (!is_array($optionValue) || empty($optionValue['option'])) { return [];