Fix eslint6 react/prefer-stateless-function

[MAILPOET-1140]
This commit is contained in:
Pavel Dohnal
2018-03-15 10:44:13 +00:00
parent 7144d4afa8
commit 4037800c10
5 changed files with 132 additions and 143 deletions

View File

@@ -31,7 +31,6 @@
"react/jsx-boolean-value": 0, "react/jsx-boolean-value": 0,
"react/jsx-no-bind": 0, "react/jsx-no-bind": 0,
"react/no-array-index-key": 0, "react/no-array-index-key": 0,
"react/prefer-stateless-function": 0,
"jsx-a11y/label-has-for": 0, "jsx-a11y/label-has-for": 0,
"jsx-a11y/no-static-element-interactions": 0, "jsx-a11y/no-static-element-interactions": 0,
"jsx-a11y/alt-text": 0, "jsx-a11y/alt-text": 0,

View File

@@ -5,14 +5,13 @@ define([
React, React,
Moment Moment
) => { ) => {
class FormFieldDateYear extends React.Component { function FormFieldDateYear(props) {
render() {
const yearsRange = 100; const yearsRange = 100;
const years = []; const years = [];
if (this.props.placeholder !== undefined) { if (props.placeholder !== undefined) {
years.push(( years.push((
<option value="" key={0}>{ this.props.placeholder }</option> <option value="" key={0}>{ props.placeholder }</option>
)); ));
} }
@@ -27,23 +26,21 @@ define([
} }
return ( return (
<select <select
name={`${this.props.name}[year]`} name={`${props.name}[year]`}
value={this.props.year} value={props.year}
onChange={this.props.onValueChange} onChange={props.onValueChange}
> >
{ years } { years }
</select> </select>
); );
} }
}
class FormFieldDateMonth extends React.Component { function FormFieldDateMonth(props) {
render() {
const months = []; const months = [];
if (this.props.placeholder !== undefined) { if (props.placeholder !== undefined) {
months.push(( months.push((
<option value="" key={0}>{ this.props.placeholder }</option> <option value="" key={0}>{ props.placeholder }</option>
)); ));
} }
@@ -52,28 +49,26 @@ define([
<option <option
key={i} key={i}
value={i} value={i}
>{ this.props.monthNames[i - 1] }</option> >{ props.monthNames[i - 1] }</option>
)); ));
} }
return ( return (
<select <select
name={`${this.props.name}[month]`} name={`${props.name}[month]`}
value={this.props.month} value={props.month}
onChange={this.props.onValueChange} onChange={props.onValueChange}
> >
{ months } { months }
</select> </select>
); );
} }
}
class FormFieldDateDay extends React.Component { function FormFieldDateDay(props) {
render() {
const days = []; const days = [];
if (this.props.placeholder !== undefined) { if (props.placeholder !== undefined) {
days.push(( days.push((
<option value="" key={0}>{ this.props.placeholder }</option> <option value="" key={0}>{ props.placeholder }</option>
)); ));
} }
@@ -88,15 +83,14 @@ define([
return ( return (
<select <select
name={`${this.props.name}[day]`} name={`${props.name}[day]`}
value={this.props.day} value={props.day}
onChange={this.props.onValueChange} onChange={props.onValueChange}
> >
{ days } { days }
</select> </select>
); );
} }
}
class FormFieldDate extends React.Component { class FormFieldDate extends React.Component {
constructor(props) { constructor(props) {

View File

@@ -2,16 +2,15 @@ import React from 'react';
import classNames from 'classnames'; import classNames from 'classnames';
import ReactTooltip from 'react-tooltip'; import ReactTooltip from 'react-tooltip';
class Badge extends React.Component { function Badge(props) {
render() {
const badgeClasses = classNames( const badgeClasses = classNames(
'mailpoet_badge', 'mailpoet_badge',
this.props.type ? `mailpoet_badge_${this.props.type}` : '' props.type ? `mailpoet_badge_${props.type}` : ''
); );
const tooltip = this.props.tooltip ? this.props.tooltip.replace(/\n/g, '<br />') : false; const tooltip = props.tooltip ? props.tooltip.replace(/\n/g, '<br />') : false;
// tooltip ID must be unique, defaults to tooltip text // tooltip ID must be unique, defaults to tooltip text
const tooltipId = this.props.tooltipId || tooltip; const tooltipId = props.tooltipId || tooltip;
return ( return (
<span> <span>
@@ -20,7 +19,7 @@ class Badge extends React.Component {
data-tip={tooltip} data-tip={tooltip}
data-for={tooltipId} data-for={tooltipId}
> >
{this.props.name} {props.name}
</span> </span>
{ tooltip && ( { tooltip && (
<ReactTooltip <ReactTooltip
@@ -31,7 +30,6 @@ class Badge extends React.Component {
) } ) }
</span> </span>
); );
}
} }
export default Badge; export default Badge;

View File

@@ -278,7 +278,7 @@ define(
}, },
handleCheckboxChange: function (event) { handleCheckboxChange: function (event) {
const changeEvent = event; const changeEvent = event;
changeEvent.target.value = this.refs.isScheduledInput.checked ? '1' : '0'; changeEvent.target.value = this.isScheduledInput.checked ? '1' : '0';
return this.handleValueChange(changeEvent); return this.handleValueChange(changeEvent);
}, },
isScheduled: function () { isScheduled: function () {

View File

@@ -2,8 +2,7 @@ import Breadcrumb from 'newsletters/breadcrumb.jsx';
import React from 'react'; import React from 'react';
import MailPoet from 'mailpoet'; import MailPoet from 'mailpoet';
class AutomaticEmailsBreadcrumb extends React.Component { function AutomaticEmailsBreadcrumb(props) {
render() {
const steps = [ const steps = [
{ {
name: 'type', name: 'type',
@@ -33,9 +32,8 @@ class AutomaticEmailsBreadcrumb extends React.Component {
]; ];
return ( return (
<Breadcrumb step={this.props.step} steps={steps} /> <Breadcrumb step={props.step} steps={steps} />
); );
}
} }
module.exports = AutomaticEmailsBreadcrumb; module.exports = AutomaticEmailsBreadcrumb;