From 405476cb7b1fedefe04e4cd0a9c6aaa02af25da0 Mon Sep 17 00:00:00 2001
From: Pavel Dohnal <pavel@mailpoet.com>
Date: Tue, 14 Jul 2020 10:25:23 +0200
Subject: [PATCH] Return array instead of null from api

[MAILPOET-2518]
---
 lib/API/JSON/Response.php        | 11 +++++------
 lib/API/JSON/SuccessResponse.php |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/lib/API/JSON/Response.php b/lib/API/JSON/Response.php
index 8bb41da115..c20323012a 100644
--- a/lib/API/JSON/Response.php
+++ b/lib/API/JSON/Response.php
@@ -30,14 +30,13 @@ abstract class Response {
     if (!empty($this->meta)) {
       $response['meta'] = $this->meta;
     }
-    if ($data !== null) {
-      $response = array_merge($response, $data);
+    if ($data === null) {
+      $data = [];
     }
+    $response = array_merge($response, $data);
 
-    if (!empty($response)) {
-      @header('Content-Type: application/json; charset=' . get_option('blog_charset'));
-      echo WPFunctions::get()->wpJsonEncode($response);
-    }
+    @header('Content-Type: application/json; charset=' . get_option('blog_charset'));
+    echo WPFunctions::get()->wpJsonEncode($response);
     die();
   }
 
diff --git a/lib/API/JSON/SuccessResponse.php b/lib/API/JSON/SuccessResponse.php
index 6720e3d5e0..0e600e6def 100644
--- a/lib/API/JSON/SuccessResponse.php
+++ b/lib/API/JSON/SuccessResponse.php
@@ -11,7 +11,7 @@ class SuccessResponse extends Response {
   }
 
   public function getData() {
-    if ($this->data === null) return null;
+    if ($this->data === null) return [];
 
     return [
       'data' => $this->data,