Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor simple array usages in models

Browse Source 
[MAILPOET-1495]
This commit is contained in:
Rostislav Wolný
2018-10-10 19:32:26 +02:00
parent 112f7b21d5
commit 436406f800
2 changed files with 26 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/Models/Newsletter.php
View File

@@ -367,12 +367,12 @@ class Newsletter extends Model {
if($duplicate->getErrors() === false) {
// create relationships between duplicate and segments
$segments = $this->segments()->findArray();
$segments = $this->segments()->findMany();
if(!empty($segments)) {
foreach($segments as $segment) {
$relation = NewsletterSegment::create();
$relation->segment_id = $segment['id'];
$relation->segment_id = $segment->id;
$relation->newsletter_id = $duplicate->id;
$relation->save();
}
@@ -380,14 +380,14 @@ class Newsletter extends Model {
// duplicate options
$options = NewsletterOption::where('newsletter_id', $this->id)
->findArray();
->findMany();
if(!empty($options)) {
foreach($options as $option) {
$relation = NewsletterOption::create();
$relation->newsletter_id = $duplicate->id;
$relation->option_field_id = $option['option_field_id'];
$relation->value = $option['value'];
$relation->option_field_id = $option->option_field_id;
$relation->value = $option->value;
$relation->save();
}
}
@@ -426,12 +426,12 @@ class Newsletter extends Model {
if($notification_history->getErrors() === false) {
// create relationships between notification history and segments
$segments = $this->segments()->findArray();
$segments = $this->segments()->findMany();
if(!empty($segments)) {
foreach($segments as $segment) {
$relation = NewsletterSegment::create();
$relation->segment_id = $segment['id'];
$relation->segment_id = $segment->id;
$relation->newsletter_id = $notification_history->id;
$relation->save();
}