Add public keyword to methods

[MAILPOET-2413]

lib/Router/Endpoints/CronDaemon.php

@@ -27,20 +27,20 @@ class CronDaemon {
   /** @var CronHelper */
   private $cron_helper;
 
-  function __construct(DaemonHttpRunner $daemon_runner, CronHelper $cron_helper) {
+  public function __construct(DaemonHttpRunner $daemon_runner, CronHelper $cron_helper) {
     $this->daemon_runner = $daemon_runner;
     $this->cron_helper = $cron_helper;
   }
 
-  function run($data) {
+  public function run($data) {
     $this->daemon_runner->run($data);
   }
 
-  function ping() {
+  public function ping() {
      die($this->cron_helper->pingDaemon());
   }
 
-  function pingResponse() {
+  public function pingResponse() {
     $this->daemon_runner->ping();
   }
 }

lib/Router/Endpoints/Subscription.php

@@ -26,15 +26,15 @@ class Subscription {
   /** @var UserSubscription\Pages */
   private $subscription_pages;
 
-  function __construct(UserSubscription\Pages $subscription_pages) {
+  public function __construct(UserSubscription\Pages $subscription_pages) {
     $this->subscription_pages = $subscription_pages;
   }
 
-  function captcha($data) {
+  public function captcha($data) {
     $this->initSubscriptionPage(UserSubscription\Pages::ACTION_CAPTCHA, $data);
   }
 
-  function captchaImage($data) {
+  public function captchaImage($data) {
     $captcha = new UserSubscription\Captcha;
     $width = !empty($data['width']) ? (int)$data['width'] : null;
     $height = !empty($data['height']) ? (int)$data['height'] : null;
@@ -42,16 +42,16 @@ class Subscription {
     return $captcha->renderImage($width, $height, $session_id);
   }
 
-  function confirm($data) {
+  public function confirm($data) {
     $subscription = $this->initSubscriptionPage(UserSubscription\Pages::ACTION_CONFIRM, $data);
     $subscription->confirm();
   }
 
-  function manage($data) {
+  public function manage($data) {
     $this->initSubscriptionPage(UserSubscription\Pages::ACTION_MANAGE, $data);
   }
 
-  function unsubscribe($data) {
+  public function unsubscribe($data) {
     $subscription = $this->initSubscriptionPage(UserSubscription\Pages::ACTION_UNSUBSCRIBE, $data);
     $subscription->unsubscribe();
   }

lib/Router/Endpoints/Track.php

@@ -41,15 +41,15 @@ class Track {
     $this->link_tokens = $link_tokens;
   }
 
-  function click($data) {
+  public function click($data) {
     return $this->clicks->track($this->_processTrackData($data));
   }
 
-  function open($data) {
+  public function open($data) {
     return $this->opens->track($this->_processTrackData($data));
   }
 
-  function _processTrackData($data) {
+  public function _processTrackData($data) {
     $data = (object)Links::transformUrlDataObject($data);
     if (empty($data->queue_id) ||
       empty($data->subscriber_id) ||
@@ -73,7 +73,7 @@ class Track {
     return $this->_validateTrackData($data);
   }
 
-  function _validateTrackData($data) {
+  public function _validateTrackData($data) {
     if (!$data->subscriber || !$data->queue || !$data->newsletter) return false;
     $subscriber_token_match = $this->link_tokens->verifyToken($data->subscriber, $data->subscriber_token);
     if (!$subscriber_token_match) {
@@ -89,7 +89,7 @@ class Track {
       false;
   }
 
-  function terminate($code) {
+  public function terminate($code) {
     WPFunctions::get()->statusHeader($code);
     WPFunctions::get()->getTemplatePart((string)$code);
     exit;

lib/Router/Endpoints/ViewInBrowser.php

@@ -32,20 +32,20 @@ class ViewInBrowser {
   /** @var Emoji */
   private $emoji;
 
-  function __construct(AccessControl $access_control, SettingsController $settings, LinkTokens $link_tokens, Emoji $emoji) {
+  public function __construct(AccessControl $access_control, SettingsController $settings, LinkTokens $link_tokens, Emoji $emoji) {
     $this->access_control = $access_control;
     $this->settings = $settings;
     $this->link_tokens = $link_tokens;
     $this->emoji = $emoji;
   }
 
-  function view($data) {
+  public function view($data) {
     $data = $this->_processBrowserPreviewData($data);
     $view_in_browser = new NewsletterViewInBrowser($this->emoji, (bool)$this->settings->get('tracking.enabled'));
     return $this->_displayNewsletter($view_in_browser->view($data));
   }
 
-  function _processBrowserPreviewData($data) {
+  public function _processBrowserPreviewData($data) {
     $data = (object)NewsletterUrl::transformUrlDataObject($data);
     return ($this->_validateBrowserPreviewData($data)) ?
       $data :
@@ -56,7 +56,7 @@ class ViewInBrowser {
    * @param \stdClass $data
    * @return bool|\stdClass
    */
-  function _validateBrowserPreviewData($data) {
+  public function _validateBrowserPreviewData($data) {
     // either newsletter ID or hash must be defined, and newsletter must exist
     if (empty($data->newsletter_id) && empty($data->newsletter_hash)) return false;
     $data->newsletter = (!empty($data->newsletter_hash)) ?
@@ -113,13 +113,13 @@ class ViewInBrowser {
     return $data;
   }
 
-  function _displayNewsletter($result) {
+  public function _displayNewsletter($result) {
     header('Content-Type: text/html; charset=utf-8');
     echo $result;
     exit;
   }
 
-  function _abort() {
+  public function _abort() {
     WPFunctions::get()->statusHeader(404);
     exit;
   }

lib/Router/Router.php

@@ -20,7 +20,7 @@ class Router {
   const RESPONSE_ERROR = 404;
   const RESPONE_FORBIDDEN = 403;
 
-  function __construct(AccessControl $access_control, ContainerInterface $container, $api_data = false) {
+  public function __construct(AccessControl $access_control, ContainerInterface $container, $api_data = false) {
     $api_data = ($api_data) ? $api_data : $_GET;
     $this->api_request = is_array($api_data) && array_key_exists(self::NAME, $api_data);
     $this->endpoint = isset($api_data['endpoint']) ?
@@ -36,7 +36,7 @@ class Router {
     $this->container = $container;
   }
 
-  function init() {
+  public function init() {
     if (!$this->api_request) return;
     $endpoint_class = __NAMESPACE__ . "\\Endpoints\\" . ucfirst($this->endpoint);
 
@@ -62,7 +62,7 @@ class Router {
     }
   }
 
-  static function decodeRequestData($data) {
+  public static function decodeRequestData($data) {
     $data = json_decode(base64_decode($data), true);
     if (!is_array($data)) {
       $data = [];
@@ -70,11 +70,11 @@ class Router {
     return $data;
   }
 
-  static function encodeRequestData($data) {
+  public static function encodeRequestData($data) {
     return rtrim(base64_encode(json_encode($data)), '=');
   }
 
-  static function buildRequest($endpoint, $action, $data = false) {
+  public static function buildRequest($endpoint, $action, $data = false) {
     $params = [
       self::NAME => '',
       'endpoint' => $endpoint,
@@ -86,12 +86,12 @@ class Router {
     return WPFunctions::get()->addQueryArg($params, WPFunctions::get()->homeUrl());
   }
 
-  function terminateRequest($code, $message) {
+  public function terminateRequest($code, $message) {
     WPFunctions::get()->statusHeader($code, $message);
     exit;
   }
 
-  function validatePermissions($endpoint_action, $permissions) {
+  public function validatePermissions($endpoint_action, $permissions) {
     // validate action permission if defined, otherwise validate global permission
     return(!empty($permissions['actions'][$endpoint_action])) ?
       $this->access_control->validatePermission($permissions['actions'][$endpoint_action]) :