Add public keyword to methods
[MAILPOET-2413]
This commit is contained in:
@@ -7,12 +7,12 @@ use MailPoetVendor\Symfony\Component\DependencyInjection\ContainerBuilder;
|
||||
|
||||
// phpcs:ignore Squiz.Classes.ClassFileName
|
||||
class ContainerConfigurator implements IContainerConfigurator {
|
||||
function configure(ContainerBuilder $container) {
|
||||
public function configure(ContainerBuilder $container) {
|
||||
}
|
||||
|
||||
function getDumpNamespace() {
|
||||
public function getDumpNamespace() {
|
||||
}
|
||||
|
||||
function getDumpClassname() {
|
||||
public function getDumpClassname() {
|
||||
}
|
||||
}
|
||||
|
@@ -2,7 +2,7 @@
|
||||
|
||||
// phpcs:ignore
|
||||
class WooCommerce {
|
||||
function mailer() {
|
||||
public function mailer() {
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -13,18 +13,18 @@ class ChangelogController {
|
||||
/** @var JiraController */
|
||||
private $jira;
|
||||
|
||||
function __construct(JiraController $jira, $readme_file) {
|
||||
public function __construct(JiraController $jira, $readme_file) {
|
||||
$this->jira = $jira;
|
||||
$this->readme_file = $readme_file;
|
||||
}
|
||||
|
||||
function update($version_name = null) {
|
||||
public function update($version_name = null) {
|
||||
$changelog_data = $this->get($version_name);
|
||||
$this->updateReadme($changelog_data[0], $changelog_data[1]);
|
||||
return $changelog_data;
|
||||
}
|
||||
|
||||
function get($version_name = null) {
|
||||
public function get($version_name = null) {
|
||||
$version = $this->jira->getVersion($version_name);
|
||||
$issues = $this->jira->getIssuesDataForVersion($version);
|
||||
$heading = $this->renderHeading($version);
|
||||
|
@@ -47,7 +47,7 @@ class JiraController {
|
||||
/**
|
||||
* @see https://developer.atlassian.com/cloud/jira/platform/rest/v3/#api-api-3-project-projectIdOrKey-versions-get
|
||||
*/
|
||||
function getVersion($version_name = null) {
|
||||
public function getVersion($version_name = null) {
|
||||
$response = $this->http_client->get("project/$this->project/versions");
|
||||
$versions = json_decode($response->getBody()->getContents(), true);
|
||||
if ($version_name === null) {
|
||||
@@ -61,7 +61,7 @@ class JiraController {
|
||||
throw new \Exception('Unknown project version');
|
||||
}
|
||||
|
||||
function getLastVersion() {
|
||||
public function getLastVersion() {
|
||||
$response = $this->http_client->get("project/$this->project/version", [
|
||||
'query' => [
|
||||
'maxResults' => 1,
|
||||
@@ -75,7 +75,7 @@ class JiraController {
|
||||
return reset($version['values']);
|
||||
}
|
||||
|
||||
function getLastReleasedVersion() {
|
||||
public function getLastReleasedVersion() {
|
||||
$response = $this->http_client->get("project/$this->project/version", [
|
||||
'query' => [
|
||||
'maxResults' => 1,
|
||||
@@ -93,7 +93,7 @@ class JiraController {
|
||||
/**
|
||||
* @see https://developer.atlassian.com/cloud/jira/platform/rest/v3/#api-api-3-version-post
|
||||
*/
|
||||
function createVersion($version_name) {
|
||||
public function createVersion($version_name) {
|
||||
$data = [
|
||||
'name' => $version_name,
|
||||
'archived' => false,
|
||||
@@ -105,7 +105,7 @@ class JiraController {
|
||||
return json_decode($response->getBody()->getContents(), true);
|
||||
}
|
||||
|
||||
function releaseVersion($version_name) {
|
||||
public function releaseVersion($version_name) {
|
||||
$version = $this->getVersion($version_name);
|
||||
$response = $this->http_client->put("version/$version[id]", [
|
||||
'json' => [
|
||||
@@ -116,7 +116,7 @@ class JiraController {
|
||||
return json_decode($response->getBody()->getContents(), true);
|
||||
}
|
||||
|
||||
function getIssuesDataForVersion($version) {
|
||||
public function getIssuesDataForVersion($version) {
|
||||
$changelog_id = self::CHANGELOG_FIELD_ID;
|
||||
$release_note_id = self::RELEASENOTE_FIELD_ID;
|
||||
$pull_requests_id = self::PULL_REQUESTS_ID;
|
||||
@@ -136,7 +136,7 @@ class JiraController {
|
||||
/**
|
||||
* @see https://developer.atlassian.com/cloud/jira/platform/rest/v3/#api-api-3-search-get
|
||||
*/
|
||||
function search($jql, array $fields = null) {
|
||||
public function search($jql, array $fields = null) {
|
||||
$params = ['jql' => $jql];
|
||||
if ($fields) {
|
||||
$params['fields'] = join(',', $fields);
|
||||
@@ -148,7 +148,7 @@ class JiraController {
|
||||
/**
|
||||
* @see https://developer.atlassian.com/cloud/jira/platform/rest/v3/#api-api-3-issue-issueIdOrKey-put
|
||||
*/
|
||||
function updateIssue($key, $data) {
|
||||
public function updateIssue($key, $data) {
|
||||
$this->http_client->put("issue/$key", ['json' => $data]);
|
||||
}
|
||||
}
|
||||
|
@@ -10,12 +10,12 @@ class ReleaseVersionController {
|
||||
/** @var string */
|
||||
private $project;
|
||||
|
||||
function __construct(JiraController $jira, $project) {
|
||||
public function __construct(JiraController $jira, $project) {
|
||||
$this->jira = $jira;
|
||||
$this->project = $project;
|
||||
}
|
||||
|
||||
function assignVersionToCompletedTickets($version = null) {
|
||||
public function assignVersionToCompletedTickets($version = null) {
|
||||
$version = $this->ensureCorrectVersion($version);
|
||||
if (!$version) {
|
||||
throw new \Exception('The version is invalid or already released');
|
||||
@@ -32,7 +32,7 @@ class ReleaseVersionController {
|
||||
return [$version, join("\n", $output)];
|
||||
}
|
||||
|
||||
function determineNextVersion() {
|
||||
public function determineNextVersion() {
|
||||
$last_version = $this->jira->getLastReleasedVersion();
|
||||
|
||||
$part_to_increment = VersionHelper::PATCH;
|
||||
|
@@ -9,7 +9,7 @@ class VersionHelper {
|
||||
const MINOR = 'Minor';
|
||||
const PATCH = 'Patch';
|
||||
|
||||
static function incrementVersion($version, $part_to_increment = self::PATCH) {
|
||||
public static function incrementVersion($version, $part_to_increment = self::PATCH) {
|
||||
$parsed_version = is_array($version) ? $version : self::parseVersion($version);
|
||||
|
||||
switch ($part_to_increment) {
|
||||
@@ -26,7 +26,7 @@ class VersionHelper {
|
||||
return is_array($version) ? $parsed_version : self::buildVersion($parsed_version);
|
||||
}
|
||||
|
||||
static function parseVersion($version) {
|
||||
public static function parseVersion($version) {
|
||||
if (!preg_match(self::VERSION_REGEXP, $version, $matches)) {
|
||||
throw new \Exception('Incorrect version format');
|
||||
}
|
||||
@@ -37,15 +37,15 @@ class VersionHelper {
|
||||
];
|
||||
}
|
||||
|
||||
static function buildVersion(array $parts) {
|
||||
public static function buildVersion(array $parts) {
|
||||
return sprintf('%d.%d.%d', $parts[self::MAJOR], $parts[self::MINOR], $parts[self::PATCH]);
|
||||
}
|
||||
|
||||
static function buildMinorVersion(array $parts) {
|
||||
public static function buildMinorVersion(array $parts) {
|
||||
return sprintf('%d.%d', $parts[self::MAJOR], $parts[self::MINOR]);
|
||||
}
|
||||
|
||||
static function validateVersion($version) {
|
||||
public static function validateVersion($version) {
|
||||
return preg_match(self::VERSION_REGEXP, $version);
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user