Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add public keyword to methods

Browse Source 
[MAILPOET-2413]
This commit is contained in:
Amine Ben hammou
2019-12-26 12:56:49 +01:00
committed by wxa
parent ec409042d5
commit 43df66d162
823 changed files with 4440 additions and 4440 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/integration/API/JSON/APITest.php
View File

@ -30,7 +30,7 @@ class APITest extends \MailPoetTest {
/** @var SettingsController */
private $settings;
function _before() {
public function _before() {
parent::_before();
// create WP user
$this->wp_user_id = null;
@ -55,7 +55,7 @@ class APITest extends \MailPoetTest {
);
}
function testItCallsAPISetupAction() {
public function testItCallsAPISetupAction() {
$called = false;
(new WPFunctions)->addAction(
'mailpoet_api_setup',
@ -77,7 +77,7 @@ class APITest extends \MailPoetTest {
expect($called)->true();
}
function testItCanAddEndpointNamespaces() {
public function testItCanAddEndpointNamespaces() {
expect($this->api->getEndpointNamespaces())->count(1);
$namespace = [
@ -91,7 +91,7 @@ class APITest extends \MailPoetTest {
expect($namespaces[$namespace['version']][0])->equals($namespace['name']);
}
function testItReturns400ErrorWhenAPIVersionIsNotSpecified() {
public function testItReturns400ErrorWhenAPIVersionIsNotSpecified() {
$data = [
'endpoint' => 'a_p_i_test_namespaced_endpoint_stub_v1',
'method' => 'test',
@ -101,7 +101,7 @@ class APITest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
}
function testItAcceptsAndProcessesAPIVersion() {
public function testItAcceptsAndProcessesAPIVersion() {
$namespace = [
'name' => 'MailPoet\API\JSON\v2',
'version' => 'v2',
@ -121,7 +121,7 @@ class APITest extends \MailPoetTest {
);
}
function testItCallsAddedEndpoints() {
public function testItCallsAddedEndpoints() {
$namespace = [
'name' => 'MailPoet\API\JSON\v1',
'version' => 'v1',
@ -140,7 +140,7 @@ class APITest extends \MailPoetTest {
expect($response->getData()['data'])->equals($data['data']);
}
function testItCallsAddedEndpointsForSpecificAPIVersion() {
public function testItCallsAddedEndpointsForSpecificAPIVersion() {
$namespace = [
'name' => 'MailPoet\API\JSON\v2',
'version' => 'v2',
@ -157,7 +157,7 @@ class APITest extends \MailPoetTest {
expect($response->getData()['data'])->equals($data['api_version']);
}
function testItValidatesPermissionBeforeProcessingEndpointMethod() {
public function testItValidatesPermissionBeforeProcessingEndpointMethod() {
$namespace = [
'name' => 'MailPoet\API\JSON\v1',
'version' => 'v1',
@ -193,7 +193,7 @@ class APITest extends \MailPoetTest {
expect($response->getData()['data'])->equals($data['data']);
}
function testItReturnsForbiddenResponseWhenPermissionFailsValidation() {
public function testItReturnsForbiddenResponseWhenPermissionFailsValidation() {
$namespace = [
'name' => 'MailPoet\API\JSON\v1',
'version' => 'v1',
@ -216,7 +216,7 @@ class APITest extends \MailPoetTest {
expect($response->status)->equals(Response::STATUS_FORBIDDEN);
}
function testItValidatesGlobalPermission() {
public function testItValidatesGlobalPermission() {
$permissions = [
'global' => AccessControl::PERMISSION_MANAGE_SETTINGS,
];
@ -247,7 +247,7 @@ class APITest extends \MailPoetTest {
expect($api->validatePermissions(null, $permissions))->true();
}
function testItValidatesEndpointMethodPermission() {
public function testItValidatesEndpointMethodPermission() {
$permissions = [
'global' => null,
'methods' => [
@ -282,7 +282,7 @@ class APITest extends \MailPoetTest {
expect($api->validatePermissions('test', $permissions))->true();
}
function testItThrowsExceptionWhenInvalidEndpointMethodIsCalled() {
public function testItThrowsExceptionWhenInvalidEndpointMethodIsCalled() {
$namespace = [
'name' => 'MailPoet\API\JSON\v2',
'version' => 'v2',
@ -301,7 +301,7 @@ class APITest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Invalid API endpoint method.');
}
function _after() {
public function _after() {
wp_delete_user($this->wp_user_id);
}
}

4
tests/integration/API/JSON/APITestNamespacedEndpointStubV1.php
View File

@ -14,11 +14,11 @@ class APITestNamespacedEndpointStubV1 extends APIEndpoint {
],
];
function test($data) {
public function test($data) {
return $this->successResponse($data);
}
function restricted($data) {
public function restricted($data) {
return $this->successResponse($data);
}
}

2
tests/integration/API/JSON/APITestNamespacedEndpointStubV2.php
View File

@ -13,7 +13,7 @@ class APITestNamespacedEndpointStubV2 extends APIEndpoint {
],
];
function testVersion() {
public function testVersion() {
return $this->successResponse('v2');
}
}

4
tests/integration/API/JSON/v1/AutomatedLatestContentTest.php
View File

@ -6,7 +6,7 @@ use MailPoet\API\JSON\v1\AutomatedLatestContent;
use MailPoet\WP\Functions as WPFunctions;
class AutomatedLatestContentTest extends \MailPoetTest {
function testItGetsPostTypes() {
public function testItGetsPostTypes() {
$endpoint = new AutomatedLatestContent(new \MailPoet\Newsletter\AutomatedLatestContent(), new WPFunctions);
$response = $endpoint->getPostTypes();
expect($response->data)->notEmpty();
@ -17,7 +17,7 @@ class AutomatedLatestContentTest extends \MailPoetTest {
}
}
function testItDoesNotGetPostTypesExludedFromSearch() {
public function testItDoesNotGetPostTypesExludedFromSearch() {
$endpoint = new AutomatedLatestContent(new \MailPoet\Newsletter\AutomatedLatestContent(), new WPFunctions);
$response = $endpoint ->getPostTypes();
// WP's default post type 'revision' is excluded from search

14
tests/integration/API/JSON/v1/AutomaticEmailsTest.php
View File

@ -5,10 +5,10 @@ namespace MailPoet\API\JSON\v1;
use MailPoet\WP\Functions as WPFunctions;
class AutomaticEmailsTest extends \MailPoetTest {
function _before() {
public function _before() {
$this->wp = new WPFunctions;
}
function testItRequiresProperlyFormattedRequestWhenGettingEventOptions() {
public function testItRequiresProperlyFormattedRequestWhenGettingEventOptions() {
$API = new AutomaticEmails();
$expected_error_message = 'Improperly formatted request.';
@ -53,7 +53,7 @@ class AutomaticEmailsTest extends \MailPoetTest {
expect($result->errors[0]['message'])->equals($expected_error_message);
}
function testItRequiresValidEventFilterWhenGettingEventOptions() {
public function testItRequiresValidEventFilterWhenGettingEventOptions() {
$API = new AutomaticEmails();
$expected_error_message = 'Automatic email event filter does not exist.';
@ -94,7 +94,7 @@ class AutomaticEmailsTest extends \MailPoetTest {
$this->wp->removeAllFilters('test_filter');
}
function testItGetsEventOptions() {
public function testItGetsEventOptions() {
$API = new AutomaticEmails();
$this->wp->addFilter('mailpoet_automatic_email_test', function() {
@ -133,7 +133,7 @@ class AutomaticEmailsTest extends \MailPoetTest {
$this->wp->removeAllFilters('test_filter');
}
function testItRequiresProperlyFormattedRequestWhenGettingEventShortcodes() {
public function testItRequiresProperlyFormattedRequestWhenGettingEventShortcodes() {
$API = new AutomaticEmails();
$expected_error_message = 'Improperly formatted request.';
@ -154,7 +154,7 @@ class AutomaticEmailsTest extends \MailPoetTest {
expect($result->errors[0]['message'])->equals($expected_error_message);
}
function testItRequiresValidEventWhenGettingEventShortcodes() {
public function testItRequiresValidEventWhenGettingEventShortcodes() {
$API = new AutomaticEmails();
$expected_error_message = 'Automatic email event does not exist.';
@ -185,7 +185,7 @@ class AutomaticEmailsTest extends \MailPoetTest {
$this->wp->removeAllFilters('mailpoet_automatic_email_test');
}
function testItGetsEventShortcodes() {
public function testItGetsEventShortcodes() {
$API = new AutomaticEmails();
$shortcodes = [
[

10
tests/integration/API/JSON/v1/CustomFieldsTest.php
View File

@ -59,7 +59,7 @@ class CustomFieldsTest extends \MailPoetTest {
],
];
function _before() {
public function _before() {
parent::_before();
$this->repository = ContainerWrapper::getInstance(WP_DEBUG)->get(CustomFieldsRepository::class);
$this->repository->truncate();
@ -68,7 +68,7 @@ class CustomFieldsTest extends \MailPoetTest {
}
}
function testItCanGetAllCustomFields() {
public function testItCanGetAllCustomFields() {
$router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());
$response = $router->getAll();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -81,7 +81,7 @@ class CustomFieldsTest extends \MailPoetTest {
}
}
function testItCanDeleteACustomField() {
public function testItCanDeleteACustomField() {
$custom_field = CustomField::where('type', 'date')->findOne();
$custom_field_id = $custom_field->id();
@ -96,7 +96,7 @@ class CustomFieldsTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
function testItCanSaveACustomField() {
public function testItCanSaveACustomField() {
$new_custom_field = [
'name' => 'New custom field',
'type' => 'text',
@ -120,7 +120,7 @@ class CustomFieldsTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
}
function testItCanGetACustomField() {
public function testItCanGetACustomField() {
$custom_field = $this->repository->findOneBy(['name' => 'CF: text']);
$router = new CustomFields($this->repository, new CustomFieldsResponseBuilder());

20
tests/integration/API/JSON/v1/DynamicSegmentsTest.php
View File

@ -27,12 +27,12 @@ class DynamicSegmentsTest extends \MailPoetTest {
/** @var Handler */
private $listing_handler;
function _before() {
public function _before() {
$this->bulk_action = ContainerWrapper::getInstance()->get(BulkActionController::class);
$this->listing_handler = ContainerWrapper::getInstance()->get(Handler::class);
}
function testGetReturnsResponse() {
public function testGetReturnsResponse() {
$loader = Stub::makeEmpty('\MailPoet\DynamicSegments\Persistence\Loading\SingleSegmentLoader', [
'load' => function () {
$dynamic_segment = DynamicSegment::create();
@ -58,7 +58,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
]);
}
function testGetReturnsError() {
public function testGetReturnsError() {
$loader = Stub::makeEmpty('\MailPoet\DynamicSegments\Persistence\Loading\SingleSegmentLoader', [
'load' => function () {
throw new \InvalidArgumentException('segment not found');
@ -70,7 +70,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->status)->equals(self::SEGMENT_NOT_FOUND_RESPONSE_CODE);
}
function testSaverSavesData() {
public function testSaverSavesData() {
$mapper = Stub::makeEmpty('\MailPoet\DynamicSegments\Mappers\FormDataMapper', ['mapDataToDB' => Expected::once(function () {
$dynamic_segment = DynamicSegment::create();
$dynamic_segment->hydrate([
@ -87,7 +87,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->status)->equals(self::SUCCESS_RESPONSE_CODE);
}
function testSaverReturnsErrorOnInvalidData() {
public function testSaverReturnsErrorOnInvalidData() {
$mapper = Stub::makeEmpty('\MailPoet\DynamicSegments\Mappers\FormDataMapper', ['mapDataToDB' => Expected::once(function () {
throw new InvalidSegmentTypeException();
})]);
@ -99,7 +99,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->status)->equals(self::INVALID_DATA_RESPONSE_CODE);
}
function testSaverReturnsErrorOnSave() {
public function testSaverReturnsErrorOnSave() {
$mapper = Stub::makeEmpty('\MailPoet\DynamicSegments\Mappers\FormDataMapper', ['mapDataToDB' => Expected::once(function () {
$dynamic_segment = DynamicSegment::create();
$dynamic_segment->hydrate([
@ -119,7 +119,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Error saving data');
}
function testItCanTrashASegment() {
public function testItCanTrashASegment() {
DynamicSegment::deleteMany();
$dynamic_segment = DynamicSegment::createOrUpdate([
'name' => 'Trash test',
@ -144,7 +144,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
$dynamic_segment->delete();
}
function testItCanRestoreASegment() {
public function testItCanRestoreASegment() {
DynamicSegment::deleteMany();
$dynamic_segment = DynamicSegment::createOrUpdate([
'name' => 'Restore test',
@ -169,7 +169,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
$dynamic_segment->delete();
}
function testItCanDeleteASegment() {
public function testItCanDeleteASegment() {
DynamicSegment::deleteMany();
$dynamic_segment = DynamicSegment::createOrUpdate([
'name' => 'Delete test',
@ -195,7 +195,7 @@ class DynamicSegmentsTest extends \MailPoetTest {
expect(DynamicSegmentFilter::findOne($filter->id))->equals(false);
}
function testItCanBulkDeleteSegments() {
public function testItCanBulkDeleteSegments() {
DynamicSegment::deleteMany();
$dynamic_segment_1 = DynamicSegment::createOrUpdate([
'name' => 'Test 1',

14
tests/integration/API/JSON/v1/FeatureFlagsTest.php
View File

@ -17,14 +17,14 @@ class FeatureFlagsTest extends \MailPoetTest {
/** @var FeatureFlagsRepository */
private $repository;
function _before() {
public function _before() {
parent::_before();
$this->repository = $this->di_container->get(FeatureFlagsRepository::class);
$table_name = $this->entity_manager->getClassMetadata(FeatureFlagEntity::class)->getTableName();
$this->entity_manager->getConnection()->executeUpdate("TRUNCATE $table_name");
}
function testItReturnsDefaults() {
public function testItReturnsDefaults() {
$endpoint = $this->createEndpointWithFeatureDefaults([
'feature-a' => true,
'feature-b' => false,
@ -44,7 +44,7 @@ class FeatureFlagsTest extends \MailPoetTest {
]);
}
function testItReturnsDatabaseValue() {
public function testItReturnsDatabaseValue() {
$this->repository->createOrUpdate([
'name' => 'feature-a',
'value' => false,
@ -63,7 +63,7 @@ class FeatureFlagsTest extends \MailPoetTest {
]);
}
function testItSetsDatabaseValue() {
public function testItSetsDatabaseValue() {
$endpoint = $this->createEndpointWithFeatureDefaults([
'feature-a' => true,
]);
@ -80,7 +80,7 @@ class FeatureFlagsTest extends \MailPoetTest {
}
function testItUpdatesDatabaseValue() {
public function testItUpdatesDatabaseValue() {
$this->repository->createOrUpdate([
'name' => 'feature-a',
'value' => false,
@ -101,7 +101,7 @@ class FeatureFlagsTest extends \MailPoetTest {
expect($features[0]->getValue())->equals(true);
}
function testItDoesNotReturnUnknownFlag() {
public function testItDoesNotReturnUnknownFlag() {
$this->repository->createOrUpdate([
'name' => 'feature-unknown',
'value' => true,
@ -111,7 +111,7 @@ class FeatureFlagsTest extends \MailPoetTest {
expect($endpoint->getAll()->data)->isEmpty();
}
function testItDoesNotSaveUnknownFlag() {
public function testItDoesNotSaveUnknownFlag() {
$endpoint = $this->createEndpointWithFeatureDefaults([]);
$response = $endpoint->set([
'feature-unknown' => false,

28
tests/integration/API/JSON/v1/FormsTest.php
View File

@ -13,7 +13,7 @@ class FormsTest extends \MailPoetTest {
/** @var Forms */
private $endpoint;
function _before() {
public function _before() {
parent::_before();
$this->endpoint = ContainerWrapper::getInstance()->get(Forms::class);
$this->form_1 = Form::createOrUpdate(['name' => 'Form 1']);
@ -23,7 +23,7 @@ class FormsTest extends \MailPoetTest {
Segment::createOrUpdate(['name' => 'Segment 2']);
}
function testItCanGetAForm() {
public function testItCanGetAForm() {
$response = $this->endpoint->get(/* missing id */);
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
expect($response->errors[0]['message'])->equals('This form does not exist.');
@ -39,7 +39,7 @@ class FormsTest extends \MailPoetTest {
);
}
function testItCanGetListingData() {
public function testItCanGetListingData() {
$response = $this->endpoint->listing();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -54,7 +54,7 @@ class FormsTest extends \MailPoetTest {
expect($response->data[2]['name'])->equals('Form 3');
}
function testItCanCreateANewForm() {
public function testItCanCreateANewForm() {
$response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -63,7 +63,7 @@ class FormsTest extends \MailPoetTest {
expect($response->data['name'])->equals('New form');
}
function testItCanSaveAForm() {
public function testItCanSaveAForm() {
$form_data = [
'name' => 'My first form',
];
@ -75,7 +75,7 @@ class FormsTest extends \MailPoetTest {
);
}
function testItCanPreviewAForm() {
public function testItCanPreviewAForm() {
$response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -88,7 +88,7 @@ class FormsTest extends \MailPoetTest {
expect($response->data['css'])->notEmpty();
}
function testItCanExportAForm() {
public function testItCanExportAForm() {
$response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -99,7 +99,7 @@ class FormsTest extends \MailPoetTest {
expect($response->data['shortcode'])->notEmpty();
}
function testItCanSaveFormEditor() {
public function testItCanSaveFormEditor() {
$response = $this->endpoint->create();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -112,7 +112,7 @@ class FormsTest extends \MailPoetTest {
expect($response->data['name'])->equals('Updated form');
}
function testItCanRestoreAForm() {
public function testItCanRestoreAForm() {
$this->form_1->trash();
$trashed_form = Form::findOne($this->form_1->id);
@ -127,7 +127,7 @@ class FormsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanTrashAForm() {
public function testItCanTrashAForm() {
$response = $this->endpoint->trash(['id' => $this->form_2->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -137,14 +137,14 @@ class FormsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanDeleteAForm() {
public function testItCanDeleteAForm() {
$response = $this->endpoint->delete(['id' => $this->form_3->id]);
expect($response->data)->isEmpty();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->meta['count'])->equals(1);
}
function testItCanDuplicateAForm() {
public function testItCanDuplicateAForm() {
$response = $this->endpoint->duplicate(['id' => $this->form_1->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -153,7 +153,7 @@ class FormsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanBulkDeleteForms() {
public function testItCanBulkDeleteForms() {
$response = $this->endpoint->bulkAction([
'action' => 'trash',
'listing' => ['group' => 'all'],
@ -176,7 +176,7 @@ class FormsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(0);
}
function _after() {
public function _after() {
Form::deleteMany();
Segment::deleteMany();
}

10
tests/integration/API/JSON/v1/ImportExportTest.php
View File

@ -13,13 +13,13 @@ class ImportExportTest extends \MailPoetTest {
/** @var ImportExport */
private $endpoint;
function _before() {
public function _before() {
parent::_before();
$this->endpoint = ContainerWrapper::getInstance()->get(ImportExport::class);
ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->deleteMany();
}
function testItSchedulesTaskWhenNoneExistss() {
public function testItSchedulesTaskWhenNoneExistss() {
$response = $this->endpoint->setupWooCommerceInitialImport();
expect($response->status)->equals(200);
$task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne();
@ -30,7 +30,7 @@ class ImportExportTest extends \MailPoetTest {
expect($scheduled_at->timestamp)->lessOrEquals($now + 1);
}
function testItReschedulesScheduledTaskToNow() {
public function testItReschedulesScheduledTaskToNow() {
$original_schedule = Carbon::createFromTimestamp(time() + 3000);
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_SCHEDULED, $original_schedule);
$this->endpoint->setupWooCommerceInitialImport();
@ -44,7 +44,7 @@ class ImportExportTest extends \MailPoetTest {
expect($task_count)->equals(1);
}
function testItDoesNothingForRunningTask() {
public function testItDoesNothingForRunningTask() {
$this->createTask(WooCommerceSync::TASK_TYPE, null);
$this->endpoint->setupWooCommerceInitialImport();
$task = ScheduledTask::where('type', WooCommerceSync::TASK_TYPE)->findOne();
@ -53,7 +53,7 @@ class ImportExportTest extends \MailPoetTest {
expect($task_count)->equals(1);
}
function testItIgnoresCompletedAndPausedTasks() {
public function testItIgnoresCompletedAndPausedTasks() {
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_PAUSED);
$this->createTask(WooCommerceSync::TASK_TYPE, ScheduledTask::STATUS_COMPLETED);
$this->endpoint->setupWooCommerceInitialImport();

4
tests/integration/API/JSON/v1/MailerTest.php
View File

@ -12,7 +12,7 @@ use MailPoet\Services\Bridge;
use MailPoet\Settings\SettingsController;
class MailerTest extends \MailPoetTest {
function testItResumesSending() {
public function testItResumesSending() {
// create mailer log with a "paused" status
$mailer_log = ['status' => MailerLog::STATUS_PAUSED];
MailerLog::updateMailerLog($mailer_log);
@ -29,7 +29,7 @@ class MailerTest extends \MailPoetTest {
expect($mailer_log['status'])->null();
}
function testItRunsAuhtorizedEmailsCheckIfErrorIsPresent() {
public function testItRunsAuhtorizedEmailsCheckIfErrorIsPresent() {
$settings = SettingsController::getInstance();
$settings->set(AuthorizedEmailsController::AUTHORIZED_EMAIL_ADDRESSES_ERROR_SETTING, ['invalid_sender_address' => 'a@b.c']);
$authorized_emails_controller = $this->makeEmpty(AuthorizedEmailsController::class, ['checkAuthorizedEmailAddresses' => Expected::once()]);

16
tests/integration/API/JSON/v1/NewsletterTemplatesTest.php
View File

@ -7,7 +7,7 @@ use MailPoet\API\JSON\v1\NewsletterTemplates;
use MailPoet\Models\NewsletterTemplate;
class NewsletterTemplatesTest extends \MailPoetTest {
function _before() {
public function _before() {
parent::_before();
NewsletterTemplate::deleteMany();
NewsletterTemplate::createOrUpdate([
@ -22,7 +22,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
]);
}
function testItCanGetANewsletterTemplate() {
public function testItCanGetANewsletterTemplate() {
$template = NewsletterTemplate::where('name', 'Template #1')->findOne();
$router = new NewsletterTemplates();
@ -43,7 +43,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
);
}
function testItCanGetAllNewsletterTemplates() {
public function testItCanGetAllNewsletterTemplates() {
$templates = NewsletterTemplate::count();
$router = new NewsletterTemplates();
@ -52,7 +52,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
expect($response->data)->count($templates);
}
function testItCanSaveANewTemplate() {
public function testItCanSaveANewTemplate() {
$template_data = [
'name' => 'Template #3',
'body' => '{"key3": "value3"}',
@ -66,7 +66,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
);
}
function testItCanSaveANewTemplateAssociatedWithANewsletter() {
public function testItCanSaveANewTemplateAssociatedWithANewsletter() {
$template_data = [
'newsletter_id' => 2,
'name' => 'Template #3',
@ -81,7 +81,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
);
}
function testItCanUpdateTemplateAssociatedWithANewsletter() {
public function testItCanUpdateTemplateAssociatedWithANewsletter() {
$template_data = [
'newsletter_id' => '1',
'name' => 'Template #2',
@ -111,7 +111,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
expect($normalize($template))->equals($template_data);
}
function testItCanDeleteANewsletterTemplate() {
public function testItCanDeleteANewsletterTemplate() {
$template = NewsletterTemplate::where('name', 'Template #2')->findOne();
expect($template->deleted_at)->null();
@ -128,7 +128,7 @@ class NewsletterTemplatesTest extends \MailPoetTest {
expect($deleted_template)->false();
}
function _after() {
public function _after() {
NewsletterTemplate::deleteMany();
}
}

66
tests/integration/API/JSON/v1/NewslettersTest.php
View File

@ -50,7 +50,7 @@ class NewslettersTest extends \MailPoetTest {
/** @var CronHelper */
private $cron_helper;
function _before() {
public function _before() {
parent::_before();
$this->subscription_url_factory = SubscriptionUrlFactory::getInstance();
$this->cron_helper = ContainerWrapper::getInstance()->get(CronHelper::class);
@ -81,7 +81,7 @@ class NewslettersTest extends \MailPoetTest {
]);
}
function testItKeepsUnsentNewslettersAtTheTopWhenSortingBySentAtDate() {
public function testItKeepsUnsentNewslettersAtTheTopWhenSortingBySentAtDate() {
$sent_newsletters = [];
for ($i = 1; $i <= 3; $i++) {
$sent_newsletters[$i] = Newsletter::create();
@ -124,7 +124,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->data[3]['id'])->equals($sent_newsletters[1]->id);
}
function testItCanGetANewsletter() {
public function testItCanGetANewsletter() {
$response = $this->endpoint->get(); // missing id
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
expect($response->errors[0]['message'])
@ -168,7 +168,7 @@ class NewslettersTest extends \MailPoetTest {
expect(WPHooksHelper::getFilterApplied($hook_name)[0])->internalType('array');
}
function testItCanSaveANewNewsletter() {
public function testItCanSaveANewNewsletter() {
$newsletter_option_field = NewsletterOptionField::create();
$newsletter_option_field->name = 'some_option';
$newsletter_option_field->newsletter_type = Newsletter::TYPE_STANDARD;
@ -237,7 +237,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please specify a type.');
}
function testItCanSaveAnExistingNewsletter() {
public function testItCanSaveAnExistingNewsletter() {
$newsletter_data = [
'id' => $this->newsletter->id,
'subject' => 'My Updated Newsletter',
@ -250,7 +250,7 @@ class NewslettersTest extends \MailPoetTest {
expect($updated_newsletter->subject)->equals('My Updated Newsletter');
}
function testItDoesNotRerenderPostNotificationsUponUpdate() {
public function testItDoesNotRerenderPostNotificationsUponUpdate() {
$sending_queue = SendingTask::create();
$sending_queue->newsletter_id = $this->post_notification->id;
$sending_queue->status = SendingQueue::STATUS_SCHEDULED;
@ -275,7 +275,7 @@ class NewslettersTest extends \MailPoetTest {
expect($updated_queue['newsletter_rendered_subject'])->null();
}
function testItCanRerenderQueueUponSave() {
public function testItCanRerenderQueueUponSave() {
$sending_queue = SendingTask::create();
$sending_queue->newsletter_id = $this->newsletter->id;
$sending_queue->status = SendingQueue::STATUS_SCHEDULED;
@ -301,7 +301,7 @@ class NewslettersTest extends \MailPoetTest {
expect($updated_queue['newsletter_rendered_subject'])->equals('My Updated Newsletter');
}
function testItCanUpdatePostNotificationScheduleUponSave() {
public function testItCanUpdatePostNotificationScheduleUponSave() {
$newsletter_options = [
'intervalType',
'timeOfDay',
@ -345,7 +345,7 @@ class NewslettersTest extends \MailPoetTest {
expect($saved_newsletter->schedule)->equals('* * * * *');
}
function testItCanReschedulePreviouslyScheduledSendingQueueJobs() {
public function testItCanReschedulePreviouslyScheduledSendingQueueJobs() {
// create newsletter options
$newsletter_options = [
'intervalType',
@ -399,7 +399,7 @@ class NewslettersTest extends \MailPoetTest {
expect($sending_queue_2->scheduled_at)->null();
}
function testItCanModifySegmentsOfExistingNewsletter() {
public function testItCanModifySegmentsOfExistingNewsletter() {
$segment_1 = Segment::createOrUpdate(['name' => 'Segment 1']);
$fake_segment_id = 1;
@ -423,7 +423,7 @@ class NewslettersTest extends \MailPoetTest {
expect($updated_newsletter->segments[0]['name'])->equals('Segment 1');
}
function testItReturnsErrorIfSubscribersLimitReached() {
public function testItReturnsErrorIfSubscribersLimitReached() {
$endpoint = new Newsletters(
ContainerWrapper::getInstance()->get(BulkActionController::class),
ContainerWrapper::getInstance()->get(Handler::class),
@ -447,7 +447,7 @@ class NewslettersTest extends \MailPoetTest {
expect($res->status)->equals(APIResponse::STATUS_FORBIDDEN);
}
function testItCanSetANewsletterStatus() {
public function testItCanSetANewsletterStatus() {
// set status to sending
$response = $this->endpoint->setStatus
([
@ -489,7 +489,7 @@ class NewslettersTest extends \MailPoetTest {
->equals('This email does not exist.');
}
function testItReschedulesPastDuePostNotificationsWhenStatusIsSetBackToActive() {
public function testItReschedulesPastDuePostNotificationsWhenStatusIsSetBackToActive() {
$newsletter_option_field = NewsletterOptionField::create();
$newsletter_option_field->name = 'schedule';
$newsletter_option_field->newsletter_type = Newsletter::TYPE_NOTIFICATION;
@ -533,7 +533,7 @@ class NewslettersTest extends \MailPoetTest {
expect($tasks[2]->scheduled_at)->equals(Scheduler::getPreviousRunDate($schedule));
}
function testItSchedulesPostNotificationsWhenStatusIsSetBackToActive() {
public function testItSchedulesPostNotificationsWhenStatusIsSetBackToActive() {
$newsletter_option_field = NewsletterOptionField::create();
$newsletter_option_field->name = 'schedule';
$newsletter_option_field->newsletter_type = Newsletter::TYPE_NOTIFICATION;
@ -557,7 +557,7 @@ class NewslettersTest extends \MailPoetTest {
expect($tasks)->notEmpty();
}
function testItCanRestoreANewsletter() {
public function testItCanRestoreANewsletter() {
$this->newsletter->trash();
$trashed_newsletter = Newsletter::findOne($this->newsletter->id);
@ -573,7 +573,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanTrashANewsletter() {
public function testItCanTrashANewsletter() {
$response = $this->endpoint->trash(['id' => $this->newsletter->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -584,14 +584,14 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanDeleteANewsletter() {
public function testItCanDeleteANewsletter() {
$response = $this->endpoint->delete(['id' => $this->newsletter->id]);
expect($response->data)->isEmpty();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->meta['count'])->equals(1);
}
function testItCanDuplicateANewsletter() {
public function testItCanDuplicateANewsletter() {
$wp = Stub::make(new WPFunctions, [
'doAction' => asCallable([WPHooksHelper::class, 'doAction']),
]);
@ -635,7 +635,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanCreateANewsletter() {
public function testItCanCreateANewsletter() {
$data = [
'subject' => 'My New Newsletter',
'type' => Newsletter::TYPE_STANDARD,
@ -653,7 +653,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please specify a type.');
}
function testItCanGetListingData() {
public function testItCanGetListingData() {
$segment_1 = Segment::createOrUpdate(['name' => 'Segment 1']);
$segment_2 = Segment::createOrUpdate(['name' => 'Segment 2']);
@ -709,7 +709,7 @@ class NewslettersTest extends \MailPoetTest {
->equals($segment_2->id);
}
function testItCanFilterListing() {
public function testItCanFilterListing() {
// create 2 segments
$segment_1 = Segment::createOrUpdate(['name' => 'Segment 1']);
$segment_2 = Segment::createOrUpdate(['name' => 'Segment 2']);
@ -773,7 +773,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(2);
}
function testItCanLimitListing() {
public function testItCanLimitListing() {
// get 1st page (limit items per page to 1)
$response = $this->endpoint->listing(
[
@ -808,7 +808,7 @@ class NewslettersTest extends \MailPoetTest {
);
}
function testItCanBulkDeleteSelectionOfNewsletters() {
public function testItCanBulkDeleteSelectionOfNewsletters() {
$selection_ids = [
$this->newsletter->id,
$this->post_notification->id,
@ -827,7 +827,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(count($selection_ids));
}
function testItCanBulkDeleteNewsletters() {
public function testItCanBulkDeleteNewsletters() {
$response = $this->endpoint->bulkAction(
[
'action' => 'trash',
@ -856,7 +856,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(0);
}
function testItCanSendAPreview() {
public function testItCanSendAPreview() {
$subscriber = 'test@subscriber.com';
@ -894,7 +894,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_OK);
}
function testItReturnsMailerErrorWhenSendingFailed() {
public function testItReturnsMailerErrorWhenSendingFailed() {
$subscriber = 'test@subscriber.com';
$endpoint = Stub::copy($this->endpoint, [
@ -927,7 +927,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('The email could not be sent: failed');
}
function testItReturnsBrowserPreviewUrlWithoutProtocol() {
public function testItReturnsBrowserPreviewUrlWithoutProtocol() {
$data = [
'id' => $this->newsletter->id,
'body' => 'fake body',
@ -967,7 +967,7 @@ class NewslettersTest extends \MailPoetTest {
expect($response->meta['preview_url'])->regExp('!^\/\/!');
}
function testItGeneratesPreviewLinksWithNewsletterHashAndNoSubscriberData() {
public function testItGeneratesPreviewLinksWithNewsletterHashAndNoSubscriberData() {
$response = $this->endpoint->listing();
$preview_link = $response->data[0]['preview_url'];
parse_str(parse_url($preview_link, PHP_URL_QUERY), $preview_link_data);
@ -978,7 +978,7 @@ class NewslettersTest extends \MailPoetTest {
expect((boolean)$preview_link_data['preview'])->true();
}
function testItDeletesSendingQueueAndSetsNewsletterStatusToDraftWhenItIsUnscheduled() {
public function testItDeletesSendingQueueAndSetsNewsletterStatusToDraftWhenItIsUnscheduled() {
$newsletter = $this->newsletter;
$newsletter->status = Newsletter::STATUS_SCHEDULED;
$newsletter->save();
@ -1009,7 +1009,7 @@ class NewslettersTest extends \MailPoetTest {
expect($sending_queue)->false();
}
function testItSavesDefaultSenderIfNeeded() {
public function testItSavesDefaultSenderIfNeeded() {
$settings = $this->di_container->get(SettingsController::class);
$settings->set('sender', null);
@ -1025,7 +1025,7 @@ class NewslettersTest extends \MailPoetTest {
expect($settings->get('sender.address'))->same('test@example.com');
}
function testItDoesntSaveDefaultSenderWhenEmptyValues() {
public function testItDoesntSaveDefaultSenderWhenEmptyValues() {
$settings = $this->di_container->get(SettingsController::class);
$settings->set('sender', null);
@ -1040,7 +1040,7 @@ class NewslettersTest extends \MailPoetTest {
expect($settings->get('sender'))->null();
}
function testItDoesntOverrideDefaultSender() {
public function testItDoesntOverrideDefaultSender() {
$settings = $this->di_container->get(SettingsController::class);
$settings->set('sender', [
'name' => 'Test sender',
@ -1059,7 +1059,7 @@ class NewslettersTest extends \MailPoetTest {
expect($settings->get('sender.address'))->same('test@example.com');
}
function _after() {
public function _after() {
ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
ORM::raw_execute('TRUNCATE ' . NewsletterSegment::$_table);
ORM::raw_execute('TRUNCATE ' . NewsletterOptionField::$_table);

22
tests/integration/API/JSON/v1/SegmentsTest.php
View File

@ -14,7 +14,7 @@ class SegmentsTest extends \MailPoetTest {
/** @var Segments */
private $endpoint;
function _before() {
public function _before() {
parent::_before();
$this->endpoint = ContainerWrapper::getInstance()->get(Segments::class);
$this->segment_1 = Segment::createOrUpdate(['name' => 'Segment 1', 'type' => 'default']);
@ -22,7 +22,7 @@ class SegmentsTest extends \MailPoetTest {
$this->segment_3 = Segment::createOrUpdate(['name' => 'Segment 3', 'type' => 'default']);
}
function testItCanGetASegment() {
public function testItCanGetASegment() {
$response = $this->endpoint->get(/* missing id */);
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
expect($response->errors[0]['message'])->equals('This list does not exist.');
@ -38,7 +38,7 @@ class SegmentsTest extends \MailPoetTest {
);
}
function testItCanGetListingData() {
public function testItCanGetListingData() {
$response = $this->endpoint->listing();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -53,7 +53,7 @@ class SegmentsTest extends \MailPoetTest {
expect($response->data[2]['name'])->equals($this->segment_3->name);
}
function testItCanSaveASegment() {
public function testItCanSaveASegment() {
$segment_data = [
'name' => 'New Segment',
];
@ -69,7 +69,7 @@ class SegmentsTest extends \MailPoetTest {
);
}
function testItCannotSaveDuplicate() {
public function testItCannotSaveDuplicate() {
$duplicate_entry = [
'name' => 'Segment 1',
];
@ -81,7 +81,7 @@ class SegmentsTest extends \MailPoetTest {
);
}
function testItCanRestoreASegment() {
public function testItCanRestoreASegment() {
$this->segment_1->trash();
$trashed_segment = Segment::findOne($this->segment_1->id);
@ -96,7 +96,7 @@ class SegmentsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanTrashASegment() {
public function testItCanTrashASegment() {
$response = $this->endpoint->trash(['id' => $this->segment_2->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -106,14 +106,14 @@ class SegmentsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanDeleteASegment() {
public function testItCanDeleteASegment() {
$response = $this->endpoint->delete(['id' => $this->segment_3->id]);
expect($response->data)->isEmpty();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->meta['count'])->equals(1);
}
function testItCanDuplicateASegment() {
public function testItCanDuplicateASegment() {
$response = $this->endpoint->duplicate(['id' => $this->segment_1->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -122,7 +122,7 @@ class SegmentsTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanBulkDeleteSegments() {
public function testItCanBulkDeleteSegments() {
$subscriber_segment = SubscriberSegment::createOrUpdate([
'subscriber_id' => 1,
'segment_id' => $this->segment_1->id,
@ -154,7 +154,7 @@ class SegmentsTest extends \MailPoetTest {
expect(SubscriberSegment::findOne($subscriber_segment->id))->equals(false);
}
function _after() {
public function _after() {
Segment::deleteMany();
}
}

10
tests/integration/API/JSON/v1/SendingQueueTest.php
View File

@ -20,7 +20,7 @@ use MailPoet\Util\License\Features\Subscribers as SubscribersFeature;
use MailPoetVendor\Idiorm\ORM;
class SendingQueueTest extends \MailPoetTest {
function _before() {
public function _before() {
parent::_before();
$this->newsletter = Newsletter::createOrUpdate(
[
@ -36,7 +36,7 @@ class SendingQueueTest extends \MailPoetTest {
]);
}
function testItCreatesNewScheduledSendingQueueTask() {
public function testItCreatesNewScheduledSendingQueueTask() {
$newsletter = $this->newsletter;
$newsletter->status = Newsletter::STATUS_SCHEDULED;
$newsletter->save();
@ -58,7 +58,7 @@ class SendingQueueTest extends \MailPoetTest {
expect($scheduled_task->type)->equals(Sending::TASK_TYPE);
}
function testItReturnsErrorIfSubscribersLimitReached() {
public function testItReturnsErrorIfSubscribersLimitReached() {
$sending_queue = new SendingQueueAPI(Stub::make(SubscribersFeature::class, [
'check' => true,
]));
@ -68,7 +68,7 @@ class SendingQueueTest extends \MailPoetTest {
expect($res->status)->equals(APIResponse::STATUS_FORBIDDEN);
}
function testItReschedulesScheduledSendingQueueTask() {
public function testItReschedulesScheduledSendingQueueTask() {
$newsletter = $this->newsletter;
$newsletter->status = Newsletter::STATUS_SCHEDULED;
$newsletter->save();
@ -130,7 +130,7 @@ class SendingQueueTest extends \MailPoetTest {
}
}
function _after() {
public function _after() {
ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
ORM::raw_execute('TRUNCATE ' . NewsletterOption::$_table);
ORM::raw_execute('TRUNCATE ' . NewsletterOptionField::$_table);

14
tests/integration/API/JSON/v1/SendingTaskSubscribersTest.php
View File

@ -15,7 +15,7 @@ use MailPoetVendor\Idiorm\ORM;
class SendingTaskSubscribersTest extends \MailPoetTest {
function _before() {
public function _before() {
parent::_before();
$this->endpoint = ContainerWrapper::getInstance()->get(SendingTaskSubscribers::class);
$this->newsletter_id = Newsletter::createOrUpdate([
@ -66,7 +66,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
]);
}
function testListingReturnsErrorIfMissingNewsletter() {
public function testListingReturnsErrorIfMissingNewsletter() {
$res = $this->endpoint->listing([
'sort_by' => 'created_at',
'params' => ['id' => $this->newsletter_id + 1],
@ -76,7 +76,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
->equals('This email has not been sent yet.');
}
function testListingReturnsErrorIfNewsletterNotBeingSent() {
public function testListingReturnsErrorIfNewsletterNotBeingSent() {
$newsletter = Newsletter::createOrUpdate([
'type' => Newsletter::TYPE_STANDARD,
'subject' => 'Draft',
@ -91,7 +91,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
->equals('This email has not been sent yet.');
}
function testItReturnsListing() {
public function testItReturnsListing() {
$sent_subscriber_status = [
'error' => '',
'failed' => 0,
@ -165,7 +165,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
]);
}
function testResendReturnsErrorIfWrongData() {
public function testResendReturnsErrorIfWrongData() {
$res = $this->endpoint->resend([
'taskId' => $this->task_id + 1,
'subscriberId' => $this->sent_subscriber->id,
@ -183,7 +183,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
->equals('Failed sending task not found!');
}
function testItCanResend() {
public function testItCanResend() {
$res = $this->endpoint->resend([
'taskId' => $this->task_id,
'subscriberId' => $this->failed_subscriber->id,
@ -204,7 +204,7 @@ class SendingTaskSubscribersTest extends \MailPoetTest {
expect($newsletter->status)->equals(Newsletter::STATUS_SENDING);
}
function _after() {
public function _after() {
ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
ORM::raw_execute('TRUNCATE ' . Subscriber::$_table);
ORM::raw_execute('TRUNCATE ' . SendingQueue::$_table);

48
tests/integration/API/JSON/v1/ServicesTest.php
View File

@ -16,14 +16,14 @@ class ServicesTest extends \MailPoetTest {
/** @var SettingsController */
private $settings;
function _before() {
public function _before() {
parent::_before();
$this->services_endpoint = $this->di_container->get(Services::class);
$this->data = ['key' => '1234567890abcdef'];
$this->settings = SettingsController::getInstance();
}
function testItRespondsWithErrorIfSPFCheckFails() {
public function testItRespondsWithErrorIfSPFCheckFails() {
$email = 'spf_test@example.com';
$this->settings->set('sender.address', $email);
@ -39,7 +39,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->meta['sender_address'])->equals($email);
}
function testItRespondsWithSuccessIfSPFCheckPasses() {
public function testItRespondsWithSuccessIfSPFCheckPasses() {
$spf_check = $this->make(
SPFCheck::class,
['checkSPFRecord' => true],
@ -51,13 +51,13 @@ class ServicesTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_OK);
}
function testItRespondsWithErrorIfNoMSSKeyIsGiven() {
public function testItRespondsWithErrorIfNoMSSKeyIsGiven() {
$response = $this->di_container->get(Services::class)->checkMSSKey(['key' => '']);
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
expect($response->errors[0]['message'])->equals('Please specify a key.');
}
function testItRespondsWithSuccessIfMSSKeyIsValid() {
public function testItRespondsWithSuccessIfMSSKeyIsValid() {
$bridge = $this->make(
new Bridge(),
[
@ -72,7 +72,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_OK);
}
function testItRespondsWithErrorIfMSSKeyIsInvalid() {
public function testItRespondsWithErrorIfMSSKeyIsInvalid() {
$bridge = $this->make(
new Bridge(),
[
@ -86,7 +86,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
function testItRespondsWithErrorIfMSSKeyIsExpiring() {
public function testItRespondsWithErrorIfMSSKeyIsExpiring() {
$date = new \DateTime;
$bridge = $this->make(
new Bridge(),
@ -107,7 +107,7 @@ class ServicesTest extends \MailPoetTest {
->contains($date->format($services_endpoint->date_time->getDateFormat()));
}
function testItRespondsWithErrorIfServiceIsUnavailableDuringMSSCheck() {
public function testItRespondsWithErrorIfServiceIsUnavailableDuringMSSCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -127,7 +127,7 @@ class ServicesTest extends \MailPoetTest {
);
}
function testItRespondsWithErrorIfServiceDidNotReturnAResponseCodeDuringMSSCheck() {
public function testItRespondsWithErrorIfServiceDidNotReturnAResponseCodeDuringMSSCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -147,7 +147,7 @@ class ServicesTest extends \MailPoetTest {
);
}
function testItPrintsErrorCodeIfServiceReturnedAnUnexpectedResponseCodeDuringMSSCheck() {
public function testItPrintsErrorCodeIfServiceReturnedAnUnexpectedResponseCodeDuringMSSCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -163,7 +163,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->errors[0]['message'])->contains('404');
}
function testItRespondsWithErrorIfMSSCheckThrowsAnException() {
public function testItRespondsWithErrorIfMSSCheckThrowsAnException() {
$bridge = $this->make(
new Bridge(),
[
@ -181,13 +181,13 @@ class ServicesTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('test');
}
function testItRespondsWithErrorIfNoPremiumKeyIsGiven() {
public function testItRespondsWithErrorIfNoPremiumKeyIsGiven() {
$response = $response = $this->di_container->get(Services::class)->checkPremiumKey(['key' => '']);
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
expect($response->errors[0]['message'])->equals('Please specify a key.');
}
function testItRespondsWithSuccessIfPremiumKeyIsValid() {
public function testItRespondsWithSuccessIfPremiumKeyIsValid() {
$bridge = $this->make(
new Bridge(),
[
@ -205,7 +205,7 @@ class ServicesTest extends \MailPoetTest {
}
}
function testItRespondsWithErrorIfPremiumKeyIsInvalid() {
public function testItRespondsWithErrorIfPremiumKeyIsInvalid() {
$bridge = $this->make(
new Bridge(),
[
@ -220,7 +220,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
function testItRespondsWithErrorIfPremiumKeyIsUsed() {
public function testItRespondsWithErrorIfPremiumKeyIsUsed() {
$bridge = $this->make(
new Bridge(),
[
@ -235,7 +235,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
function testItRespondsWithErrorIfPremiumKeyIsExpiring() {
public function testItRespondsWithErrorIfPremiumKeyIsExpiring() {
$date = new \DateTime;
$bridge = $this->make(
new Bridge(),
@ -256,7 +256,7 @@ class ServicesTest extends \MailPoetTest {
->contains($date->format($services_endpoint->date_time->getDateFormat()));
}
function testItRespondsWithErrorIfServiceIsUnavailableDuringPremiumCheck() {
public function testItRespondsWithErrorIfServiceIsUnavailableDuringPremiumCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -276,7 +276,7 @@ class ServicesTest extends \MailPoetTest {
);
}
function testItRespondsWithErrorIfServiceDidNotReturnAResponseCodeDuringPremiumCheck() {
public function testItRespondsWithErrorIfServiceDidNotReturnAResponseCodeDuringPremiumCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -296,7 +296,7 @@ class ServicesTest extends \MailPoetTest {
);
}
function testItPrintsErrorCodeIfServiceReturnedAnUnexpectedResponseCodeDuringPremiumCheck() {
public function testItPrintsErrorCodeIfServiceReturnedAnUnexpectedResponseCodeDuringPremiumCheck() {
$bridge = $this->make(
new Bridge(),
[
@ -312,7 +312,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->errors[0]['message'])->contains('404');
}
function testItRespondsWithErrorIfPremiumCheckThrowsAnException() {
public function testItRespondsWithErrorIfPremiumCheckThrowsAnException() {
$bridge = $this->make(
new Bridge(),
[
@ -330,7 +330,7 @@ class ServicesTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('test');
}
function testItRespondsWithPublicIdForMSS() {
public function testItRespondsWithPublicIdForMSS() {
$fake_public_id = 'a-fake-public_id';
$this->settings->delete('public_id');
$this->settings->delete('new_public_id');
@ -354,7 +354,7 @@ class ServicesTest extends \MailPoetTest {
expect($this->settings->get('new_public_id'))->equals('true');
}
function testItRespondsWithoutPublicIdForMSS() {
public function testItRespondsWithoutPublicIdForMSS() {
$this->settings->delete('public_id');
$this->settings->delete('new_public_id');
@ -374,7 +374,7 @@ class ServicesTest extends \MailPoetTest {
expect($this->settings->get('new_public_id', null))->null();
}
function testItRespondsWithPublicIdForPremium() {
public function testItRespondsWithPublicIdForPremium() {
$fake_public_id = 'another-fake-public_id';
$this->settings->delete('public_id');
$this->settings->delete('new_public_id');
@ -398,7 +398,7 @@ class ServicesTest extends \MailPoetTest {
expect($this->settings->get('new_public_id'))->equals('true');
}
function testItRespondsWithoutPublicIdForPremium() {
public function testItRespondsWithoutPublicIdForPremium() {
$this->settings->delete('public_id');
$this->settings->delete('new_public_id');

10
tests/integration/API/JSON/v1/SettingsTest.php
View File

@ -24,7 +24,7 @@ class SettingsTest extends \MailPoetTest {
/** @var SettingsController */
private $settings;
function _before() {
public function _before() {
parent::_before();
ORM::raw_execute('TRUNCATE ' . ScheduledTask::$_table);
$this->settings = SettingsController::getInstance();
@ -37,7 +37,7 @@ class SettingsTest extends \MailPoetTest {
);
}
function testItCanGetSettings() {
public function testItCanGetSettings() {
$response = $this->endpoint->get();
expect($response->status)->equals(APIResponse::STATUS_OK);
@ -51,7 +51,7 @@ class SettingsTest extends \MailPoetTest {
expect($response->data)->equals($this->settings->getAllDefaults());
}
function testItCanSetSettings() {
public function testItCanSetSettings() {
$new_settings = [
'some' => [
'setting' => [
@ -82,7 +82,7 @@ class SettingsTest extends \MailPoetTest {
expect($response->data['some']['new_setting'])->true();
}
function testItSchedulesInactiveSubscribersCheckIfIntervalSettingChanges() {
public function testItSchedulesInactiveSubscribersCheckIfIntervalSettingChanges() {
$this->settings->set('deactivate_subscriber_after_inactive_days', 30);
$settings = ['deactivate_subscriber_after_inactive_days' => 30];
$this->endpoint->set($settings);
@ -99,7 +99,7 @@ class SettingsTest extends \MailPoetTest {
expect($task->scheduled_at)->lessThan(Carbon::now());
}
function _after() {
public function _after() {
$this->di_container->get(SettingsRepository::class)->truncate();
}
}

6
tests/integration/API/JSON/v1/SetupTest.php
View File

@ -16,13 +16,13 @@ use MailPoet\Subscription\Captcha;
use MailPoet\WP\Functions as WPFunctions;
class SetupTest extends \MailPoetTest {
function _before() {
public function _before() {
parent::_before();
$settings = SettingsController::getInstance();
$settings->set('signup_confirmation.enabled', false);
}
function testItCanReinstall() {
public function testItCanReinstall() {
$wp = Stub::make(new WPFunctions, [
'doAction' => asCallable([WPHooksHelper::class, 'doAction']),
]);
@ -54,7 +54,7 @@ class SetupTest extends \MailPoetTest {
expect(WPHooksHelper::isActionDone($hook_name))->true();
}
function _after() {
public function _after() {
$this->di_container->get(SettingsRepository::class)->truncate();
}
}

70
tests/integration/API/JSON/v1/SubscribersTest.php
View File

@ -46,7 +46,7 @@ class SubscribersTest extends \MailPoetTest {
/** @var CaptchaSession */
private $captcha_session;
function _before() {
public function _before() {
parent::_before();
$this->cleanup();
$container = ContainerWrapper::getInstance();
@ -111,7 +111,7 @@ class SubscribersTest extends \MailPoetTest {
]);
}
function testItCanGetASubscriber() {
public function testItCanGetASubscriber() {
$response = $this->endpoint->get(['id' => 'not_an_id']);
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
expect($response->errors[0]['message'])->equals(
@ -134,7 +134,7 @@ class SubscribersTest extends \MailPoetTest {
);
}
function testItCanSaveANewSubscriber() {
public function testItCanSaveANewSubscriber() {
$valid_data = [
'email' => 'raul.doe@mailpoet.com',
'first_name' => 'Raul',
@ -175,7 +175,7 @@ class SubscribersTest extends \MailPoetTest {
expect($subscriber->source)->equals('administrator');
}
function testItCanSaveAnExistingSubscriber() {
public function testItCanSaveAnExistingSubscriber() {
$subscriber_data = $this->subscriber_2->asArray();
unset($subscriber_data['created_at']);
$subscriber_data['segments'] = [$this->segment_1->id];
@ -190,7 +190,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->data['source'])->equals('api');
}
function testItCanRemoveListsFromAnExistingSubscriber() {
public function testItCanRemoveListsFromAnExistingSubscriber() {
$subscriber_data = $this->subscriber_2->asArray();
unset($subscriber_data['created_at']);
unset($subscriber_data['segments']);
@ -203,7 +203,7 @@ class SubscribersTest extends \MailPoetTest {
expect($this->subscriber_2->segments()->findArray())->count(0);
}
function testItCanRestoreASubscriber() {
public function testItCanRestoreASubscriber() {
$this->subscriber_1->trash();
$trashed_subscriber = Subscriber::findOne($this->subscriber_1->id);
@ -218,7 +218,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanTrashASubscriber() {
public function testItCanTrashASubscriber() {
$response = $this->endpoint->trash(['id' => $this->subscriber_2->id]);
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals(
@ -228,14 +228,14 @@ class SubscribersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(1);
}
function testItCanDeleteASubscriber() {
public function testItCanDeleteASubscriber() {
$response = $this->endpoint->delete(['id' => $this->subscriber_1->id]);
expect($response->data)->isEmpty();
expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->meta['count'])->equals(1);
}
function testItCanFilterListing() {
public function testItCanFilterListing() {
// filter by non existing segment
$response = $this->endpoint->listing([
'filter' => [
@ -267,7 +267,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->data[0]['email'])->equals($this->subscriber_2->email);
}
function testItCanAddSegmentsUsingHooks() {
public function testItCanAddSegmentsUsingHooks() {
$add_segment = function() {
return 'segment';
};
@ -280,7 +280,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->meta['filters']['segment'])->equals('segment');
}
function testItCanSearchListing() {
public function testItCanSearchListing() {
$new_subscriber = Subscriber::createOrUpdate([
'email' => 'search.me@find.me',
'first_name' => 'Billy Bob',
@ -316,7 +316,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->data[0]['email'])->equals($new_subscriber->email);
}
function testItCanGroupListing() {
public function testItCanGroupListing() {
$subscribed_group = $this->endpoint->listing([
'group' => Subscriber::STATUS_SUBSCRIBED,
]);
@ -355,7 +355,7 @@ class SubscribersTest extends \MailPoetTest {
);
}
function testItCorrectSubscriptionStatus() {
public function testItCorrectSubscriptionStatus() {
$segment = Segment::createOrUpdate(['name' => 'Segment185245']);
$subscriber = Subscriber::createOrUpdate([
'email' => 'third@example.com',
@ -379,7 +379,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->data[0]['status'])->equals(Subscriber::STATUS_UNSUBSCRIBED);
}
function testItCanSortAndLimitListing() {
public function testItCanSortAndLimitListing() {
// get 1st page (limit items per page to 1)
$response = $this->endpoint->listing([
'limit' => 1,
@ -408,7 +408,7 @@ class SubscribersTest extends \MailPoetTest {
);
}
function testItCanBulkDeleteSelectionOfSubscribers() {
public function testItCanBulkDeleteSelectionOfSubscribers() {
$deletable_subscriber = Subscriber::createOrUpdate([
'email' => 'to.be.removed@mailpoet.com',
]);
@ -439,7 +439,7 @@ class SubscribersTest extends \MailPoetTest {
expect($is_deletable_subscriber_deleted)->true();
}
function testItCanBulkDeleteSubscribers() {
public function testItCanBulkDeleteSubscribers() {
$response = $this->endpoint->bulkAction([
'action' => 'trash',
'listing' => ['group' => 'all'],
@ -462,7 +462,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->meta['count'])->equals(0);
}
function testItCannotRunAnInvalidBulkAction() {
public function testItCannotRunAnInvalidBulkAction() {
$response = $this->endpoint->bulkAction([
'action' => 'invalidAction',
'listing' => [],
@ -471,7 +471,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->contains('has no method');
}
function testItFailsWithEmailFilled() {
public function testItFailsWithEmailFilled() {
$response = $this->endpoint->subscribe([
'form_id' => $this->form->id,
'email' => 'toto@mailpoet.com',
@ -482,7 +482,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please leave the first field empty.');
}
function testItCannotSubscribeWithoutFormID() {
public function testItCannotSubscribeWithoutFormID() {
$response = $this->endpoint->subscribe([
'form_field_ZW1haWw' => 'toto@mailpoet.com',
// no form ID specified
@ -492,7 +492,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please specify a valid form ID.');
}
function testItCannotSubscribeWithoutSegmentsIfTheyAreSelectedByUser() {
public function testItCannotSubscribeWithoutSegmentsIfTheyAreSelectedByUser() {
$response = $this->endpoint->subscribe([
$this->obfuscatedEmail => 'toto@mailpoet.com',
'form_id' => $this->form->id,
@ -503,7 +503,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please select a list.');
}
function testItCanSubscribe() {
public function testItCanSubscribe() {
$response = $this->endpoint->subscribe([
$this->obfuscatedEmail => 'toto@mailpoet.com',
'form_id' => $this->form->id,
@ -512,7 +512,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_OK);
}
function testItCannotSubscribeWithoutReCaptchaWhenEnabled() {
public function testItCannotSubscribeWithoutReCaptchaWhenEnabled() {
$this->settings->set('captcha', ['type' => Captcha::TYPE_RECAPTCHA]);
$response = $this->endpoint->subscribe([
$this->obfuscatedEmail => 'toto@mailpoet.com',
@ -524,7 +524,7 @@ class SubscribersTest extends \MailPoetTest {
$this->settings->set('captcha', []);
}
function testItCannotSubscribeWithoutBuiltInCaptchaWhenEnabled() {
public function testItCannotSubscribeWithoutBuiltInCaptchaWhenEnabled() {
$this->settings->set('captcha', ['type' => Captcha::TYPE_BUILTIN]);
$email = 'toto@mailpoet.com';
$subscriber = Subscriber::create();
@ -541,7 +541,7 @@ class SubscribersTest extends \MailPoetTest {
$this->settings->set('captcha', []);
}
function testItCanSubscribeWithBuiltInCaptchaWhenEnabled() {
public function testItCanSubscribeWithBuiltInCaptchaWhenEnabled() {
$this->settings->set('captcha', ['type' => Captcha::TYPE_BUILTIN]);
$email = 'toto@mailpoet.com';
$subscriber = Subscriber::create();
@ -563,7 +563,7 @@ class SubscribersTest extends \MailPoetTest {
$this->settings->set('captcha', []);
}
function testItCannotSubscribeWithoutMandatoryCustomField() {
public function testItCannotSubscribeWithoutMandatoryCustomField() {
$custom_field = CustomField::createOrUpdate([
'name' => 'custom field',
'type' => 'text',
@ -589,7 +589,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
}
function testItCanSubscribeWithoutSegmentsIfTheyAreSelectedByAdmin() {
public function testItCanSubscribeWithoutSegmentsIfTheyAreSelectedByAdmin() {
$form = $this->form->asArray();
$form['settings']['segments_selected_by'] = 'admin';
$this->form->settings = $form['settings'];
@ -609,7 +609,7 @@ class SubscribersTest extends \MailPoetTest {
expect($subscriber_segments[1]['id'])->equals($form['settings']['segments'][1]);
}
function testItCannotSubscribeIfFormHasNoSegmentsDefined() {
public function testItCannotSubscribeIfFormHasNoSegmentsDefined() {
$form = $this->form->asArray();
$form['settings']['segments_selected_by'] = 'admin';
unset($form['settings']['segments']);
@ -626,7 +626,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('Please select a list.');
}
function testItCannotMassSubscribe() {
public function testItCannotMassSubscribe() {
$_SERVER['REMOTE_ADDR'] = '127.0.0.1';
$this->endpoint->subscribe([
@ -645,7 +645,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('You need to wait 1 minutes before subscribing again.');
}
function testItCannotMassResubscribe() {
public function testItCannotMassResubscribe() {
$_SERVER['REMOTE_ADDR'] = '127.0.0.1';
$this->endpoint->subscribe([
@ -670,7 +670,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->errors[0]['message'])->equals('You need to wait 1 minutes before subscribing again.');
}
function testItSchedulesWelcomeEmailNotificationWhenSubscriberIsAdded() {
public function testItSchedulesWelcomeEmailNotificationWhenSubscriberIsAdded() {
$this->_createWelcomeNewsletter();
$subscriber_data = [
'email' => 'raul.doe@mailpoet.com',
@ -685,7 +685,7 @@ class SubscribersTest extends \MailPoetTest {
expect(SendingQueue::findMany())->count(1);
}
function testItSchedulesWelcomeEmailNotificationWhenExistedSubscriberIsUpdated() {
public function testItSchedulesWelcomeEmailNotificationWhenExistedSubscriberIsUpdated() {
$this->_createWelcomeNewsletter();
$subscriber_data = [
'email' => 'raul.doe@mailpoet.com',
@ -705,7 +705,7 @@ class SubscribersTest extends \MailPoetTest {
expect(SendingQueue::findMany())->count(1);
}
function testItDoesNotSchedulesWelcomeEmailNotificationWhenNoNewSegmentIsAdded() {
public function testItDoesNotSchedulesWelcomeEmailNotificationWhenNoNewSegmentIsAdded() {
$this->_createWelcomeNewsletter();
$subscriber = Subscriber::createOrUpdate([
'email' => 'raul.doe@mailpoet.com',
@ -731,7 +731,7 @@ class SubscribersTest extends \MailPoetTest {
expect(SendingQueue::findMany())->count(0);
}
function testItSendsConfirmationEmail() {
public function testItSendsConfirmationEmail() {
$response = $this->endpoint->sendConfirmationEmail(['id' => 'non_existent']);
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
@ -745,7 +745,7 @@ class SubscribersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
function testItKeepsSpecialSegmentsUnchangedAfterSaving() {
public function testItKeepsSpecialSegmentsUnchangedAfterSaving() {
$wc_segment = Segment::createOrUpdate([
'name' => 'WooCommerce Users',
'type' => Segment::TYPE_WC_USERS,
@ -806,7 +806,7 @@ class SubscribersTest extends \MailPoetTest {
}
}
function _after() {
public function _after() {
$this->cleanup();
}

8
tests/integration/API/JSON/v1/UserFlagsTest.php
View File

@ -18,7 +18,7 @@ class UserFlagsTest extends \MailPoetTest {
/** @var UserFlagsController */
private $user_flags;
function _before() {
public function _before() {
$this->cleanup();
$this->user_flags = Stub::make(UserFlagsController::class, [
'user_flags_repository' => $this->di_container->get(UserFlagsRepository::class),
@ -26,12 +26,12 @@ class UserFlagsTest extends \MailPoetTest {
'flag_1' => 'default_value_1',
'flag_2' => 'default_value_2',
],
]);
]);
$this->user_flags->set('flag_1', 'value_1');
$this->endpoint = new UserFlags($this->user_flags);
}
function testItCanSetUserFlags() {
public function testItCanSetUserFlags() {
$new_flags = [
'flag_1' => 'new_value_1',
'flag_3' => 'new_value_3',
@ -56,7 +56,7 @@ class UserFlagsTest extends \MailPoetTest {
]);
}
function _after() {
public function _after() {
$this->cleanup();
}

6
tests/integration/API/JSON/v1/WoocommerceSettingsTest.php
View File

@ -14,11 +14,11 @@ class WoocommerceSettingsTest extends \MailPoetTest {
/** @var WPFunctions */
private $wp;
function _before() {
public function _before() {
$this->wp = new WPFunctions();
$this->endpoint = new WoocommerceSettings($this->wp);
}
function testItCanSetSettings() {
public function testItCanSetSettings() {
$this->wp->updateOption('woocommerce_email_base_color', '#ffffff');
$response = $this->endpoint->set([
'woocommerce_email_base_color' => '#aaaaaa',
@ -27,7 +27,7 @@ class WoocommerceSettingsTest extends \MailPoetTest {
expect($this->wp->getOption('woocommerce_email_base_color'))->equals('#aaaaaa');
}
function testItDoesNotSetUnallowedSettings() {
public function testItDoesNotSetUnallowedSettings() {
$response = $this->endpoint->set([
'mailpoet_some_none_exting_option' => 'some value',
]);