Add public keyword to methods
[MAILPOET-2413]
This commit is contained in:
@@ -5,7 +5,7 @@ namespace MailPoet\Cron\Workers\KeyCheck;
|
||||
class KeyCheckWorkerMockImplementation extends KeyCheckWorker {
|
||||
const TASK_TYPE = 'mock_key_check_worker';
|
||||
|
||||
function checkKey() {
|
||||
public function checkKey() {
|
||||
return ['code' => 12345]; // bogus code
|
||||
}
|
||||
}
|
||||
|
@@ -14,23 +14,23 @@ use MailPoetVendor\Idiorm\ORM;
|
||||
require_once('KeyCheckWorkerMockImplementation.php');
|
||||
|
||||
class KeyCheckWorkerTest extends \MailPoetTest {
|
||||
function _before() {
|
||||
public function _before() {
|
||||
parent::_before();
|
||||
$this->worker = new MockKeyCheckWorker();
|
||||
}
|
||||
|
||||
function testItCanInitializeBridgeAPI() {
|
||||
public function testItCanInitializeBridgeAPI() {
|
||||
$this->worker->init();
|
||||
expect($this->worker->bridge instanceof Bridge)->true();
|
||||
}
|
||||
|
||||
function testItReturnsTrueOnSuccessfulKeyCheck() {
|
||||
public function testItReturnsTrueOnSuccessfulKeyCheck() {
|
||||
$task = $this->createRunningTask();
|
||||
$result = $this->worker->processTaskStrategy($task, microtime(true));
|
||||
expect($result)->true();
|
||||
}
|
||||
|
||||
function testItReschedulesCheckOnException() {
|
||||
public function testItReschedulesCheckOnException() {
|
||||
$worker = Stub::make(
|
||||
$this->worker,
|
||||
[
|
||||
@@ -49,7 +49,7 @@ class KeyCheckWorkerTest extends \MailPoetTest {
|
||||
expect($result)->false();
|
||||
}
|
||||
|
||||
function testItReschedulesCheckOnError() {
|
||||
public function testItReschedulesCheckOnError() {
|
||||
$worker = Stub::make(
|
||||
$this->worker,
|
||||
[
|
||||
@@ -75,7 +75,7 @@ class KeyCheckWorkerTest extends \MailPoetTest {
|
||||
return $task;
|
||||
}
|
||||
|
||||
function _after() {
|
||||
public function _after() {
|
||||
$this->di_container->get(SettingsRepository::class)->truncate();
|
||||
ORM::raw_execute('TRUNCATE ' . ScheduledTask::$_table);
|
||||
}
|
||||
|
@@ -13,20 +13,20 @@ class PremiumKeyCheckTest extends \MailPoetTest {
|
||||
/** @var SettingsController */
|
||||
private $settings;
|
||||
|
||||
function _before() {
|
||||
public function _before() {
|
||||
parent::_before();
|
||||
$this->settings = SettingsController::getInstance();
|
||||
$this->premium_key = '123457890abcdef';
|
||||
$this->worker = new PremiumKeyCheck($this->settings, microtime(true));
|
||||
}
|
||||
|
||||
function testItRequiresPremiumKeyToBeSpecified() {
|
||||
public function testItRequiresPremiumKeyToBeSpecified() {
|
||||
expect($this->worker->checkProcessingRequirements())->false();
|
||||
$this->fillPremiumKey();
|
||||
expect($this->worker->checkProcessingRequirements())->true();
|
||||
}
|
||||
|
||||
function testItChecksPremiumKey() {
|
||||
public function testItChecksPremiumKey() {
|
||||
$response = ['code' => Bridge::KEY_VALID];
|
||||
$this->worker->bridge = Stub::make(
|
||||
new Bridge,
|
||||
@@ -56,7 +56,7 @@ class PremiumKeyCheckTest extends \MailPoetTest {
|
||||
);
|
||||
}
|
||||
|
||||
function _after() {
|
||||
public function _after() {
|
||||
$this->di_container->get(SettingsRepository::class)->truncate();
|
||||
}
|
||||
}
|
||||
|
@@ -11,19 +11,19 @@ use MailPoet\Settings\SettingsController;
|
||||
use MailPoet\Settings\SettingsRepository;
|
||||
|
||||
class SendingServiceKeyCheckTest extends \MailPoetTest {
|
||||
function _before() {
|
||||
public function _before() {
|
||||
parent::_before();
|
||||
$this->mss_key = 'some_key';
|
||||
$this->worker = new SendingServiceKeyCheck($this->di_container->get(SettingsController::class), microtime(true));
|
||||
}
|
||||
|
||||
function testItRequiresMailPoetMethodToBeSetUp() {
|
||||
public function testItRequiresMailPoetMethodToBeSetUp() {
|
||||
expect($this->worker->checkProcessingRequirements())->false();
|
||||
$this->setMailPoetSendingMethod();
|
||||
expect($this->worker->checkProcessingRequirements())->true();
|
||||
}
|
||||
|
||||
function testItChecksMSSKey() {
|
||||
public function testItChecksMSSKey() {
|
||||
$response = ['code' => Bridge::KEY_VALID];
|
||||
$this->worker->bridge = Stub::make(
|
||||
new Bridge,
|
||||
@@ -58,7 +58,7 @@ class SendingServiceKeyCheckTest extends \MailPoetTest {
|
||||
);
|
||||
}
|
||||
|
||||
function _after() {
|
||||
public function _after() {
|
||||
$this->di_container->get(SettingsRepository::class)->truncate();
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user