Add public keyword to methods

[MAILPOET-2413]
2019-12-26 12:56:49 +01:00
parent ec409042d5
commit 43df66d162
823 changed files with 4440 additions and 4440 deletions
--- a/tests/integration/Cron/Workers/SendingQueue/Tasks/LinksTest.php
+++ b/tests/integration/Cron/Workers/SendingQueue/Tasks/LinksTest.php
@ -8,7 +8,7 @@ use MailPoet\Models\NewsletterLink;
 use MailPoetVendor\Idiorm\ORM;

 class LinksTest extends \MailPoetTest {
-  function testItCanSaveLinks() {
+  public function testItCanSaveLinks() {
    $links = [
      [
        'link' => 'http://example.com',
@ -25,7 +25,7 @@ class LinksTest extends \MailPoetTest {
    expect($newsletter_link->url)->equals($links[0]['link']);
  }

-  function testItCanHashAndReplaceLinks() {
+  public function testItCanHashAndReplaceLinks() {
    $rendered_newsletter = [
      'html' => '<a href="http://example.com">Example Link</a>',
      'text' => '<a href="http://example.com">Example Link</a>',
@ -40,7 +40,7 @@ class LinksTest extends \MailPoetTest {
    expect($processed_and_hashed_links[0]['link'])->equals('http://example.com');
  }

-  function testItCanProcessRenderedBody() {
+  public function testItCanProcessRenderedBody() {
    $newsletter = Newsletter::create();
    $newsletter->type = Newsletter::TYPE_STANDARD;
    $newsletter->save();
@ -55,7 +55,7 @@ class LinksTest extends \MailPoetTest {
    expect($result['html'])->contains($newsletter_link->hash);
  }

-  function testItCanEnsureThatUnsubscribeLinkIsAlwaysPresent() {
+  public function testItCanEnsureThatUnsubscribeLinkIsAlwaysPresent() {
    $newsletter = Newsletter::create();
    $newsletter->type = Newsletter::TYPE_STANDARD;
    $newsletter->save();
@ -70,7 +70,7 @@ class LinksTest extends \MailPoetTest {
    expect($unsubscribe_count)->equals(1);
  }

-  function _after() {
+  public function _after() {
    ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
    ORM::raw_execute('TRUNCATE ' . NewsletterLink::$_table);
  }
--- a/tests/integration/Cron/Workers/SendingQueue/Tasks/MailerTest.php
+++ b/tests/integration/Cron/Workers/SendingQueue/Tasks/MailerTest.php
@ -23,7 +23,7 @@ class MailerTest extends \MailPoetTest {
  /** @var SettingsController */
  private $settings;

-  function _before() {
+  public function _before() {
    parent::_before();
    $wp_users = get_users();
    wp_set_current_user($wp_users[0]->ID);
@ -36,11 +36,11 @@ class MailerTest extends \MailPoetTest {
    $this->sender = $this->settings->get('sender');
  }

-  function testConfiguresMailerWhenItConstructs() {
+  public function testConfiguresMailerWhenItConstructs() {
    expect($this->mailer_task->mailer instanceof \MailPoet\Mailer\Mailer)->true();
  }

-  function testItCanConfigureMailerWithSenderAndReplyToAddresses() {
+  public function testItCanConfigureMailerWithSenderAndReplyToAddresses() {
    $newsletter = new \stdClass();

    // when no sender/reply-to information is set, use the sender information
@ -64,19 +64,19 @@ class MailerTest extends \MailPoetTest {
    expect($mailer->reply_to['reply_to_email'])->equals($newsletter->reply_to_address);
  }

-  function testItGetsMailerLog() {
+  public function testItGetsMailerLog() {
    $mailer_log = $this->mailer_task->getMailerLog();
    expect(is_array($mailer_log))->true();
  }

-  function testItUpdatesMailerLogSentCount() {
+  public function testItUpdatesMailerLogSentCount() {
    $mailer_log = $this->mailer_task->getMailerLog();
    expect($mailer_log['sent'])->equals(0);
    $mailer_log = $this->mailer_task->updateSentCount();
    expect($mailer_log['sent'])->equals(1);
  }

-  function testItGetsProcessingMethod() {
+  public function testItGetsProcessingMethod() {
    // when using MailPoet method, newsletters should be processed in bulk
    $this->settings->set(
      Mailer::MAILER_CONFIG_SETTING_NAME,
@ -99,7 +99,7 @@ class MailerTest extends \MailPoetTest {
    expect($mailer_task->getProcessingMethod())->equals('individual');
  }

-  function testItCanPrepareSubscriberForSending() {
+  public function testItCanPrepareSubscriberForSending() {
    $subscriber = Subscriber::create();
    $subscriber->email = 'test@example.com';
    $subscriber->first_name = 'John';
@ -109,7 +109,7 @@ class MailerTest extends \MailPoetTest {
    expect($prepared_subscriber)->equals('John Doe <test@example.com>');
  }

-  function testItCanSend() {
+  public function testItCanSend() {
    $php_mail_class = 'MailPoet\Mailer\Methods\PHPMail';
    $this->settings->set(
      Mailer::MAILER_CONFIG_SETTING_NAME,
@ -139,7 +139,7 @@ class MailerTest extends \MailPoetTest {
    expect($mailer_task->send('Newsletter', 'Subscriber'))->true();
  }

-  function _after() {
+  public function _after() {
    $this->di_container->get(SettingsRepository::class)->truncate();
    ORM::raw_execute('TRUNCATE ' . Subscriber::$_table);
  }
--- a/tests/integration/Cron/Workers/SendingQueue/Tasks/NewsletterTest.php
+++ b/tests/integration/Cron/Workers/SendingQueue/Tasks/NewsletterTest.php
@ -43,7 +43,7 @@ class NewsletterTest extends \MailPoetTest {
  /** @var LoggerFactory */
  private $logger_factory;

-  function _before() {
+  public function _before() {
    parent::_before();
    $this->newsletter_task = new NewsletterTask();
    $this->subscriber = Subscriber::create();
@ -71,11 +71,11 @@ class NewsletterTest extends \MailPoetTest {
    $this->logger_factory = LoggerFactory::getInstance();
  }

-  function testItConstructs() {
+  public function testItConstructs() {
    expect($this->newsletter_task->tracking_enabled)->true();
  }

-  function testItDoesNotGetNewsletterWhenStatusIsNotActiveOrSending() {
+  public function testItDoesNotGetNewsletterWhenStatusIsNotActiveOrSending() {
    // draft or any other status return false
    $newsletter = $this->newsletter;
    $newsletter->status = Newsletter::STATUS_DRAFT;
@ -94,14 +94,14 @@ class NewsletterTest extends \MailPoetTest {
    expect($this->newsletter_task->getNewsletterFromQueue($this->queue))->isInstanceOf('Mailpoet\Models\Newsletter');
  }

-  function testItDoesNotGetDeletedNewsletter() {
+  public function testItDoesNotGetDeletedNewsletter() {
    $newsletter = $this->newsletter;
    $newsletter->set_expr('deleted_at', 'NOW()');
    $newsletter->save();
    expect($this->newsletter_task->getNewsletterFromQueue($this->queue))->false();
  }

-  function testItDoesNotGetNewsletterWhenParentNewsletterStatusIsNotActiveOrSending() {
+  public function testItDoesNotGetNewsletterWhenParentNewsletterStatusIsNotActiveOrSending() {
    // draft or any other status return false
    $parent_newsletter = $this->parent_newsletter;
    $parent_newsletter->status = Newsletter::STATUS_DRAFT;
@ -132,7 +132,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($this->newsletter_task->getNewsletterFromQueue($this->queue))->isInstanceOf('Mailpoet\Models\Newsletter');
  }

-  function testItDoesNotGetDeletedNewsletterWhenParentNewsletterIsDeleted() {
+  public function testItDoesNotGetDeletedNewsletterWhenParentNewsletterIsDeleted() {
    $parent_newsletter = $this->parent_newsletter;
    $parent_newsletter->set_expr('deleted_at', 'NOW()');
    $parent_newsletter->save();
@ -143,14 +143,14 @@ class NewsletterTest extends \MailPoetTest {
    expect($this->newsletter_task->getNewsletterFromQueue($this->queue))->false();
  }

-  function testItReturnsNewsletterObjectWhenRenderedNewsletterBodyExistsInTheQueue() {
+  public function testItReturnsNewsletterObjectWhenRenderedNewsletterBodyExistsInTheQueue() {
    $queue = $this->queue;
    $queue->newsletter_rendered_body = ['html' => 'test', 'text' => 'test'];
    $result = $this->newsletter_task->preProcessNewsletter($this->newsletter, $queue);
    expect($result instanceof \MailPoet\Models\Newsletter)->true();
  }

-  function testItHashesLinksAndInsertsTrackingImageWhenTrackingIsEnabled() {
+  public function testItHashesLinksAndInsertsTrackingImageWhenTrackingIsEnabled() {
    $wp = Stub::make(new WPFunctions, [
      'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']),
    ]);
@ -172,7 +172,7 @@ class NewsletterTest extends \MailPoetTest {
    expect(WPHooksHelper::getFilterApplied($hook_name)[1] instanceof Newsletter)->true();
  }

-  function testItDoesNotHashLinksAndInsertTrackingCodeWhenTrackingIsDisabled() {
+  public function testItDoesNotHashLinksAndInsertTrackingCodeWhenTrackingIsDisabled() {
    $wp = Stub::make(new WPFunctions, [
      'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']),
    ]);
@ -195,7 +195,7 @@ class NewsletterTest extends \MailPoetTest {
    expect(WPHooksHelper::getFilterApplied($hook_name)[1] instanceof Newsletter)->true();
  }

-  function testItReturnsFalseAndDeletesNewsletterWhenPostNotificationContainsNoPosts() {
+  public function testItReturnsFalseAndDeletesNewsletterWhenPostNotificationContainsNoPosts() {
    $newsletter = $this->newsletter;

    $newsletter->type = Newsletter::TYPE_NOTIFICATION_HISTORY;
@ -211,7 +211,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($newsletter)->false();
  }

-  function testItSavesNewsletterPosts() {
+  public function testItSavesNewsletterPosts() {
    $this->newsletter->type = Newsletter::TYPE_NOTIFICATION_HISTORY;
    $this->newsletter->parent_id = $this->newsletter->id;
    $posts_task = $this->make(PostsTask::class, [
@ -226,7 +226,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($newsletter_post->post_id)->equals('10');
  }

-  function testItUpdatesStatusAndSetsSentAtDateOnlyForStandardAndPostNotificationNewsletters() {
+  public function testItUpdatesStatusAndSetsSentAtDateOnlyForStandardAndPostNotificationNewsletters() {
    $newsletter = $this->newsletter;
    $queue = new \stdClass();
    $queue->processed_at = date('Y-m-d H:i:s');
@ -258,7 +258,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($updated_newsletter->status)->notEquals(Newsletter::STATUS_SENT);
  }

-  function testItDoesNotRenderSubscriberShortcodeInSubjectWhenPreprocessingNewsletter() {
+  public function testItDoesNotRenderSubscriberShortcodeInSubjectWhenPreprocessingNewsletter() {
    $newsletter = $this->newsletter;
    $newsletter->subject = 'Newsletter for [subscriber:firstname] [date:dordinal]';
    $queue = $this->queue;
@ -269,7 +269,7 @@ class NewsletterTest extends \MailPoetTest {
      ->contains(date_i18n('jS', $wp->currentTime('timestamp')));
  }

-  function testItUsesADefaultSubjectIfRenderedSubjectIsEmptyWhenPreprocessingNewsletter() {
+  public function testItUsesADefaultSubjectIfRenderedSubjectIsEmptyWhenPreprocessingNewsletter() {
    $newsletter = $this->newsletter;
    $newsletter->subject = '  [custom_shortcode:should_render_empty]  ';
    $queue = $this->queue;
@ -279,7 +279,7 @@ class NewsletterTest extends \MailPoetTest {
      ->equals('No subject');
  }

-  function testItUsesRenderedNewsletterBodyAndSubjectFromQueueObjectWhenPreparingNewsletterForSending() {
+  public function testItUsesRenderedNewsletterBodyAndSubjectFromQueueObjectWhenPreparingNewsletterForSending() {
    $queue = $this->queue;
    $queue->newsletter_rendered_body = [
      'html' => 'queue HTML body',
@ -304,7 +304,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($result['body']['text'])->equals('queue TEXT body');
  }

-  function testItRendersShortcodesAndReplacesSubscriberDataInLinks() {
+  public function testItRendersShortcodesAndReplacesSubscriberDataInLinks() {
    $newsletter = $this->newsletter_task->preProcessNewsletter($this->newsletter, $this->queue);
    $result = $this->newsletter_task->prepareNewsletterForSending(
      $newsletter,
@ -318,7 +318,7 @@ class NewsletterTest extends \MailPoetTest {
      ->contains(Router::NAME . '&endpoint=track&action=click&data=');
  }

-  function testItDoesNotReplaceSubscriberDataInLinksWhenTrackingIsNotEnabled() {
+  public function testItDoesNotReplaceSubscriberDataInLinksWhenTrackingIsNotEnabled() {
    $newsletter_task = $this->newsletter_task;
    $newsletter_task->tracking_enabled = false;
    $newsletter = $newsletter_task->preProcessNewsletter($this->newsletter, $this->queue);
@ -333,7 +333,7 @@ class NewsletterTest extends \MailPoetTest {
      ->notContains(Router::NAME . '&endpoint=track&action=click&data=');
  }

-  function testItGetsSegments() {
+  public function testItGetsSegments() {
    for ($i = 1; $i <= 3; $i++) {
      $newsletter_segment = NewsletterSegment::create();
      $newsletter_segment->newsletter_id = $this->newsletter->id;
@ -345,7 +345,7 @@ class NewsletterTest extends \MailPoetTest {
    );
  }

-  function testItLogsErrorWhenQueueWithCannotBeSaved() {
+  public function testItLogsErrorWhenQueueWithCannotBeSaved() {
    $queue = $this->queue;
    $queue->non_existent_column = true; // this will trigger save error
    try {
@ -358,7 +358,7 @@ class NewsletterTest extends \MailPoetTest {
    }
  }

-  function testItLogsErrorWhenExistingRenderedNewsletterBodyIsInvalid() {
+  public function testItLogsErrorWhenExistingRenderedNewsletterBodyIsInvalid() {
    $queue_mock = $this->createMock(SendingTask::class);
    $queue_mock
      ->expects($this->any())
@ -379,7 +379,7 @@ class NewsletterTest extends \MailPoetTest {
    }
  }

-  function testItLogsErrorWhenNewlyRenderedNewsletterBodyIsInvalid() {
+  public function testItLogsErrorWhenNewlyRenderedNewsletterBodyIsInvalid() {
    $queue = $this->queue;
    $queue_mock = $this->createMock(SendingTask::class);
    $queue_mock
@ -410,7 +410,7 @@ class NewsletterTest extends \MailPoetTest {
    }
  }

-  function testItPreProcessesNewsletterWhenNewlyRenderedNewsletterBodyIsValid() {
+  public function testItPreProcessesNewsletterWhenNewlyRenderedNewsletterBodyIsValid() {
    $queue = $this->queue;
    $queue_mock = $this->createMock(SendingTask::class);
    $queue_mock
@ -444,7 +444,7 @@ class NewsletterTest extends \MailPoetTest {
    expect($newsletter_task->preProcessNewsletter($this->newsletter, $queue_mock))->equals($this->newsletter);
  }

-  function _after() {
+  public function _after() {
    $this->di_container->get(SettingsRepository::class)->truncate();
    ORM::raw_execute('TRUNCATE ' . Subscriber::$_table);
    ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
--- a/tests/integration/Cron/Workers/SendingQueue/Tasks/PostsTest.php
+++ b/tests/integration/Cron/Workers/SendingQueue/Tasks/PostsTest.php
@ -12,12 +12,12 @@ class PostsTest extends \MailPoetTest {
  /** @var PostsTask */
  private $posts_task;

-  function _before() {
+  public function _before() {
    parent::_before();
    $this->posts_task = new PostsTask;
  }

-  function testItFailsWhenNoPostsArePresent() {
+  public function testItFailsWhenNoPostsArePresent() {
    $newsletter = (object)[
      'id' => 1,
      'type' => Newsletter::TYPE_NOTIFICATION_HISTORY,
@ -28,7 +28,7 @@ class PostsTest extends \MailPoetTest {
    expect($this->posts_task->extractAndSave($rendered_newsletter, $newsletter))->equals(false);
  }

-  function testItCanExtractAndSavePosts() {
+  public function testItCanExtractAndSavePosts() {
    $post_id = 10;
    $newsletter = (object)[
      'id' => 2,
@ -44,7 +44,7 @@ class PostsTest extends \MailPoetTest {
    expect($newsletter_post->post_id)->equals($post_id);
  }

-  function testItDoesNotSavePostsWhenNewsletterIsNotANotificationHistory() {
+  public function testItDoesNotSavePostsWhenNewsletterIsNotANotificationHistory() {
    $post_id = 10;
    $newsletter = (object)[
      'id' => 2,
@ -59,7 +59,7 @@ class PostsTest extends \MailPoetTest {
    expect($this->posts_task->extractAndSave($rendered_newsletter, $newsletter))->equals(false);
  }

-  function _after() {
+  public function _after() {
    ORM::raw_execute('TRUNCATE ' . NewsletterPost::$_table);
  }
 }
--- a/tests/integration/Cron/Workers/SendingQueue/Tasks/ShortcodesTest.php
+++ b/tests/integration/Cron/Workers/SendingQueue/Tasks/ShortcodesTest.php
@ -9,7 +9,7 @@ use MailPoet\Models\Subscriber;
 use MailPoetVendor\Idiorm\ORM;

 class ShortcodesTest extends \MailPoetTest {
-  function _before() {
+  public function _before() {
    parent::_before();
    $this->WP_post = wp_insert_post(
      [
@ -20,7 +20,7 @@ class ShortcodesTest extends \MailPoetTest {
    );
  }

-  function testItCanReplaceShortcodes() {
+  public function testItCanReplaceShortcodes() {
    $queue = $newsletter = (object)[
      'id' => 1,
    ];
@ -35,7 +35,7 @@ class ShortcodesTest extends \MailPoetTest {
    expect($result)->equals('John Doe');
  }

-  function testItCanReplaceShortcodesInOneStringUsingContentsFromAnother() {
+  public function testItCanReplaceShortcodesInOneStringUsingContentsFromAnother() {
    $wp_post = get_post($this->WP_post);
    $content = 'Subject line with one shortcode: [newsletter:post_title]';
    $content_source = '<a data-post-id="' . $this->WP_post . '" href="#">latest post</a>';
@ -48,7 +48,7 @@ class ShortcodesTest extends \MailPoetTest {
    expect(Shortcodes::process($content, $content_source))->equals('Subject line with one shortcode: ' . $wp_post->post_title);
  }

-  function _after() {
+  public function _after() {
    ORM::raw_execute('TRUNCATE ' . SendingQueue::$_table);
    ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
    wp_delete_post($this->WP_post, true);