Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add public keyword to methods

Browse Source 
[MAILPOET-2413]
This commit is contained in:
Amine Ben hammou
2019-12-26 12:56:49 +01:00
committed by wxa
parent ec409042d5
commit 43df66d162
823 changed files with 4440 additions and 4440 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/integration/Tasks/StateTest.php
View File

@ -15,12 +15,12 @@ class StateTest extends \MailPoetTest {
/** @var State */
private $tasks_state;
function _before() {
public function _before() {
parent::_before();
$this->tasks_state = new State();
}
function testItCanFetchBasicTasksData() {
public function testItCanFetchBasicTasksData() {
$this->createNewScheduledTask(SendingTask::TASK_TYPE);
$this->createNewScheduledTask(Migration::TASK_TYPE);
$data = $this->tasks_state->getLatestTasks();
@ -34,7 +34,7 @@ class StateTest extends \MailPoetTest {
expect($data[0])->hasKey('newsletter');
}
function testItCanFilterTasksByType() {
public function testItCanFilterTasksByType() {
$this->createNewScheduledTask(SendingTask::TASK_TYPE);
$this->createNewScheduledTask(Migration::TASK_TYPE);
$data = $this->tasks_state->getLatestTasks(Migration::TASK_TYPE);
@ -42,7 +42,7 @@ class StateTest extends \MailPoetTest {
expect($data[0]['type'])->equals(Migration::TASK_TYPE);
}
function testItCanFilterTasksByStatus() {
public function testItCanFilterTasksByStatus() {
$this->createNewScheduledTask(SendingTask::TASK_TYPE, ScheduledTask::STATUS_COMPLETED);
$this->createNewScheduledTask(SendingTask::TASK_TYPE, ScheduledTask::STATUS_PAUSED);
$data = $this->tasks_state->getLatestTasks(null, [ScheduledTask::STATUS_COMPLETED]);
@ -50,7 +50,7 @@ class StateTest extends \MailPoetTest {
expect($data[0]['status'])->equals(ScheduledTask::STATUS_COMPLETED);
}
function testItFetchesNewsletterDataForSendingTasks() {
public function testItFetchesNewsletterDataForSendingTasks() {
$task = $this->createNewScheduledTask(SendingTask::TASK_TYPE);
$newsletter = $this->createNewNewsletter();
$this->createNewSendingQueue($task->id, $newsletter->id, 'Rendered Subject');
@ -61,7 +61,7 @@ class StateTest extends \MailPoetTest {
expect($data[0]['newsletter']['preview_url'])->notEmpty();
}
function testItDoesNotFailForSendingTaskWithMissingNewsletterInconsistentData() {
public function testItDoesNotFailForSendingTaskWithMissingNewsletterInconsistentData() {
$task = $this->createNewScheduledTask(SendingTask::TASK_TYPE);
$this->createNewSendingQueue($task->id);
$data = $this->tasks_state->getLatestTasks();
@ -71,27 +71,27 @@ class StateTest extends \MailPoetTest {
expect($data[0]['newsletter']['preview_url'])->equals(null);
}
function testItDoesNotFailForSendingTaskWithoutQueue() {
public function testItDoesNotFailForSendingTaskWithoutQueue() {
$this->createNewScheduledTask(SendingTask::TASK_TYPE);
$data = $this->tasks_state->getLatestTasks();
expect(count($data))->equals(1);
}
function createNewScheduledTask($type, $status = ScheduledTask::STATUS_COMPLETED) {
public function createNewScheduledTask($type, $status = ScheduledTask::STATUS_COMPLETED) {
$task = ScheduledTask::create();
$task->type = $type;
$task->status = $status;
return $task->save();
}
function createNewNewsletter($subject = 'Test Subject') {
public function createNewNewsletter($subject = 'Test Subject') {
$newsletter = Newsletter::create();
$newsletter->type = Newsletter::TYPE_STANDARD;
$newsletter->subject = $subject;
return $newsletter->save();
}
function createNewSendingQueue($task_id, $newsletter_id = null, $rendered_subject = null) {
public function createNewSendingQueue($task_id, $newsletter_id = null, $rendered_subject = null) {
$queue = SendingQueue::create();
$queue->newsletter_id = $newsletter_id;
$queue->task_id = $task_id;
@ -99,7 +99,7 @@ class StateTest extends \MailPoetTest {
return $queue->save();
}
function _after() {
public function _after() {
ORM::raw_execute('TRUNCATE ' . Newsletter::$_table);
ORM::raw_execute('TRUNCATE ' . ScheduledTask::$_table);
ORM::raw_execute('TRUNCATE ' . SendingQueue::$_table);