Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Better naming

Browse Source 
MAILPOET-4264
This commit is contained in:
John Oleksowicz
2022-06-06 10:53:53 -05:00
committed by Veljko V
parent 6687a291f0
commit 455e463916
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mailpoet/lib/Automation/Engine/Builder/CreateWorkflowFromTemplateController.php
View File

@ -4,19 +4,19 @@ namespace MailPoet\Automation\Engine\Builder;
use MailPoet\Automation\Engine\Storage\WorkflowStorage; use MailPoet\Automation\Engine\Storage\WorkflowStorage;
use MailPoet\Automation\Engine\Workflows\Workflow; use MailPoet\Automation\Engine\Workflows\Workflow;
use MailPoet\Automation\Integrations\MailPoet\Templates\Templates; use MailPoet\Automation\Integrations\MailPoet\Templates\WorkflowBuilder;
use MailPoet\UnexpectedValueException; use MailPoet\UnexpectedValueException;
class CreateWorkflowFromTemplateController { class CreateWorkflowFromTemplateController {
/** @var WorkflowStorage */ /** @var WorkflowStorage */
private $storage; private $storage;
/** @var Templates */ /** @var WorkflowBuilder */
private $templates; private $templates;
public function __construct( public function __construct(
WorkflowStorage $storage, WorkflowStorage $storage,
Templates $templates WorkflowBuilder $templates
) { ) {
$this->storage = $storage; $this->storage = $storage;
$this->templates = $templates; $this->templates = $templates;
@ -28,7 +28,7 @@ class CreateWorkflowFromTemplateController {
switch ($template) { switch ($template) {
case 'delayed-email-after-signup': case 'delayed-email-after-signup':
$workflow = $this->templates->delayedEmailAfterSignup($name); $workflow = $this->templates->delayedEmailAfterSignupWorkflow($name);
break; break;
default: default:
throw UnexpectedValueException::create()->withMessage('Template not found.'); throw UnexpectedValueException::create()->withMessage('Template not found.');

6
mailpoet/lib/Automation/Integrations/MailPoet/Templates/Templates.php → mailpoet/lib/Automation/Integrations/MailPoet/Templates/WorkflowBuilder.php
View File

@ -9,7 +9,7 @@ use MailPoet\Automation\Integrations\MailPoet\Actions\SendWelcomeEmailAction;
use MailPoet\Automation\Integrations\MailPoet\Triggers\SegmentSubscribedTrigger; use MailPoet\Automation\Integrations\MailPoet\Triggers\SegmentSubscribedTrigger;
use MailPoet\Util\Security; use MailPoet\Util\Security;
class Templates { class WorkflowBuilder {
/** @var WaitAction */ /** @var WaitAction */
private $waitAction; private $waitAction;
@ -30,7 +30,7 @@ class Templates {
$this->sendWelcomeEmailAction = $sendWelcomeEmailAction; $this->sendWelcomeEmailAction = $sendWelcomeEmailAction;
} }
public function delayedEmailAfterSignup(string $name): Workflow { public function delayedEmailAfterSignupWorkflow(string $name): Workflow {
$triggerStep = $this->segmentSubscribedTriggerStep(); $triggerStep = $this->segmentSubscribedTriggerStep();
$waitStep = $this->waitStep(60 * 60); $waitStep = $this->waitStep(60 * 60);
@ -38,7 +38,7 @@ class Templates {
$sendEmailStep = $this->sendEmailActionStep(); $sendEmailStep = $this->sendEmailActionStep();
$waitStep->setNextStepId($sendEmailStep->getId()); $waitStep->setNextStepId($sendEmailStep->getId());
$steps = [ $steps = [
$triggerStep, $triggerStep,
$waitStep, $waitStep,

2
mailpoet/lib/DI/ContainerConfigurator.php
View File

@ -135,7 +135,7 @@ class ContainerConfigurator implements IContainerConfigurator {
$container->autowire(\MailPoet\Automation\Integrations\MailPoet\Subjects\SegmentSubject::class)->setPublic(true)->setShared(false); $container->autowire(\MailPoet\Automation\Integrations\MailPoet\Subjects\SegmentSubject::class)->setPublic(true)->setShared(false);
$container->autowire(\MailPoet\Automation\Integrations\MailPoet\Subjects\SubscriberSubject::class)->setPublic(true)->setShared(false); $container->autowire(\MailPoet\Automation\Integrations\MailPoet\Subjects\SubscriberSubject::class)->setPublic(true)->setShared(false);
$container->autowire(\MailPoet\Automation\Integrations\MailPoet\Triggers\SegmentSubscribedTrigger::class)->setPublic(true)->setShared(false); $container->autowire(\MailPoet\Automation\Integrations\MailPoet\Triggers\SegmentSubscribedTrigger::class)->setPublic(true)->setShared(false);
$container->autowire(\MailPoet\Automation\Integrations\MailPoet\Templates\Templates::class)->setPublic(true)->setShared(false); $container->autowire(\MailPoet\Automation\Integrations\MailPoet\Templates\WorkflowBuilder::class)->setPublic(true)->setShared(false);
$container->autowire(\MailPoet\Automation\Integrations\MailPoet\Actions\SendWelcomeEmailAction::class)->setPublic(true); $container->autowire(\MailPoet\Automation\Integrations\MailPoet\Actions\SendWelcomeEmailAction::class)->setPublic(true);
// Config // Config
$container->autowire(\MailPoet\Config\AccessControl::class)->setPublic(true); $container->autowire(\MailPoet\Config\AccessControl::class)->setPublic(true);