Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use the new detach helper in other batch delete use cases

Browse Source 
[MAILPOET-5745]
This commit is contained in:
Jan Jakes
2023-11-29 14:56:39 +01:00
committed by Aschepikov
parent 45f5803293
commit 469bdebf9c
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mailpoet/lib/Form/FormsRepository.php
View File

@@ -96,10 +96,17 @@ class FormsRepository extends Repository {
return 0; return 0;
} }
return $this->entityManager->createQueryBuilder() $result = $this->entityManager->createQueryBuilder()
->delete(FormEntity::class, 'f') ->delete(FormEntity::class, 'f')
->where('f.id IN (:ids)') ->where('f.id IN (:ids)')
->setParameter('ids', $ids) ->setParameter('ids', $ids)
->getQuery()->execute(); ->getQuery()->execute();
// delete was done via DQL, make sure the entities are also detached from the entity manager
$this->detachAll(function (FormEntity $entity) use ($ids) {
return in_array($entity->getId(), $ids, true);
});
return $result;
} }
} }

5
mailpoet/lib/Newsletter/Sending/SendingQueuesRepository.php
View File

@@ -167,6 +167,11 @@ class SendingQueuesRepository extends Repository {
->setParameter('task', $scheduledTask) ->setParameter('task', $scheduledTask)
->getQuery() ->getQuery()
->execute(); ->execute();
// delete was done via DQL, make sure the entities are also detached from the entity manager
$this->detachAll(function (SendingQueueEntity $entity) use ($scheduledTask) {
return $entity->getTask() === $scheduledTask;
});
} }
public function saveCampaignId(SendingQueueEntity $queue, string $campaignId): void { public function saveCampaignId(SendingQueueEntity $queue, string $campaignId): void {