Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use const and early return

Browse Source
This commit is contained in:
Amine Ben hammou
2019-04-11 15:27:54 +02:00
committed by M. Shull
parent b91cc0639d
commit 47a1c22366
1 changed files with 39 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
assets/js/src/listing/notices.jsx
View File

@@ -21,49 +21,49 @@ const resumeMailerSending = () => {
}); });
}; };
function MailerError(props) { const MailerError = (props) => {
if (props.mta_log.error && props.mta_log.status === 'paused' && props.mta_log.error.operation !== 'authorization') { if (!props.mta_log.error || props.mta_log.status !== 'paused' || props.mta_log.error.operation === 'authorization') {
if (props.mta_log.error.operation === 'migration') { return null;
return ( }
<div className="mailpoet_notice notice notice-warning"> if (props.mta_log.error.operation === 'migration') {
<p>{ props.mta_log.error.error_message }</p>
</div>
);
}
let message = props.mta_log.error.error_message;
const code = props.mta_log.error.error_code;
if (code) {
message += message ? ', ' : '';
message += MailPoet.I18n.t('mailerErrorCode').replace('%$1s', code);
}
return ( return (
<div className="mailpoet_notice notice notice-error"> <div className="mailpoet_notice notice notice-warning">
<p> <p>{ props.mta_log.error.error_message }</p>
{
props.mta_log.error.operation === 'send'
? MailPoet.I18n.t('mailerSendErrorNotice').replace('%$1s', props.mta_method)
: MailPoet.I18n.t('mailerConnectionErrorNotice')
}
:
{' '}
<i>{ message }</i>
</p>
{ props.mta_method === 'PHPMail' ? <PHPMailerCheckSettingsNotice /> : <MailerCheckSettingsNotice /> }
<p>
<a
href="javascript:;"
className="button button-primary"
onClick={resumeMailerSending}
>
{ MailPoet.I18n.t('mailerResumeSendingButton') }
</a>
</p>
</div> </div>
); );
} }
return null;
} let message = props.mta_log.error.error_message;
const code = props.mta_log.error.error_code;
if (code) {
message += message ? ', ' : '';
message += MailPoet.I18n.t('mailerErrorCode').replace('%$1s', code);
}
return (
<div className="mailpoet_notice notice notice-error">
<p>
{
props.mta_log.error.operation === 'send'
? MailPoet.I18n.t('mailerSendErrorNotice').replace('%$1s', props.mta_method)
: MailPoet.I18n.t('mailerConnectionErrorNotice')
}
:
{' '}
<i>{ message }</i>
</p>
{ props.mta_method === 'PHPMail' ? <PHPMailerCheckSettingsNotice /> : <MailerCheckSettingsNotice /> }
<p>
<a
href="javascript:;"
className="button button-primary"
onClick={resumeMailerSending}
>
{ MailPoet.I18n.t('mailerResumeSendingButton') }
</a>
</p>
</div>
);
};
MailerError.propTypes = { MailerError.propTypes = {
mta_method: PropTypes.string.isRequired, mta_method: PropTypes.string.isRequired,