Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Eliminate SettingsController creation in analytics

Browse Source 
[MAILPOET-2436]
This commit is contained in:
Jan Jakeš
2019-10-24 10:14:20 +02:00
committed by Jack Kitterhing
parent 456cdacf26
commit 486e39af7c
4 changed files with 140 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/Analytics/Analytics.php
View File

@@ -42,14 +42,13 @@ class Analytics {
return !empty($analytics_settings['enabled']) === true;
}
static function setPublicId($new_public_id) {
$settings = new SettingsController();
$current_public_id = $settings->get('public_id');
function setPublicId($new_public_id) {
$current_public_id = $this->settings->get('public_id');
if ($current_public_id !== $new_public_id) {
$settings->set('public_id', $new_public_id);
$settings->set('new_public_id', 'true');
$this->settings->set('public_id', $new_public_id);
$this->settings->set('new_public_id', 'true');
// Force user data to be resent
$settings->delete(Analytics::SETTINGS_LAST_SENT_KEY);
$this->settings->delete(Analytics::SETTINGS_LAST_SENT_KEY);
}
}