Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add BC compatibility for getters

Browse Source 
If a migration to new columns wasn't executed correctly, we want to be sure that getters return the correct value.
[MAILPOET-3910]
This commit is contained in:
Jan Lysý
2021-11-04 10:09:24 +01:00
committed by Veljko V
parent 22288431b7
commit 4d32cf2f5d
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Entities/DynamicSegmentFilterData.php
View File

@ -2,6 +2,7 @@
namespace MailPoet\Entities;
use MailPoet\Segments\DynamicSegments\Filters\UserRole;
use MailPoetVendor\Doctrine\ORM\Mapping as ORM;
/**
@ -56,10 +57,22 @@ class DynamicSegmentFilterData {
}
public function getFilterType(): ?string {
return $this->filterType;
if ($this->filterType) {
return $this->filterType;
}
// When a new column is empty, we try to get the value from serialized data
return $filterData['segmentType'] ?? null;
}
public function getAction(): ?string {
return $this->action;
if ($this->action) {
return $this->action;
}
// When a new column is empty, we try to get the value from serialized data
// BC compatibility, the wordpress user role segment didn't have action
if ($this->getFilterType() === self::TYPE_USER_ROLE && !isset($this->filterData['action'])) {
return UserRole::TYPE;
}
return $this->filterData['action'] ?? null;
}
}