Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove ScheduledTaskRepository from SettingsController

Browse Source 
[MAILPOET-3643]
This commit is contained in:
Jan Lysý
2021-06-01 18:28:50 +02:00
committed by Veljko V
parent a3818b868f
commit 4d5630b1ca
4 changed files with 110 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
tests/integration/Settings/SettingsControllerTest.php
View File

@@ -3,33 +3,23 @@
namespace MailPoet\Test\Settings;
use Codeception\Stub;
use MailPoet\Cron\Workers\InactiveSubscribers;
use MailPoet\Cron\Workers\WooCommerceSync;
use MailPoet\Entities\FormEntity;
use MailPoet\Entities\ScheduledTaskEntity;
use MailPoet\Entities\SettingEntity;
use MailPoet\Form\FormsRepository;
use MailPoet\Newsletter\Sending\ScheduledTasksRepository;
use MailPoet\Settings\SettingsController;
use MailPoet\Settings\SettingsRepository;
use MailPoet\WP\Functions as WPFunctions;
use MailPoetVendor\Carbon\Carbon;
class SettingsControllerTest extends \MailPoetTest {
/** @var SettingsController */
private $controller;
/** @var ScheduledTasksRepository */
private $tasksRepository;
/** @var FormsRepository */
private $formsReposittory;
public function _before() {
parent::_before();
$this->controller = $this->diContainer->get(SettingsController::class);
$this->tasksRepository = $this->diContainer->get(ScheduledTasksRepository::class);
$this->formsReposittory = $this->diContainer->get(FormsRepository::class);
$this->clear();
}
@@ -131,54 +121,6 @@ class SettingsControllerTest extends \MailPoetTest {
$this->assertEquals(true, true);
}
public function testItReschedulesScheduledTaskForWoocommerceSync(): void {
$newTask = $this->createScheduledTask(WooCommerceSync::TASK_TYPE);
assert($newTask instanceof ScheduledTaskEntity);
$this->controller->onSubscribeOldWoocommerceCustomersChange();
$this->entityManager->clear();
$task = $this->getScheduledTaskByType(WooCommerceSync::TASK_TYPE);
assert($task instanceof ScheduledTaskEntity);
$scheduledAt = $task->getScheduledAt();
assert($scheduledAt instanceof \DateTime);
$expectedScheduledAt = Carbon::createFromTimestamp(WPFunctions::get()->currentTime('timestamp'));
$expectedScheduledAt->subMinute();
expect($scheduledAt)->equals($expectedScheduledAt);
expect($newTask->getId())->equals($task->getId());
}
public function testItCreatesScheduledTaskForWoocommerceSync(): void {
$task = $this->getScheduledTaskByType(WooCommerceSync::TASK_TYPE);
expect($task)->null();
$this->controller->onSubscribeOldWoocommerceCustomersChange();
$task = $this->getScheduledTaskByType(WooCommerceSync::TASK_TYPE);
expect($task)->isInstanceOf(ScheduledTaskEntity::class);
}
public function testItReschedulesScheduledTaskForInactiveSubscribers(): void {
$newTask = $this->createScheduledTask(InactiveSubscribers::TASK_TYPE);
assert($newTask instanceof ScheduledTaskEntity);
$this->controller->onInactiveSubscribersIntervalChange();
$task = $this->getScheduledTaskByType(InactiveSubscribers::TASK_TYPE);
assert($task instanceof ScheduledTaskEntity);
$scheduledAt = $task->getScheduledAt();
assert($scheduledAt instanceof \DateTime);
$expectedScheduledAt = Carbon::createFromTimestamp(WPFunctions::get()->currentTime('timestamp'));
$expectedScheduledAt->subMinute();
expect($scheduledAt)->equals($expectedScheduledAt);
expect($newTask->getId())->equals($task->getId());
}
public function testItCreatesScheduledTaskForInactiveSubscribers(): void {
$task = $this->getScheduledTaskByType(InactiveSubscribers::TASK_TYPE);
expect($task)->null();
$this->controller->onInactiveSubscribersIntervalChange();
$task = $this->getScheduledTaskByType(InactiveSubscribers::TASK_TYPE);
expect($task)->isInstanceOf(ScheduledTaskEntity::class);
}
public function testItReturnsCorrectSuccessMessage(): void {
$this->controller->set('signup_confirmation.enabled', 1);
expect($this->controller->getDefaultSuccessMessage())->equals(__('Check your inbox or spam folder to confirm your subscription.', 'mailpoet'));
@@ -211,7 +153,6 @@ class SettingsControllerTest extends \MailPoetTest {
}
private function clear() {
$this->truncateEntity(ScheduledTaskEntity::class);
$this->truncateEntity(SettingEntity::class);
$this->truncateEntity(FormEntity::class);
}
@@ -220,22 +161,6 @@ class SettingsControllerTest extends \MailPoetTest {
$this->clear();
}
private function getScheduledTaskByType(string $type): ?ScheduledTaskEntity {
return $this->tasksRepository->findOneBy([
'type' => $type,
'status' => ScheduledTaskEntity::STATUS_SCHEDULED,
]);
}
private function createScheduledTask(string $type): ScheduledTaskEntity {
$task = new ScheduledTaskEntity();
$task->setType($type);
$task->setStatus(ScheduledTaskEntity::STATUS_SCHEDULED);
$this->tasksRepository->persist($task);
$this->tasksRepository->flush();
return $task;
}
private function createOrUpdateSetting($name, $value) {
$tableName = $this->entityManager->getClassMetadata(SettingEntity::class)->getTableName();
$this->connection->executeUpdate("