diff --git a/.eslintrc.tests.json b/.eslintrc.tests.json index 8b30046a0a..c4d31bc257 100644 --- a/.eslintrc.tests.json +++ b/.eslintrc.tests.json @@ -19,7 +19,6 @@ "max-len": 0, "space-unary-ops": 0, "no-unused-vars": 0, - "no-unused-expressions": 0, "no-underscore-dangle": 0, "no-shadow": 0, "padded-blocks": 0, diff --git a/tests/javascript/mochaTestHelper.js b/tests/javascript/mochaTestHelper.js index 10e3b833af..81e1d99386 100644 --- a/tests/javascript/mochaTestHelper.js +++ b/tests/javascript/mochaTestHelper.js @@ -236,4 +236,4 @@ global.templates = { textInsertion: Handlebars.compile(jQuery('#newsletter_editor_template_text_widget').html()), textBlockSettings: Handlebars.compile(jQuery('#newsletter_editor_template_text_settings').html()) }; -global.window.templates = global.templates; \ No newline at end of file +global.window.templates = global.templates; diff --git a/tests/javascript/newsletter_editor/blocks/automatedLatestContent.spec.js b/tests/javascript/newsletter_editor/blocks/automatedLatestContent.spec.js index 60486caae1..4e2a87de27 100644 --- a/tests/javascript/newsletter_editor/blocks/automatedLatestContent.spec.js +++ b/tests/javascript/newsletter_editor/blocks/automatedLatestContent.spec.js @@ -307,7 +307,7 @@ define([ }); it('listens to the event', function () { - expect(onStub).to.have.been.calledOnce; + expect(onStub).to.have.been.callCount(1); expect(onStub).to.have.been.calledWith('replaceAllButtonStyles', sinon.match.func); }); @@ -321,7 +321,7 @@ define([ } }; callback(data); - expect(model.set).to.have.been.calledOnce; + expect(model.set).to.have.been.callCount(1); expect(model.set).to.have.been.calledWithMatch(sinon.match.has('readMoreButton', data)); }); }); diff --git a/tests/javascript/newsletter_editor/blocks/button.spec.js b/tests/javascript/newsletter_editor/blocks/button.spec.js index 0a595d6fd5..8b74b868c6 100644 --- a/tests/javascript/newsletter_editor/blocks/button.spec.js +++ b/tests/javascript/newsletter_editor/blocks/button.spec.js @@ -276,7 +276,7 @@ define([ }); it('listens to the event', function () { - expect(onStub).to.have.been.calledOnce; + expect(onStub).to.have.been.callCount(1); expect(onStub).to.have.been.calledWith('replaceAllButtonStyles', sinon.match.func); }); @@ -290,7 +290,7 @@ define([ } }; callback(data); - expect(model.set).to.have.been.calledOnce; + expect(model.set).to.have.been.callCount(1); expect(model.set).to.have.been.calledWithExactly(data); }); }); diff --git a/tests/javascript/newsletter_editor/blocks/posts.spec.js b/tests/javascript/newsletter_editor/blocks/posts.spec.js index 3318940900..2b191fc648 100644 --- a/tests/javascript/newsletter_editor/blocks/posts.spec.js +++ b/tests/javascript/newsletter_editor/blocks/posts.spec.js @@ -254,8 +254,8 @@ define([ stub.restore(); spy.restore(); - expect(spy.withArgs('loadingMorePosts').calledOnce).to.be.true; - expect(spy.withArgs('morePostsLoaded').calledOnce).to.be.true; + expect(spy.withArgs('loadingMorePosts').calledOnce).to.be.true;// eslint-disable-line no-unused-expressions + expect(spy.withArgs('morePostsLoaded').calledOnce).to.be.true;// eslint-disable-line no-unused-expressions expect(model.get('_availablePosts').length).to.equal(3); }); }); diff --git a/tests/javascript/newsletter_editor/components/save.spec.js b/tests/javascript/newsletter_editor/components/save.spec.js index 7a45fe536d..dd192d38f5 100644 --- a/tests/javascript/newsletter_editor/components/save.spec.js +++ b/tests/javascript/newsletter_editor/components/save.spec.js @@ -33,7 +33,8 @@ define([ } }); module.save(); - expect(spy.withArgs('beforeEditorSave').calledOnce).to.be.true; + expect(spy).to.have.callCount(1); + expect(spy).to.have.been.calledWith('beforeEditorSave'); }); it('triggers afterEditorSave event', function() { @@ -54,7 +55,7 @@ define([ }); promise.resolve({ success: true }); module.save(); - expect(spy.withArgs('afterEditorSave').calledOnce).to.be.true; + expect(spy.withArgs('afterEditorSave').calledOnce).to.be.true;// eslint-disable-line no-unused-expressions }); it('sends newsletter json to server for saving', function() { @@ -188,7 +189,8 @@ define([ view.render(); view.$('.mailpoet_save_next').click(); - expect(spy.withArgs('beforeEditorSave').calledOnce).to.be.true; + expect(spy).to.have.callCount(1); + expect(spy).to.have.been.calledWith('beforeEditorSave'); }); });