Move cookie tracking permission check to subscriber cookie service

[MAILPOET-3924]

lib/Statistics/Track/Clicks.php

@@ -107,7 +107,12 @@ class Clicks {
       }
       $this->statisticsClicksRepository->flush();
       $this->sendRevenueCookie($statisticsClicks);
-      $this->sendSubscriberCookie($subscriber);
+
+      $subscriberId = $subscriber->getId();
+      if ($subscriberId) {
+        $this->subscriberCookie->setSubscriberId($subscriberId);
+      }
+
       // track open event
       $this->opens->track($data, $displayImage = false);
       // Update engagement date
@@ -133,12 +138,6 @@ class Clicks {
     }
   }
 
-  private function sendSubscriberCookie($subscriber) {
-    if ($this->trackingConfig->isCookieTrackingEnabled()) {
-      $this->subscriberCookie->setSubscriberId($subscriber->getId());
-    }
-  }
-
   public function processUrl(
     string $url,
     NewsletterEntity $newsletter,

lib/Statistics/Track/SubscriberCookie.php

@@ -2,6 +2,7 @@
 
 namespace MailPoet\Statistics\Track;
 
+use MailPoet\Settings\TrackingConfig;
 use MailPoet\Util\Cookies;
 
 class SubscriberCookie {
@@ -12,13 +13,22 @@ class SubscriberCookie {
   /** @var Cookies */
   private $cookies;
 
+  /** @var TrackingConfig */
+  private $trackingConfig;
+
   public function __construct(
-    Cookies $cookies
+    Cookies $cookies,
+    TrackingConfig $trackingConfig
   ) {
     $this->cookies = $cookies;
+    $this->trackingConfig = $trackingConfig;
   }
 
   public function getSubscriberId(): ?int {
+    if (!$this->trackingConfig->isCookieTrackingEnabled()) {
+      return null;
+    }
+
     $subscriberId = $this->getSubscriberIdFromCookie(self::COOKIE_NAME);
     if ($subscriberId) {
       return $subscriberId;
@@ -34,6 +44,10 @@ class SubscriberCookie {
   }
 
   public function setSubscriberId(int $subscriberId): void {
+    if (!$this->trackingConfig->isCookieTrackingEnabled()) {
+      return;
+    }
+
     $this->cookies->set(
       self::COOKIE_NAME,
       ['subscriber_id' => $subscriberId],