Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove phpstan errors from integration Config tests

Browse Source 
[MAILPOET-3235]
This commit is contained in:
Jan Lysý
2021-01-13 17:34:23 +01:00
committed by Veljko V
parent c9004553c3
commit 4fd0779dcb
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/integration/Config/CapabilitiesTest.php
View File

@ -9,6 +9,7 @@ use MailPoet\Config\AccessControl;
use MailPoet\Config\Capabilities; use MailPoet\Config\Capabilities;
use MailPoet\Config\Renderer; use MailPoet\Config\Renderer;
use MailPoet\WP\Functions as WPFunctions; use MailPoet\WP\Functions as WPFunctions;
use WP_Role;
class CapabilitiesTest extends \MailPoetTest { class CapabilitiesTest extends \MailPoetTest {
@ -42,7 +43,9 @@ class CapabilitiesTest extends \MailPoetTest {
foreach ($permissions as $name => $roles) { foreach ($permissions as $name => $roles) {
foreach ($roles as $role) { foreach ($roles as $role) {
$checked = true; $checked = true;
expect(get_role($role)->has_cap($name))->true(); $role = get_role($role);
assert($role instanceof WP_Role);
expect($role->has_cap($name))->true();
} }
} }
expect($checked)->true(); expect($checked)->true();
@ -55,7 +58,9 @@ class CapabilitiesTest extends \MailPoetTest {
foreach ($permissions as $name => $roles) { foreach ($permissions as $name => $roles) {
foreach ($roles as $role) { foreach ($roles as $role) {
$checked = true; $checked = true;
expect(get_role($role)->has_cap($name))->false(); $role = get_role($role);
assert($role instanceof WP_Role);
expect($role->has_cap($name))->false();
} }
} }
expect($checked)->true(); expect($checked)->true();
@ -78,6 +83,7 @@ class CapabilitiesTest extends \MailPoetTest {
// other MailPoet capabilities were successfully configured // other MailPoet capabilities were successfully configured
$editorRole = get_role('editor'); $editorRole = get_role('editor');
assert($editorRole instanceof WP_Role);
expect($editorRole->has_cap(AccessControl::PERMISSION_ACCESS_PLUGIN_ADMIN))->false(); expect($editorRole->has_cap(AccessControl::PERMISSION_ACCESS_PLUGIN_ADMIN))->false();
expect($editorRole->has_cap(AccessControl::PERMISSION_MANAGE_EMAILS))->true(); expect($editorRole->has_cap(AccessControl::PERMISSION_MANAGE_EMAILS))->true();
@ -86,6 +92,7 @@ class CapabilitiesTest extends \MailPoetTest {
$this->caps->setupWPCapabilities(); $this->caps->setupWPCapabilities();
$editorRole = get_role('editor'); $editorRole = get_role('editor');
assert($editorRole instanceof WP_Role);
expect($editorRole->has_cap(AccessControl::PERMISSION_ACCESS_PLUGIN_ADMIN))->true(); expect($editorRole->has_cap(AccessControl::PERMISSION_ACCESS_PLUGIN_ADMIN))->true();
expect($editorRole->has_cap(AccessControl::PERMISSION_MANAGE_EMAILS))->true(); expect($editorRole->has_cap(AccessControl::PERMISSION_MANAGE_EMAILS))->true();
} }

2
tests/integration/Config/DatabaseTest.php
View File

@ -17,7 +17,7 @@ class DatabaseTest extends \MailPoetTest {
public function _before() { public function _before() {
parent::_before(); parent::_before();
ORM::set_db(null); ORM::set_db(null); // @phpstan-ignore-line
} }
public function testItDefinesTables() { public function testItDefinesTables() {

10
tests/integration/Config/ShortcodesTest.php
View File

@ -66,7 +66,7 @@ class ShortcodesTest extends \MailPoetTest {
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->data->user_email; $subscriber->email = $wpUser->data->user_email; // @phpstan-ignore-line
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -83,7 +83,7 @@ class ShortcodesTest extends \MailPoetTest {
expect($wp->isUserLoggedIn())->true(); expect($wp->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->data->user_email; $subscriber->email = $wpUser->data->user_email; // @phpstan-ignore-line
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -102,7 +102,7 @@ class ShortcodesTest extends \MailPoetTest {
public function testItDoesNotDisplayManageSubscriptionFormForLoggedinNonexistentSubscribers() { public function testItDoesNotDisplayManageSubscriptionFormForLoggedinNonexistentSubscribers() {
$wpUser = wp_set_current_user(1); $wpUser = wp_set_current_user(1);
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
expect(Subscriber::findOne($wpUser->data->user_email))->false(); expect(Subscriber::findOne($wpUser->data->user_email))->false(); // @phpstan-ignore-line
$shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class); $shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class);
$shortcodes->init(); $shortcodes->init();
@ -125,7 +125,7 @@ class ShortcodesTest extends \MailPoetTest {
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->data->user_email; $subscriber->email = $wpUser->data->user_email; // @phpstan-ignore-line
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -138,7 +138,7 @@ class ShortcodesTest extends \MailPoetTest {
public function testItDoesNotDisplayLinkToManageSubscriptionPageForLoggedinNonexistentSubscribers() { public function testItDoesNotDisplayLinkToManageSubscriptionPageForLoggedinNonexistentSubscribers() {
$wpUser = wp_set_current_user(1); $wpUser = wp_set_current_user(1);
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
expect(Subscriber::findOne($wpUser->data->user_email))->false(); expect(Subscriber::findOne($wpUser->data->user_email))->false(); // @phpstan-ignore-line
$shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class); $shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class);
$shortcodes->init(); $shortcodes->init();