Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove unnecessary sanitization of drag and drop result

Browse Source 
[MAILPOET-2610]
This commit is contained in:
Rostislav Wolny
2020-01-27 12:37:49 +01:00
committed by Jack Kitterhing
parent 356ffbf3fe
commit 4fd6f96f76
1 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
assets/js/src/form_editor/blocks/custom_radio/settings_preview.jsx
View File

@@ -66,18 +66,10 @@ const Preview = ({
return null; return null;
} }
// Remove unwanted properties added by sortable
const sanitizeValue = (value) => {
const sanitized = { ...value };
delete sanitized.chosen;
delete sanitized.selected;
return sanitized;
};
const onUpdate = (valueId, text) => { const onUpdate = (valueId, text) => {
const value = valuesWhileMoved.find((v) => v.id === valueId); const value = valuesWhileMoved.find((v) => v.id === valueId);
value.name = text; value.name = text;
update(sanitizeValue(value)); update(value);
}; };
const onCheck = (valueId, checked) => { const onCheck = (valueId, checked) => {
@@ -86,13 +78,13 @@ const Preview = ({
const checkedValue = valuesWhileMoved.find((v) => v.isChecked); const checkedValue = valuesWhileMoved.find((v) => v.isChecked);
if (checkedValue) { if (checkedValue) {
delete checkedValue.isChecked; delete checkedValue.isChecked;
update(sanitizeValue(checkedValue)); update(checkedValue);
} }
value.isChecked = true; value.isChecked = true;
} else { } else {
delete value.isChecked; delete value.isChecked;
} }
update(sanitizeValue(value)); update(value);
}; };
const onDragEnd = (result) => { const onDragEnd = (result) => {