Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove isDomainDmarcRestricted

Browse Source 
[MAILPOET-5782]
This commit is contained in:
Brezo Cordero
2024-01-11 14:04:36 -06:00
committed by Aschepikov
parent 7f6b66cf8f
commit 5735d21e4d
3 changed files with 0 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mailpoet/lib/API/JSON/v1/Settings.php
View File

@@ -289,22 +289,6 @@ class Settings extends APIEndpoint {
return $this->successResponse($response);
}
public function checkDomainDmarcPolicy($data = []) {
$domain = $data['domain'] ?? null;
if (!$domain) {
return $this->badRequest([
APIError::BAD_REQUEST => __('No sender domain specified.', 'mailpoet'),
]);
}
$domain = strtolower(trim($domain));
$response = ['isDmarcPolicyRestricted' => $this->senderDomainController->isDomainDmarcRestricted($domain)];
return $this->successResponse($response);
}
public function getAuthorizedSenderDomains($data = []) {
$domain = $data['domain'] ?? null;

11
mailpoet/lib/Services/AuthorizedSenderDomainController.php
View File

@@ -166,17 +166,6 @@ class AuthorizedSenderDomainController {
return $response;
}
/**
* Check Domain DMARC Policy
*
* returns `true` if domain has Restricted policy e.g. policy === reject or quarantine
* otherwise returns `false`
*/
public function isDomainDmarcRestricted(string $domain): bool {
$result = $this->getDmarcPolicyForDomain($domain);
return $result !== DmarcPolicyChecker::POLICY_NONE;
}
/**
* Fetch Domain DMARC Policy
*

12
mailpoet/tests/integration/Services/AuthorizedSenderDomainControllerTest.php
View File

@@ -284,18 +284,6 @@ class AuthorizedSenderDomainControllerTest extends \MailPoetTest {
$controller->verifyAuthorizedSenderDomain('testdomain.com');
}
public function testItReturnsTrueWhenDmarcIsEnabled() {
$controller = $this->getController();
$isRestricted = $controller->isDomainDmarcRestricted('mailpoet.com');
verify($isRestricted)->same(true);
}
public function testItReturnsFalseWhenDmarcIsNotEnabled() {
$controller = $this->getController();
$isRestricted = $controller->isDomainDmarcRestricted('example.com');
verify($isRestricted)->same(false);
}
public function testItReturnsDmarcStatus() {
$controller = $this->getController();
$isRestricted = $controller->getDmarcPolicyForDomain('example.com');