- Refactors statistics tracking

lib/Router/Endpoints/Track.php

@@ -24,60 +24,36 @@ class Track {
   }
 
   static function _processTrackData($data) {
-    if(empty($data['queue_id']) ||
+    $data = (object)$data;
-       empty($data['subscriber_id']) ||
+    if(empty($data->queue_id) ||
-       empty($data['subscriber_token'])
+       empty($data->subscriber_id) ||
+       empty($data->subscriber_token)
     ) {
       return false;
     }
-    $data['queue'] = self::_getQueue($data['queue_id']);
+    $data->queue = SendingQueue::findOne($data->queue_id);
-    $data['subscriber'] = self::_getSubscriber($data['subscriber_id']);
+    $data->subscriber = Subscriber::findOne($data->subscriber_id);
-    $data['newsletter'] = (!empty($data['queue']['newsletter_id'])) ?
+    $data->newsletter = (!empty($data->queue->newsletter_id)) ?
-      self::_getNewsletter($data['queue']['newsletter_id']) :
+      Newsletter::findOne($data->queue->newsletter_id) :
       false;
-    if(!empty($data['link_hash'])) {
+    if(!empty($data->link_hash)) {
-      $data['link'] = self::_getLink($data['link_hash']);
+      $data->link = NewsletterLink::getByHash($data->link_hash);
     }
-    $data_processed_successfully =
+    return self::_validateTrackData($data);
-      ($data['queue'] && $data['subscriber'] && $data['newsletter']);
-    return ($data_processed_successfully) ?
-      self::_validateTrackData($data) :
-      false;
   }
 
   static function _validateTrackData($data) {
-    if(!$data['subscriber']) return false;
+    if(!$data->subscriber || !$data->queue || !$data->newsletter) return false;
     $subscriber_token_match =
-      Subscriber::verifyToken($data['subscriber']['email'], $data['subscriber_token']);
+      Subscriber::verifyToken($data->subscriber->email, $data->subscriber_token);
-    // return if this is an administrator user previewing the newsletter
+    if(!$subscriber_token_match) return false;
-    if($data['subscriber']['wp_user_id'] && $data['preview']) {
+    // return if this is a WP user previewing the newsletter
-      return ($subscriber_token_match) ? $data : false;
+    if($data->subscriber->isWPUser() && $data->preview) {
+      return $data;
     }
     // check if the newsletter was sent to the subscriber
-    $is_valid_subscriber =
+    return ($data->queue->isSubscriberProcessed($data->subscriber->id)) ?
-      (!empty($data['queue']['subscribers']['processed']) &&
+      $data :
-        in_array($data['subscriber']['id'], $data['queue']['subscribers']['processed']));
+      false;
-    return ($is_valid_subscriber && $subscriber_token_match) ? $data : false;
-  }
-
-  static function _getNewsletter($newsletter_id) {
-    $newsletter = Newsletter::findOne($newsletter_id);
-    return ($newsletter) ? $newsletter->asArray() : $newsletter;
-  }
-
-  static function _getSubscriber($subscriber_id) {
-    $subscriber = Subscriber::findOne($subscriber_id);
-    return ($subscriber) ? $subscriber->asArray() : $subscriber;
-  }
-
-  static function _getQueue($queue_id) {
-    $queue = SendingQueue::findOne($queue_id);
-    return ($queue) ? $queue->asArray() : $queue;
-  }
-
-  static function _getLink($link_hash) {
-    $link = NewsletterLink::where('hash', $link_hash)
-      ->findOne();
-    return ($link) ? $link->asArray() : $link;
   }
 }

lib/Statistics/Track/Clicks.php

@@ -8,35 +8,26 @@ if(!defined('ABSPATH')) exit;
 
 class Clicks {
   static function track($data) {
-    if(!$data || empty($data['link'])) return false;
+    if(!$data || empty($data->link)) self::abort();
-    $subscriber = $data['subscriber'];
+    $subscriber = $data->subscriber;
-    $queue = $data['queue'];
+    $queue = $data->queue;
-    $newsletter = $data['newsletter'];
+    $newsletter = $data->newsletter;
-    $link = $data['link'];
+    $link = $data->link;
     // log statistics only if the action did not come from
-    // an admin user previewing the newsletter
+    // a WP user previewing the newsletter
-    if(!$data['preview'] && !$subscriber['wp_user_id']) {
+    if(!$data->preview && !$subscriber->isWPUser()) {
-      $statistics = StatisticsClicks::where('link_id', $link['id'])
+      $statistics = StatisticsClicks::createOrUpdateClickCount(
-        ->where('subscriber_id', $subscriber['id'])
+        $link->id,
-        ->where('newsletter_id', $newsletter['id'])
+        $subscriber->id,
-        ->where('queue_id', $queue['id'])
+        $newsletter->id,
-      ->findOne();
+        $queue->id
-      if(!$statistics) {
+      );
+      if($statistics->isNew()) {
         // track open event in case it did not register
         self::trackOpenEvent($data);
-        $statistics = StatisticsClicks::create();
-        $statistics->newsletter_id = $newsletter['id'];
-        $statistics->link_id = $link['id'];
-        $statistics->subscriber_id = $subscriber['id'];
-        $statistics->queue_id = $queue['id'];
-        $statistics->count = 1;
-        $statistics->save();
-      } else {
-        $statistics->count++;
-        $statistics->save();
       }
     }
-    $url = self::processUrl($link['url'], $newsletter, $subscriber, $queue);
+    $url = self::processUrl($link->url, $newsletter, $subscriber, $queue);
     self::redirectToUrl($url);
   }
 

lib/Statistics/Track/Opens.php

@@ -8,23 +8,17 @@ if(!defined('ABSPATH')) exit;
 class Opens {
   static function track($data, $display_image = true) {
     if(!$data) return self::displayImage();
-    $subscriber = $data['subscriber'];
+    $subscriber = $data->subscriber;
-    $queue = $data['queue'];
+    $queue = $data->queue;
-    $newsletter = $data['newsletter'];
+    $newsletter = $data->newsletter;
     // log statistics only if the action did not come from
-    // an admin user previewing the newsletter
+    // a WP user previewing the newsletter
-    if (!$data['preview'] && !$subscriber['wp_user_id']) {
+    if(!$data->preview && !$subscriber->isWPUser()) {
-      $statistics = StatisticsOpens::where('subscriber_id', $subscriber['id'])
+      StatisticsOpens::getOrCreate(
-        ->where('newsletter_id', $newsletter['id'])
+        $subscriber->id,
-        ->where('queue_id', $queue['id'])
+        $newsletter->id,
-        ->findOne();
+        $queue->id
-      if(!$statistics) {
+      );
-        $statistics = StatisticsOpens::create();
-        $statistics->newsletter_id = $newsletter['id'];
-        $statistics->subscriber_id = $subscriber['id'];
-        $statistics->queue_id = $queue['id'];
-        $statistics->save();
-      }
     }
     return ($display_image) ?
       self::displayImage() :