Make sure types are correct in models

[MAILPOET-2716]
2020-04-22 11:27:41 +02:00
parent 0b0abea3bb
commit 59c5f2a321
3 changed files with 9 additions and 6 deletions
--- a/lib/Models/Segment.php
+++ b/lib/Models/Segment.php
@ -84,7 +84,7 @@ class Segment extends Model {
  }

  public function withSubscribersCount() {
-    $this->subscribersCount = SubscriberSegment::tableAlias('relation')
+    $query = SubscriberSegment::tableAlias('relation')
      ->where('relation.segment_id', $this->id)
      ->join(
        MP_SUBSCRIBERS_TABLE,
@ -117,8 +117,11 @@ class Segment extends Model {
        Subscriber::STATUS_BOUNCED
      )
      ->whereNull('subscribers.deleted_at')
-      ->findOne()
-      ->asArray();
+      ->findOne();
+
+    if ($query instanceof SubscriberSegment) {
+      $this->subscribersCount = $query->asArray();
+    }

    return $this;
  }