From 59d4ce3ba2e9e6f3e52a1f09fab5eb039f31b01f Mon Sep 17 00:00:00 2001 From: Rodrigo Primo Date: Thu, 6 Jul 2023 11:48:47 -0300 Subject: [PATCH] Update checkCompleted() to also change the processedAt field This commit updates the method ScheduledTaskSubscribersRepository::checkCompleted() to update the processedAt field of the Scheduled Task. The method was added in f62d9b416766e4fdff60ff6dd022da545075c119 and I believe it is meant to be a replacement to \MailPoet\Tasks\Subscribers::checkCompleted(). The original method updates the processedAt field, so I'm assuming the new method should update as well. I found this while working on refactoring \MailPoet\Tasks\Sending::removeSubscribers() to use Doctrine as this method calls \MailPoet\Tasks\Subscribers::checkCompleted() internaly. [MAILPOET-4368] --- .../Newsletter/Sending/ScheduledTaskSubscribersRepository.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mailpoet/lib/Newsletter/Sending/ScheduledTaskSubscribersRepository.php b/mailpoet/lib/Newsletter/Sending/ScheduledTaskSubscribersRepository.php index cf3014afac..23f9106a0b 100644 --- a/mailpoet/lib/Newsletter/Sending/ScheduledTaskSubscribersRepository.php +++ b/mailpoet/lib/Newsletter/Sending/ScheduledTaskSubscribersRepository.php @@ -7,6 +7,7 @@ use MailPoet\Entities\ScheduledTaskEntity; use MailPoet\Entities\ScheduledTaskSubscriberEntity; use MailPoet\Entities\SubscriberEntity; use MailPoet\InvalidStateException; +use MailPoetVendor\Carbon\Carbon; use MailPoetVendor\Doctrine\DBAL\Connection; use MailPoetVendor\Doctrine\ORM\QueryBuilder; @@ -140,6 +141,7 @@ class ScheduledTaskSubscribersRepository extends Repository { $count = $this->countBy(['task' => $task, 'processed' => ScheduledTaskSubscriberEntity::STATUS_UNPROCESSED]); if ($count === 0) { $task->setStatus(ScheduledTaskEntity::STATUS_COMPLETED); + $task->setProcessedAt(new Carbon()); $this->entityManager->flush(); } }