Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Make feature defaults array private

Browse Source 
[MAILPOET-2008]
This commit is contained in:
Jan Jakeš
2019-05-15 15:34:37 +02:00
committed by M. Shull
parent 9f194d8bc2
commit 5b4600193d
5 changed files with 71 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/API/JSON/v1/FeatureFlags.php
View File

@ -12,14 +12,18 @@ if (!defined('ABSPATH')) exit;
class FeatureFlags extends APIEndpoint {
/** @var FeatureFlagsController */
private $feature_flags_controller;
public $permissions = [
'global' => AccessControl::PERMISSION_MANAGE_FEATURES,
];
function __construct(FeatureFlagsController $feature_flags) {
/** @var FeaturesController */
private $features_controller;
/** @var FeatureFlagsController */
private $feature_flags_controller;
function __construct(FeaturesController $features_controller, FeatureFlagsController $feature_flags) {
$this->features_controller = $features_controller;
$this->feature_flags_controller = $feature_flags;
}
@ -30,7 +34,7 @@ class FeatureFlags extends APIEndpoint {
function set(array $flags) {
foreach ($flags as $name => $value) {
if (!isset(FeaturesController::$defaults[$name])) {
if (!$this->features_controller->exists($name)) {
return $this->badRequest([
APIError::BAD_REQUEST => "Feature '$name' does not exist'",
]);