Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Make feature defaults array private

Browse Source 
[MAILPOET-2008]
This commit is contained in:
Jan Jakeš
2019-05-15 15:34:37 +02:00
committed by M. Shull
parent 9f194d8bc2
commit 5b4600193d
5 changed files with 71 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/Features/FeatureFlagsController.php
View File

@@ -6,8 +6,15 @@ use MailPoet\Models\FeatureFlag;
use function MailPoet\Util\array_column;
class FeatureFlagsController {
/** @var FeaturesController */
private $features_controller;
function __construct(FeaturesController $features_controller) {
$this->features_controller = $features_controller;
}
function set($name, $value) {
if (!isset(FeaturesController::$defaults[$name])) {
if (!$this->features_controller->exists($name)) {
throw new \RuntimeException("Feature '$name' does not exist'");
}
@@ -26,7 +33,7 @@ class FeatureFlagsController {
$flagsMap = array_combine(array_column($flags, 'name'), $flags);
$output = [];
foreach (FeaturesController::$defaults as $name => $default) {
foreach ($this->features_controller->getDefaults() as $name => $default) {
$output[] = [
'name' => $name,
'value' => isset($flagsMap[$name]) ? (bool)$flagsMap[$name]['value'] : $default,