Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor code duplication

Browse Source 
[MAILPOET-3168]
This commit is contained in:
Pavel Dohnal
2021-01-07 13:09:27 +01:00
committed by Veljko V
parent b64525ecc5
commit 5db5a7edbc
1 changed files with 10 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/API/JSON/ResponseBuilders/SegmentsResponseBuilder.php
View File

@ -29,10 +29,7 @@ class SegmentsResponseBuilder {
$this->segmentSubscriberRepository = $segmentSubscriberRepository; $this->segmentSubscriberRepository = $segmentSubscriberRepository;
} }
/** public function build(SegmentEntity $segment): array {
* @return array
*/
public function build(SegmentEntity $segment) {
return [ return [
'id' => (string)$segment->getId(), // (string) for BC 'id' => (string)$segment->getId(), // (string) for BC
'name' => $segment->getName(), 'name' => $segment->getName(),
@ -58,20 +55,14 @@ class SegmentsResponseBuilder {
} }
private function buildListingItem(SegmentEntity $segment, array $scheduledNewsletterSubjectsMap, array $automatedNewsletterSubjectsMap): array { private function buildListingItem(SegmentEntity $segment, array $scheduledNewsletterSubjectsMap, array $automatedNewsletterSubjectsMap): array {
return [ $data = $this->build($segment);
'id' => (string)$segment->getId(), // (string) for BC
'name' => $segment->getName(), $data['automated_emails_subjects'] = $automatedNewsletterSubjectsMap[$segment->getId()] ?? [];
'type' => $segment->getType(), $data['scheduled_emails_subjects'] = $scheduledNewsletterSubjectsMap[$segment->getId()] ?? [];
'description' => $segment->getDescription(), $data['subscribers_count'] = $this->segmentSubscriberRepository->getSubscribersStatisticsCount($segment);
'created_at' => $segment->getCreatedAt()->format(self::DATE_FORMAT), $data['subscribers_url'] = $this->wp->adminUrl(
'updated_at' => $segment->getUpdatedAt()->format(self::DATE_FORMAT),
'deleted_at' => ($deletedAt = $segment->getDeletedAt()) ? $deletedAt->format(self::DATE_FORMAT) : null,
'automated_emails_subjects' => $automatedNewsletterSubjectsMap[$segment->getId()] ?? [],
'scheduled_emails_subjects' => $scheduledNewsletterSubjectsMap[$segment->getId()] ?? [],
'subscribers_count' => $this->segmentSubscriberRepository->getSubscribersStatisticsCount($segment),
'subscribers_url' => $this->wp->adminUrl(
'admin.php?page=mailpoet-subscribers#/filter[segment=' . $segment->getId() . ']' 'admin.php?page=mailpoet-subscribers#/filter[segment=' . $segment->getId() . ']'
), );
]; return $data;
} }
} }