Improve code according the review
[MAILPOET-3708]
This commit is contained in:
@@ -60,7 +60,7 @@ let fields = [
|
||||
return segment.name;
|
||||
},
|
||||
getCount: function getCount(segment) {
|
||||
return `${parseInt(segment.subscribers, 10).toLocaleString()}`;
|
||||
return parseInt(segment.subscribers, 10).toLocaleString();
|
||||
},
|
||||
transformChangedValue: function transformChangedValue(segmentIds) {
|
||||
const allSegments = this.getItems();
|
||||
|
@@ -160,7 +160,7 @@ let fields = [
|
||||
return segment.name;
|
||||
},
|
||||
getCount: function getCount(segment) {
|
||||
return `${parseInt(segment.subscribers, 10).toLocaleString()}`;
|
||||
return parseInt(segment.subscribers, 10).toLocaleString();
|
||||
},
|
||||
transformChangedValue: function transformChangedValue(segmentIds) {
|
||||
const allSegments = this.getItems();
|
||||
|
@@ -27,7 +27,7 @@ const segmentField = {
|
||||
placeholder: MailPoet.I18n.t('selectSegmentPlaceholder'),
|
||||
forceSelect2: true,
|
||||
values: availableSegments,
|
||||
getCount: (segment) => `${parseInt(segment.subscribers, 10).toLocaleString()}`,
|
||||
getCount: (segment) => parseInt(segment.subscribers, 10).toLocaleString(),
|
||||
getLabel: (segment) => segment.name,
|
||||
getValue: (segment) => segment.id,
|
||||
};
|
||||
|
@@ -16,7 +16,7 @@ export default (props: Props) => {
|
||||
const segments = useSelector(selector)().map((segment) => ({
|
||||
value: segment.id,
|
||||
label: segment.name,
|
||||
count: `${segment.subscribers}`,
|
||||
count: segment.subscribers,
|
||||
}));
|
||||
|
||||
const defaultValue = segments.filter((segment) => props.value.includes(segment.value));
|
||||
|
@@ -168,7 +168,7 @@ class Subscriber extends Model {
|
||||
->whereNull('deleted_at')
|
||||
->count();
|
||||
$subscribersWithoutSegmentLabel = sprintf(
|
||||
WPFunctions::get()->__('Subscribers without a list (%s)', 'mailpoet'),
|
||||
__('Subscribers without a list (%s)', 'mailpoet'),
|
||||
number_format($subscribersWithoutSegment)
|
||||
);
|
||||
|
||||
|
@@ -233,7 +233,7 @@ class SubscriberListingRepository extends ListingRepository {
|
||||
$subscribersWithoutSegmentCount = $subscribersWithoutSegmentStats[$key];
|
||||
|
||||
$subscribersWithoutSegmentLabel = sprintf(
|
||||
WPFunctions::get()->__('Subscribers without a list (%s)', 'mailpoet'),
|
||||
__('Subscribers without a list (%s)', 'mailpoet'),
|
||||
number_format((float)$subscribersWithoutSegmentCount)
|
||||
);
|
||||
|
||||
|
Reference in New Issue
Block a user