Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix removing redundant filters

Browse Source 
[MAILPOET-3469]
This commit is contained in:
Jan Lysý
2021-06-10 11:04:20 +02:00
committed by Veljko V
parent a23c73b341
commit 61fc1f1b5e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Segments/SegmentsRepository.php
View File

@ -108,9 +108,11 @@ class SegmentsRepository extends Repository {
$this->persist($segment); $this->persist($segment);
} }
// We want to remove redundant filters before update
while ($segment->getDynamicFilters()->count() > count($filtersData)) { while ($segment->getDynamicFilters()->count() > count($filtersData)) {
$segment->getDynamicFilters()->removeElement($segment->getDynamicFilters()->last()); $filterEntity = $segment->getDynamicFilters()->last();
$this->entityManager->remove($segment->getDynamicFilters()->last()); $segment->getDynamicFilters()->removeElement($filterEntity);
$this->entityManager->remove($filterEntity);
} }
foreach ($filtersData as $key => $filterData) { foreach ($filtersData as $key => $filterData) {
if ($filterData instanceof DynamicSegmentFilterData) { if ($filterData instanceof DynamicSegmentFilterData) {