Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Improve message for confirmation emails when confirmation is disabled

Browse Source 
[MAILPOET-4149]
This commit is contained in:
Rostislav Wolny
2022-04-25 16:28:44 +02:00
committed by Veljko V
parent e4b53dd763
commit 62c7022227
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mailpoet/tests/integration/API/JSON/v1/SubscribersTest.php
View File

@@ -96,7 +96,8 @@ class SubscribersTest extends \MailPoetTest {
$container->get(SubscriberListingRepository::class),
$container->get(SegmentsRepository::class),
$container->get(SubscriberSaveController::class),
$container->get(SubscriberSubscribeController::class)
$container->get(SubscriberSubscribeController::class),
$container->get(SettingsController::class)
);
$this->obfuscatedEmail = $obfuscator->obfuscate('email');
$this->obfuscatedSegments = $obfuscator->obfuscate('segments');
@@ -945,6 +946,13 @@ class SubscribersTest extends \MailPoetTest {
expect($response->status)->equals(APIResponse::STATUS_NOT_FOUND);
}
public function testItDisplaysProperErrorMessageWhenConfirmationEmailsAreDisabled() {
$this->settings->set('signup_confirmation.enabled', false);
$response = $this->endpoint->sendConfirmationEmail(['id' => $this->subscriber1->getId()]);
expect($response->status)->equals(APIResponse::STATUS_BAD_REQUEST);
expect($response->errors[0]['message'])->equals('Sign-up confirmation is disabled in your <a href="admin.php?page=mailpoet-settings#/signup">MailPoet settings</a>. Please enable it to resend confirmation emails or update your subscriber’s status manually.');
}
public function testItKeepsSpecialSegmentsUnchangedAfterSaving() {
$wcSegment = Segment::createOrUpdate([
'name' => 'WooCommerce Users',