Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix name of getter in SegmentEntity

Browse Source 
[MAILPOET-3469]
This commit is contained in:
Jan Lysý
2021-06-16 15:36:34 +02:00
committed by Veljko V
parent f65959cdaf
commit 62d6881966
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/API/JSON/ResponseBuilders/SegmentsResponseBuilder.php
View File

@ -33,7 +33,7 @@ class SegmentsResponseBuilder {
'updated_at' => $segment->getUpdatedAt()->format(self::DATE_FORMAT), 'updated_at' => $segment->getUpdatedAt()->format(self::DATE_FORMAT),
'deleted_at' => ($deletedAt = $segment->getDeletedAt()) ? $deletedAt->format(self::DATE_FORMAT) : null, 'deleted_at' => ($deletedAt = $segment->getDeletedAt()) ? $deletedAt->format(self::DATE_FORMAT) : null,
'average_engagement_score' => $segment->getAverageEngagementScore(), 'average_engagement_score' => $segment->getAverageEngagementScore(),
'filters_connect' => $segment->getFiltersConnectOperand(), 'filters_connect' => $segment->getFiltersConnectOperator(),
]; ];
} }

2
lib/Entities/SegmentEntity.php
View File

@ -155,7 +155,7 @@ class SegmentEntity {
* Returns connect operand from the first filter, when doesn't exist, then returns a default value. * Returns connect operand from the first filter, when doesn't exist, then returns a default value.
* @return string * @return string
*/ */
public function getFiltersConnectOperand(): string { public function getFiltersConnectOperator(): string {
$firstFilter = $this->getDynamicFilters()->first(); $firstFilter = $this->getDynamicFilters()->first();
$filterData = $firstFilter ? $firstFilter->getFilterData() : null; $filterData = $firstFilter ? $firstFilter->getFilterData() : null;
if (!$firstFilter || !$filterData) { if (!$firstFilter || !$filterData) {

2
lib/Segments/DynamicSegments/FilterHandler.php
View File

@ -61,7 +61,7 @@ class FilterHandler {
if (!$filter) return $queryBuilder; if (!$filter) return $queryBuilder;
$subscribersTable = $this->entityManager->getClassMetadata(SubscriberEntity::class)->getTableName(); $subscribersTable = $this->entityManager->getClassMetadata(SubscriberEntity::class)->getTableName();
if ($segment->getFiltersConnectOperand() === DynamicSegmentFilterData::CONNECT_TYPE_OR) { if ($segment->getFiltersConnectOperator() === DynamicSegmentFilterData::CONNECT_TYPE_OR) {
// the final query: SELECT * FROM subscribers INNER JOIN (filter_select1 UNION filter_select2) filtered_subscribers ON filtered_subscribers.inner_subscriber_id = id // the final query: SELECT * FROM subscribers INNER JOIN (filter_select1 UNION filter_select2) filtered_subscribers ON filtered_subscribers.inner_subscriber_id = id
$queryBuilder->innerJoin( $queryBuilder->innerJoin(
$subscribersTable, $subscribersTable,