Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove \MailPoet\Tasks\Subscribers class now that it is not used anymore

Browse Source 
[MAILPOET-4368]
This commit is contained in:
Rodrigo Primo
2023-07-07 11:29:34 -03:00
committed by Aschepikov
parent 8b4e747499
commit 63a0f0b940
3 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mailpoet/lib/Tasks/Sending.php
View File

@@ -39,9 +39,6 @@ class Sending {
/** @var SendingQueue */ /** @var SendingQueue */
private $queue; private $queue;
/** @var Subscribers */
private $taskSubscribers;
private $queueFields = [ private $queueFields = [
'id', 'id',
'task_id', 'task_id',
@@ -94,7 +91,6 @@ class Sending {
$this->task = $task; $this->task = $task;
$this->queue = $queue; $this->queue = $queue;
$this->taskSubscribers = new Subscribers($task);
$this->scheduledTaskSubscribersRepository = ContainerWrapper::getInstance()->get(ScheduledTaskSubscribersRepository::class); $this->scheduledTaskSubscribersRepository = ContainerWrapper::getInstance()->get(ScheduledTaskSubscribersRepository::class);
$this->scheduledTasksRepository = ContainerWrapper::getInstance()->get(ScheduledTasksRepository::class); $this->scheduledTasksRepository = ContainerWrapper::getInstance()->get(ScheduledTasksRepository::class);
$this->sendingQueuesRepository = ContainerWrapper::getInstance()->get(SendingQueuesRepository::class); $this->sendingQueuesRepository = ContainerWrapper::getInstance()->get(SendingQueuesRepository::class);
@@ -245,10 +241,6 @@ class Sending {
return $this->task; return $this->task;
} }
public function taskSubscribers() {
return $this->taskSubscribers;
}
public function getSubscribers($processed = null) { public function getSubscribers($processed = null) {
if (is_null($processed)) { if (is_null($processed)) {
$subscribers = $this->scheduledTaskSubscribersRepository->findBy(['task' => $this->task->id]); $subscribers = $this->scheduledTaskSubscribersRepository->findBy(['task' => $this->task->id]);

20
mailpoet/lib/Tasks/Subscribers.php
View File

@@ -1,20 +0,0 @@
<?php // phpcs:ignore SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing
namespace MailPoet\Tasks;
use MailPoet\Models\ScheduledTask;
use MailPoet\Models\ScheduledTaskSubscriber;
class Subscribers {
private $task;
public function __construct(
ScheduledTask $task
) {
$this->task = $task;
}
public function getSubscribers() {
return ScheduledTaskSubscriber::where('task_id', $this->task->id);
}
}

2
mailpoet/tests/integration/Tasks/SendingTest.php
View File

@@ -10,7 +10,6 @@ use MailPoet\Models\SendingQueue;
use MailPoet\Newsletter\Sending\ScheduledTasksRepository; use MailPoet\Newsletter\Sending\ScheduledTasksRepository;
use MailPoet\Newsletter\Sending\ScheduledTaskSubscribersRepository; use MailPoet\Newsletter\Sending\ScheduledTaskSubscribersRepository;
use MailPoet\Tasks\Sending as SendingTask; use MailPoet\Tasks\Sending as SendingTask;
use MailPoet\Tasks\Subscribers;
use MailPoet\Test\DataFactories\Newsletter as NewsletterFactory; use MailPoet\Test\DataFactories\Newsletter as NewsletterFactory;
use MailPoet\Test\DataFactories\Subscriber as SubscriberFactory; use MailPoet\Test\DataFactories\Subscriber as SubscriberFactory;
use MailPoet\WP\Functions as WPFunctions; use MailPoet\WP\Functions as WPFunctions;
@@ -66,7 +65,6 @@ class SendingTest extends \MailPoetTest {
verify($sending)->instanceOf(SendingTask::class); verify($sending)->instanceOf(SendingTask::class);
verify($sending->queue())->instanceOf(SendingQueue::class); verify($sending->queue())->instanceOf(SendingQueue::class);
verify($sending->task())->instanceOf(ScheduledTask::class); verify($sending->task())->instanceOf(ScheduledTask::class);
verify($sending->taskSubscribers())->instanceOf(Subscribers::class);
} }
public function testItCanBeConstructedOnlyWithAProperTaskType() { public function testItCanBeConstructedOnlyWithAProperTaskType() {