Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Update renamed NotCamelCaps rule

Browse Source 
[MAILPOET-3658]
This commit is contained in:
Rostislav Wolny
2021-06-28 16:36:15 +02:00
committed by Veljko V
parent 76fe9082a3
commit 65b834a9ff
55 changed files with 195 additions and 195 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -26,7 +26,7 @@
- we want to avoid using `eslint-disable` - we want to avoid using `eslint-disable`
- if we have to use it we need to use a comment explaining why do we need it: - if we have to use it we need to use a comment explaining why do we need it:
`/* eslint-disable no-new -- this class has a side-effect in the constructor and it's a library's. */` `/* eslint-disable no-new -- this class has a side-effect in the constructor and it's a library's. */`
- for PHP we do the same with the exception `// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps` which for now doesn’t require an explanation - for PHP we do the same with the exception `// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps` which for now doesn’t require an explanation
## Git flow ## Git flow
- Do not commit to master. - Do not commit to master.

4
lib/AdminPages/Pages/Newsletters.php
View File

@ -101,7 +101,7 @@ class Newsletters {
} }
public function render() { public function render() {
global $wp_roles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_roles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data = []; $data = [];
@ -115,7 +115,7 @@ class Newsletters {
$data['current_wp_user'] = $this->wp->wpGetCurrentUser()->to_array(); $data['current_wp_user'] = $this->wp->wpGetCurrentUser()->to_array();
$data['current_wp_user_firstname'] = $this->wp->wpGetCurrentUser()->user_firstname; $data['current_wp_user_firstname'] = $this->wp->wpGetCurrentUser()->user_firstname;
$data['site_url'] = $this->wp->siteUrl(); $data['site_url'] = $this->wp->siteUrl();
$data['roles'] = $wp_roles->get_names(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data['roles'] = $wp_roles->get_names(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data['roles']['mailpoet_all'] = $this->wp->__('In any WordPress role', 'mailpoet'); $data['roles']['mailpoet_all'] = $this->wp->__('In any WordPress role', 'mailpoet');
$installedAtDiff = (new \DateTime($this->settings->get('installed_at')))->diff(new \DateTime()); $installedAtDiff = (new \DateTime($this->settings->get('installed_at')))->diff(new \DateTime());

2
lib/AdminPages/Pages/Settings.php
View File

@ -78,7 +78,7 @@ class Settings {
'current_user' => $this->wp->wpGetCurrentUser(), 'current_user' => $this->wp->wpGetCurrentUser(),
'is_woocommerce_active' => $this->woocommerceHelper->isWooCommerceActive(), 'is_woocommerce_active' => $this->woocommerceHelper->isWooCommerceActive(),
'is_members_plugin_active' => $this->wp->isPluginActive('members/members.php'), 'is_members_plugin_active' => $this->wp->isPluginActive('members/members.php'),
'premium_plugin_download_url' => $pluginInformation->download_link ?? null, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'premium_plugin_download_url' => $pluginInformation->download_link ?? null, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'hosts' => [ 'hosts' => [
'web' => Hosts::getWebHosts(), 'web' => Hosts::getWebHosts(),
'smtp' => Hosts::getSMTPHosts(), 'smtp' => Hosts::getSMTPHosts(),

4
lib/Analytics/Reporter.php
View File

@ -55,7 +55,7 @@ class Reporter {
} }
public function getData() { public function getData() {
global $wpdb, $wp_version, $woocommerce; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wpdb, $wp_version, $woocommerce; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$mta = $this->settings->get('mta', []); $mta = $this->settings->get('mta', []);
$newsletters = $this->newslettersRepository->getAnalytics(); $newsletters = $this->newslettersRepository->getAnalytics();
$isCronTriggerMethodWP = $this->settings->get('cron_trigger.method') === CronTrigger::METHOD_WORDPRESS; $isCronTriggerMethodWP = $this->settings->get('cron_trigger.method') === CronTrigger::METHOD_WORDPRESS;
@ -68,7 +68,7 @@ class Reporter {
$result = [ $result = [
'PHP version' => PHP_VERSION, 'PHP version' => PHP_VERSION,
'MySQL version' => $wpdb->db_version(), 'MySQL version' => $wpdb->db_version(),
'WordPress version' => $wp_version, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'WordPress version' => $wp_version, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'Multisite environment' => $this->wp->isMultisite() ? 'yes' : 'no', 'Multisite environment' => $this->wp->isMultisite() ? 'yes' : 'no',
'RTL' => $this->wp->isRtl() ? 'yes' : 'no', 'RTL' => $this->wp->isRtl() ? 'yes' : 'no',
'WP_MEMORY_LIMIT' => WP_MEMORY_LIMIT, 'WP_MEMORY_LIMIT' => WP_MEMORY_LIMIT,

8
lib/AutomaticEmails/AutomaticEmails.php
View File

@ -46,13 +46,13 @@ class AutomaticEmails {
} }
public function getAutomaticEmails() { public function getAutomaticEmails() {
global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if ($this->automaticEmails) { if ($this->automaticEmails) {
return $this->automaticEmails; return $this->automaticEmails;
} }
// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$registeredGroups = preg_grep('!^' . self::FILTER_PREFIX . '(.*?)$!', array_keys($wp_filter)); $registeredGroups = preg_grep('!^' . self::FILTER_PREFIX . '(.*?)$!', array_keys($wp_filter));
if (empty($registeredGroups)) return null; if (empty($registeredGroups)) return null;
@ -134,9 +134,9 @@ class AutomaticEmails {
} }
public function unregisterAutomaticEmails() { public function unregisterAutomaticEmails() {
global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$registeredGroups = preg_grep('!^' . self::FILTER_PREFIX . '(.*?)$!', array_keys($wp_filter)); $registeredGroups = preg_grep('!^' . self::FILTER_PREFIX . '(.*?)$!', array_keys($wp_filter));
if (empty($registeredGroups)) return null; if (empty($registeredGroups)) return null;

2
lib/AutomaticEmails/WooCommerce/Events/PurchasedInCategory.php
View File

@ -82,7 +82,7 @@ class PurchasedInCategory {
return array_map(function($category) { return array_map(function($category) {
return [ return [
'id' => $category->term_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'id' => $category->term_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'name' => $category->name, 'name' => $category->name,
]; ];
}, $allCategories); }, $allCategories);

2
lib/AutomaticEmails/WooCommerce/Events/PurchasedProduct.php
View File

@ -94,7 +94,7 @@ class PurchasedProduct {
$woocommerceProducts = array_map(function($product) { $woocommerceProducts = array_map(function($product) {
return [ return [
'id' => $product->ID, 'id' => $product->ID,
'name' => $product->post_title, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'name' => $product->post_title, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
]; ];
}, $woocommerceProducts); }, $woocommerceProducts);
return $woocommerceProducts; return $woocommerceProducts;

4
lib/Config/Env.php
View File

@ -62,8 +62,8 @@ class Env {
self::initDbParameters($dbHost, $dbUser, $dbPassword, $dbName); self::initDbParameters($dbHost, $dbUser, $dbPassword, $dbName);
// back compatibility for older Premium plugin with underscore naming // back compatibility for older Premium plugin with underscore naming
self::$plugin_name = self::$pluginName; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps self::$plugin_name = self::$pluginName; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
self::$temp_path = self::$tempPath; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps self::$temp_path = self::$tempPath; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
/** /**

4
lib/Config/Populator.php
View File

@ -228,8 +228,8 @@ class Populator {
// set default sender info based on current user // set default sender info based on current user
$sender = [ $sender = [
'name' => $currentUser->display_name, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'name' => $currentUser->display_name, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'address' => $currentUser->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'address' => $currentUser->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
]; ];
// set default from name & address // set default from name & address

6
lib/Config/Updater.php
View File

@ -33,11 +33,11 @@ class Updater {
$latestVersion = $this->getLatestVersion(); $latestVersion = $this->getLatestVersion();
if (isset($latestVersion->new_version)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (isset($latestVersion->new_version)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (version_compare($this->version, $latestVersion->new_version, '<')) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (version_compare($this->version, $latestVersion->new_version, '<')) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$updateTransient->response[$this->plugin] = $latestVersion; $updateTransient->response[$this->plugin] = $latestVersion;
} }
$updateTransient->last_checked = time(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $updateTransient->last_checked = time(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$updateTransient->checked[$this->plugin] = $this->version; $updateTransient->checked[$this->plugin] = $this->version;
} }

2
lib/Cron/Workers/SendingQueue/Migration.php
View File

@ -142,7 +142,7 @@ class Migration extends SimpleWorker {
$queue['id'] $queue['id']
)); ));
// link the queue with the task via task_id // link the queue with the task via task_id
$newTaskId = $wpdb->insert_id; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $newTaskId = $wpdb->insert_id; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$wpdb->query(sprintf( $wpdb->query(sprintf(
'UPDATE %1$s SET `task_id` = %2$s WHERE `id` = %3$s', 'UPDATE %1$s SET `task_id` = %2$s WHERE `id` = %3$s',
MP_SENDING_QUEUES_TABLE, MP_SENDING_QUEUES_TABLE,

4
lib/Form/Widget.php
View File

@ -190,7 +190,7 @@ class Widget extends \WP_Widget {
'widget_title', 'widget_title',
!empty($instance['title']) ? $instance['title'] : '', !empty($instance['title']) ? $instance['title'] : '',
$instance, $instance,
$this->id_base // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->id_base // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
); );
// get form // get form
@ -216,7 +216,7 @@ class Widget extends \WP_Widget {
$output = ''; $output = '';
if (!empty($body) && isset($form['settings']) && is_array($form['settings'])) { if (!empty($body) && isset($form['settings']) && is_array($form['settings'])) {
$formId = $this->id_base . '_' . $form['id']; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $formId = $this->id_base . '_' . $form['id']; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data = [ $data = [
'form_html_id' => $formId, 'form_html_id' => $formId,
'form_id' => $form['id'], 'form_id' => $form['id'],

2
lib/Helpscout/Beacon.php
View File

@ -39,7 +39,7 @@ class Beacon {
CronDaemon::ACTION_PING CronDaemon::ACTION_PING
); );
return [ return [
'name' => $currentUser->display_name, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'name' => $currentUser->display_name, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'email' => $sender['address'], 'email' => $sender['address'],
'PHP version' => PHP_VERSION, 'PHP version' => PHP_VERSION,
'MailPoet Free version' => MAILPOET_VERSION, 'MailPoet Free version' => MAILPOET_VERSION,

4
lib/Mailer/Methods/ErrorMappers/AmazonSESMapper.php
View File

@ -29,11 +29,11 @@ class AmazonSESMapper {
*/ */
public function getErrorFromResponse($response, $subscriber) { public function getErrorFromResponse($response, $subscriber) {
$message = ($response) ? $message = ($response) ?
$response->Error->Message->__toString() : // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $response->Error->Message->__toString() : // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
sprintf(WPFunctions::get()->__('%s has returned an unknown error.', 'mailpoet'), Mailer::METHOD_AMAZONSES); sprintf(WPFunctions::get()->__('%s has returned an unknown error.', 'mailpoet'), Mailer::METHOD_AMAZONSES);
$level = MailerError::LEVEL_HARD; $level = MailerError::LEVEL_HARD;
if ($response && $response->Error->Code->__toString() === 'MessageRejected') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($response && $response->Error->Code->__toString() === 'MessageRejected') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$level = MailerError::LEVEL_SOFT; $level = MailerError::LEVEL_SOFT;
} }
$subscriberErrors = [new SubscriberError($subscriber, null)]; $subscriberErrors = [new SubscriberError($subscriber, null)];

16
lib/Mailer/Methods/PHPMail.php
View File

@ -63,17 +63,17 @@ class PHPMail {
$mailer->clearAddresses(); $mailer->clearAddresses();
$mailer->clearCustomHeaders(); $mailer->clearCustomHeaders();
$mailer->isHTML(!empty($newsletter['body']['html'])); $mailer->isHTML(!empty($newsletter['body']['html']));
$mailer->CharSet = 'UTF-8'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->CharSet = 'UTF-8'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$mailer->setFrom($this->sender['from_email'], $this->sender['from_name'], false); $mailer->setFrom($this->sender['from_email'], $this->sender['from_name'], false);
$mailer->addReplyTo($this->replyTo['reply_to_email'], $this->replyTo['reply_to_name']); $mailer->addReplyTo($this->replyTo['reply_to_email'], $this->replyTo['reply_to_name']);
$subscriber = $this->processSubscriber($subscriber); $subscriber = $this->processSubscriber($subscriber);
$mailer->addAddress($subscriber['email'], $subscriber['name']); $mailer->addAddress($subscriber['email'], $subscriber['name']);
$mailer->Subject = (!empty($newsletter['subject'])) ? $newsletter['subject'] : ''; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->Subject = (!empty($newsletter['subject'])) ? $newsletter['subject'] : ''; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$mailer->Body = (!empty($newsletter['body']['html'])) ? $newsletter['body']['html'] : $newsletter['body']['text']; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->Body = (!empty($newsletter['body']['html'])) ? $newsletter['body']['html'] : $newsletter['body']['text']; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if ($mailer->ContentType !== 'text/plain') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($mailer->ContentType !== 'text/plain') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$mailer->AltBody = (!empty($newsletter['body']['text'])) ? $newsletter['body']['text'] : ''; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->AltBody = (!empty($newsletter['body']['text'])) ? $newsletter['body']['text'] : ''; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
$mailer->Sender = $this->returnPath; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->Sender = $this->returnPath; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!empty($extraParams['unsubscribe_url'])) { if (!empty($extraParams['unsubscribe_url'])) {
$this->mailer->addCustomHeader('List-Unsubscribe', $extraParams['unsubscribe_url']); $this->mailer->addCustomHeader('List-Unsubscribe', $extraParams['unsubscribe_url']);
} }
@ -85,8 +85,8 @@ class PHPMail {
// sendmail command which expects only NL as line endings (POSIX). Since quoted-printable // sendmail command which expects only NL as line endings (POSIX). Since quoted-printable
// requires CRLF some of those commands convert LF to CRLF which can break the email body // requires CRLF some of those commands convert LF to CRLF which can break the email body
// because it already (correctly) uses CRLF. Such CRLF then (wrongly) becomes CRCRLF. // because it already (correctly) uses CRLF. Such CRLF then (wrongly) becomes CRCRLF.
if (\PHPMailer::hasLineLongerThanMax($mailer->Body)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (\PHPMailer::hasLineLongerThanMax($mailer->Body)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$mailer->Encoding = 'base64'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $mailer->Encoding = 'base64'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
return $mailer; return $mailer;

4
lib/Mailer/WordPress/WordPressMailer.php
View File

@ -38,7 +38,7 @@ class WordPressMailer extends \PHPMailer {
public function send() { public function send() {
// We need this so that the \PHPMailer class will correctly prepare all the headers. // We need this so that the \PHPMailer class will correctly prepare all the headers.
$this->Mailer = 'mail'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->Mailer = 'mail'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// Prepare everything (including the message) for sending. // Prepare everything (including the message) for sending.
$this->preSend(); $this->preSend();
@ -71,7 +71,7 @@ class WordPressMailer extends \PHPMailer {
} }
private function getEmail() { private function getEmail() {
// phpcs:disable Squiz.NamingConventions.ValidVariableName.NotCamelCaps // phpcs:disable Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$email = [ $email = [
'subject' => $this->Subject, 'subject' => $this->Subject,
'body' => [], 'body' => [],

6
lib/Newsletter/AutomatedLatestContent.php
View File

@ -43,8 +43,8 @@ class AutomatedLatestContent {
// Queries with taxonomies are autodetected as 'is_archive=true' and 'is_home=false' // Queries with taxonomies are autodetected as 'is_archive=true' and 'is_home=false'
// while queries without them end up being 'is_archive=false' and 'is_home=true'. // while queries without them end up being 'is_archive=false' and 'is_home=true'.
// This is to fix that by always enforcing constistent behavior. // This is to fix that by always enforcing constistent behavior.
$query->is_archive = true; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $query->is_archive = true; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$query->is_home = false; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $query->is_home = false; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function getPosts($args, $postsToExclude = [], $newsletterId = false, $newerThanTimestamp = false) { public function getPosts($args, $postsToExclude = [], $newsletterId = false, $newerThanTimestamp = false) {
@ -179,7 +179,7 @@ class AutomatedLatestContent {
foreach ($posts as $post) { foreach ($posts as $post) {
$postsToLog[] = [ $postsToLog[] = [
'id' => $post->ID, 'id' => $post->ID,
'post_date' => $post->post_date, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'post_date' => $post->post_date, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
]; ];
} }
$this->loggerFactory->getLogger(LoggerFactory::TOPIC_POST_NOTIFICATIONS)->addInfo( $this->loggerFactory->getLogger(LoggerFactory::TOPIC_POST_NOTIFICATIONS)->addInfo(

4
lib/Newsletter/Editor/MetaInformationManager.php
View File

@ -13,7 +13,7 @@ class MetaInformationManager {
if (isset($args['showAuthor']) && $args['showAuthor'] === $positionField) { if (isset($args['showAuthor']) && $args['showAuthor'] === $positionField) {
$text[] = self::getPostAuthor( $text[] = self::getPostAuthor(
$post->post_author, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $post->post_author, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$args['authorPrecededBy'] $args['authorPrecededBy']
); );
} }
@ -21,7 +21,7 @@ class MetaInformationManager {
if (isset($args['showCategories']) && $args['showCategories'] === $positionField) { if (isset($args['showCategories']) && $args['showCategories'] === $positionField) {
$text[] = self::getPostCategories( $text[] = self::getPostCategories(
$post->ID, $post->ID,
$post->post_type, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $post->post_type, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$args['categoriesPrecededBy'] $args['categoriesPrecededBy']
); );
} }

10
lib/Newsletter/Editor/PostContentManager.php
View File

@ -23,19 +23,19 @@ class PostContentManager {
if ($displayType === 'titleOnly') { if ($displayType === 'titleOnly') {
return ''; return '';
} }
if ($this->woocommerceHelper->isWooCommerceActive() && $post->post_type === 'product') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($this->woocommerceHelper->isWooCommerceActive() && $post->post_type === 'product') { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$product = $this->woocommerceHelper->wcGetProduct($post->ID); $product = $this->woocommerceHelper->wcGetProduct($post->ID);
if ($product) { if ($product) {
return $this->getContentForProduct($product, $displayType); return $this->getContentForProduct($product, $displayType);
} }
} }
if ($displayType === 'excerpt') { if ($displayType === 'excerpt') {
if (!empty($post->post_excerpt)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (!empty($post->post_excerpt)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return self::stripShortCodes($post->post_excerpt); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return self::stripShortCodes($post->post_excerpt); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
return $this->generateExcerpt($post->post_content); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return $this->generateExcerpt($post->post_content); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
return self::stripShortCodes($post->post_content); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return self::stripShortCodes($post->post_content); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function filterContent($content, $displayType, $withPostClass = true) { public function filterContent($content, $displayType, $withPostClass = true) {

14
lib/Newsletter/Editor/PostTransformerContentsExtractor.php
View File

@ -58,19 +58,19 @@ class PostTransformerContentsExtractor {
* *
* https://mailpoet.atlassian.net/browse/MAILPOET-1365 * https://mailpoet.atlassian.net/browse/MAILPOET-1365
*/ */
global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps, default is NULL global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps, default is NULL
$contentWidthCopy = $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $contentWidthCopy = $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$content_width = Env::NEWSLETTER_CONTENT_WIDTH; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $content_width = Env::NEWSLETTER_CONTENT_WIDTH; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$imageInfo = $this->wp->wpGetAttachmentImageSrc($id, 'mailpoet_newsletter_max'); $imageInfo = $this->wp->wpGetAttachmentImageSrc($id, 'mailpoet_newsletter_max');
$content_width = $contentWidthCopy; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $content_width = $contentWidthCopy; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return $imageInfo; return $imageInfo;
} }
public function getFeaturedImage($post) { public function getFeaturedImage($post) {
$postId = $post->ID; $postId = $post->ID;
$postTitle = $this->sanitizeTitle($post->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $postTitle = $this->sanitizeTitle($post->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$imageFullWidth = (bool)filter_var($this->args['imageFullWidth'], FILTER_VALIDATE_BOOLEAN); $imageFullWidth = (bool)filter_var($this->args['imageFullWidth'], FILTER_VALIDATE_BOOLEAN);
if (!has_post_thumbnail($postId)) { if (!has_post_thumbnail($postId)) {
@ -131,7 +131,7 @@ class PostTransformerContentsExtractor {
} }
public function getTitle($post) { public function getTitle($post) {
$title = $this->sanitizeTitle($post->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $title = $this->sanitizeTitle($post->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (filter_var($this->args['titleIsLink'], FILTER_VALIDATE_BOOLEAN)) { if (filter_var($this->args['titleIsLink'], FILTER_VALIDATE_BOOLEAN)) {
$title = '<a href="' . $this->wp->getPermalink($post->ID) . '">' . $title . '</a>'; $title = '<a href="' . $this->wp->getPermalink($post->ID) . '">' . $title . '</a>';
@ -188,7 +188,7 @@ class PostTransformerContentsExtractor {
} }
public function isProduct($post) { public function isProduct($post) {
return $post->post_type === 'product'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return $post->post_type === 'product'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
/** /**

2
lib/Newsletter/Editor/TitleListTransformer.php
View File

@ -31,7 +31,7 @@ class TitleListTransformer {
} }
private function getPostTitle($post) { private function getPostTitle($post) {
$title = $post->post_title; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $title = $post->post_title; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$alignment = $this->args['titleAlignment']; $alignment = $this->args['titleAlignment'];
$alignment = (in_array($alignment, ['left', 'right', 'center'])) ? $alignment : 'left'; $alignment = (in_array($alignment, ['left', 'right', 'center'])) ? $alignment : 'left';

2
lib/Newsletter/Scheduler/PostNotificationScheduler.php
View File

@ -63,7 +63,7 @@ class PostNotificationScheduler {
] ]
); );
$types = Posts::getTypes(); $types = Posts::getTypes();
if (($newStatus !== 'publish') || !isset($types[$post->post_type])) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (($newStatus !== 'publish') || !isset($types[$post->post_type])) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return; return;
} }
$this->schedulePostNotification($post->ID); $this->schedulePostNotification($post->ID);

4
lib/Newsletter/Shortcodes/Categories/Newsletter.php
View File

@ -58,8 +58,8 @@ class Newsletter implements CategoryInterface {
// Queries with taxonomies are autodetected as 'is_archive=true' and 'is_home=false' // Queries with taxonomies are autodetected as 'is_archive=true' and 'is_home=false'
// while queries without them end up being 'is_archive=false' and 'is_home=true'. // while queries without them end up being 'is_archive=false' and 'is_home=true'.
// This is to fix that by always enforcing constistent behavior. // This is to fix that by always enforcing constistent behavior.
$query->is_archive = true; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $query->is_archive = true; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$query->is_home = false; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $query->is_home = false; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
private function getLatestWPPost($postIds) { private function getLatestWPPost($postIds) {

2
lib/Newsletter/Shortcodes/Categories/Subscriber.php
View File

@ -50,7 +50,7 @@ class Subscriber implements CategoryInterface {
case 'displayname': case 'displayname':
if ($subscriber->getWpUserId()) { if ($subscriber->getWpUserId()) {
$wpUser = WPFunctions::get()->getUserdata($subscriber->getWpUserId()); $wpUser = WPFunctions::get()->getUserdata($subscriber->getWpUserId());
return $wpUser->user_login; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return $wpUser->user_login; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
return $defaultValue; return $defaultValue;
case 'count': case 'count':

20
lib/Router/Endpoints/Track.php
View File

@ -80,22 +80,22 @@ class Track {
public function _processTrackData($data) { public function _processTrackData($data) {
$data = (object)$this->links->transformUrlDataObject($data); $data = (object)$this->links->transformUrlDataObject($data);
if (empty($data->queue_id) || // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($data->queue_id) || // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
empty($data->subscriber_id) || // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps empty($data->subscriber_id) || // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
empty($data->subscriber_token) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps empty($data->subscriber_token) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
) { ) {
return false; return false;
} }
$data->queue = $this->sendingQueuesRepository->findOneById($data->queue_id);// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data->queue = $this->sendingQueuesRepository->findOneById($data->queue_id);// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data->subscriber = $this->subscribersRepository->findOneById($data->subscriber_id); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data->subscriber = $this->subscribersRepository->findOneById($data->subscriber_id); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data->newsletter = (isset($data->newsletter_id)) ? $this->newslettersRepository->findOneById($data->newsletter_id) : null; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data->newsletter = (isset($data->newsletter_id)) ? $this->newslettersRepository->findOneById($data->newsletter_id) : null; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!$data->newsletter && ($data->queue instanceof SendingQueueEntity)) { if (!$data->newsletter && ($data->queue instanceof SendingQueueEntity)) {
$data->newsletter = $data->queue->getNewsletter(); $data->newsletter = $data->queue->getNewsletter();
} }
if (!empty($data->link_hash)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (!empty($data->link_hash)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data->link = $this->newsletterLinkRepository->findOneBy([ $data->link = $this->newsletterLinkRepository->findOneBy([
'hash' => $data->link_hash, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'hash' => $data->link_hash, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'queue' => $data->queue_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'queue' => $data->queue_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
]); ]);
} }
return $this->_validateTrackData($data); return $this->_validateTrackData($data);
@ -103,7 +103,7 @@ class Track {
public function _validateTrackData($data) { public function _validateTrackData($data) {
if (!$data->subscriber || !$data->queue || !$data->newsletter) return false; if (!$data->subscriber || !$data->queue || !$data->newsletter) return false;
$subscriberTokenMatch = $this->linkTokens->verifyToken($data->subscriber, $data->subscriber_token); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriberTokenMatch = $this->linkTokens->verifyToken($data->subscriber, $data->subscriber_token); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!$subscriberTokenMatch) { if (!$subscriberTokenMatch) {
$this->terminate(403); $this->terminate(403);
} }

4
lib/Router/Endpoints/ViewInBrowser.php
View File

@ -38,9 +38,9 @@ class ViewInBrowser {
} }
private function abort() { private function abort() {
global $wp_query;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_query;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
WPFunctions::get()->statusHeader(404); WPFunctions::get()->statusHeader(404);
$wp_query->set_404();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wp_query->set_404();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
exit; exit;
} }
} }

6
lib/Segments/DynamicSegments/Filters/WooCommerceCategory.php
View File

@ -49,12 +49,12 @@ class WooCommerceCategory implements Filter {
"itemmeta.order_item_id = items.order_item_id AND itemmeta.meta_key = '_product_id'" "itemmeta.order_item_id = items.order_item_id AND itemmeta.meta_key = '_product_id'"
)->join( )->join(
'itemmeta', 'itemmeta',
$wpdb->term_relationships, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wpdb->term_relationships, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'term_relationships', 'term_relationships',
'itemmeta.meta_value = term_relationships.object_id' 'itemmeta.meta_value = term_relationships.object_id'
)->innerJoin( )->innerJoin(
'term_relationships', 'term_relationships',
$wpdb->term_taxonomy, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wpdb->term_taxonomy, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'term_taxonomy', 'term_taxonomy',
'term_taxonomy.term_taxonomy_id=term_relationships.term_taxonomy_id 'term_taxonomy.term_taxonomy_id=term_relationships.term_taxonomy_id
AND AND
@ -69,7 +69,7 @@ class WooCommerceCategory implements Filter {
$subcategories = $this->wp->getTerms('product_cat', ['child_of' => $categoryId]); $subcategories = $this->wp->getTerms('product_cat', ['child_of' => $categoryId]);
if (!is_array($subcategories)) return []; if (!is_array($subcategories)) return [];
$ids = array_map(function($category) { $ids = array_map(function($category) {
return $category->term_id; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps return $category->term_id; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
}, $subcategories); }, $subcategories);
$ids[] = $categoryId; $ids[] = $categoryId;
return $ids; return $ids;

12
lib/Segments/WP.php
View File

@ -60,13 +60,13 @@ class WP {
// find subscriber by email when is false // find subscriber by email when is false
if (!$subscriber) { if (!$subscriber) {
$subscriber = Subscriber::where('email', $wpUser->user_email)->findOne(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber = Subscriber::where('email', $wpUser->user_email)->findOne(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
// get first name & last name // get first name & last name
$firstName = $wpUser->first_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $firstName = $wpUser->first_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$lastName = $wpUser->last_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $lastName = $wpUser->last_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (empty($wpUser->first_name) && empty($wpUser->last_name)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($wpUser->first_name) && empty($wpUser->last_name)) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$firstName = $wpUser->display_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $firstName = $wpUser->display_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
$signupConfirmationEnabled = SettingsController::getInstance()->get('signup_confirmation.enabled'); $signupConfirmationEnabled = SettingsController::getInstance()->get('signup_confirmation.enabled');
$status = $signupConfirmationEnabled ? Subscriber::STATUS_UNCONFIRMED : Subscriber::STATUS_SUBSCRIBED; $status = $signupConfirmationEnabled ? Subscriber::STATUS_UNCONFIRMED : Subscriber::STATUS_SUBSCRIBED;
@ -77,7 +77,7 @@ class WP {
// subscriber data // subscriber data
$data = [ $data = [
'wp_user_id' => $wpUser->ID, 'wp_user_id' => $wpUser->ID,
'email' => $wpUser->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $wpUser->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'first_name' => $firstName, 'first_name' => $firstName,
'last_name' => $lastName, 'last_name' => $lastName,
'status' => $status, 'status' => $status,

16
lib/Segments/WooCommerce.php
View File

@ -93,11 +93,11 @@ class WooCommerce {
$data['source'] = Source::WOOCOMMERCE_USER; $data['source'] = Source::WOOCOMMERCE_USER;
} }
$data['id'] = $subscriber->id(); $data['id'] = $subscriber->id();
if ($wpUser->first_name) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($wpUser->first_name) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data['first_name'] = $wpUser->first_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data['first_name'] = $wpUser->first_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
if ($wpUser->last_name) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($wpUser->last_name) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data['last_name'] = $wpUser->last_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data['last_name'] = $wpUser->last_name; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
$subscriber = Subscriber::createOrUpdate($data); $subscriber = Subscriber::createOrUpdate($data);
if ($subscriber->getErrors() === false && $subscriber->id > 0) { if ($subscriber->getErrors() === false && $subscriber->id > 0) {
@ -133,8 +133,8 @@ class WooCommerce {
->findOne(); ->findOne();
if ($subscriber !== false) { if ($subscriber !== false) {
$firstName = $wcOrder->get_billing_first_name(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $firstName = $wcOrder->get_billing_first_name(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$lastName = $wcOrder->get_billing_last_name(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $lastName = $wcOrder->get_billing_last_name(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if ($firstName) { if ($firstName) {
$subscriber->firstName = $firstName; $subscriber->firstName = $firstName;
} }
@ -178,11 +178,11 @@ class WooCommerce {
$mailpoetEmailColumn = $wpdb->get_row( $mailpoetEmailColumn = $wpdb->get_row(
'SHOW FULL COLUMNS FROM ' . MP_SUBSCRIBERS_TABLE . ' WHERE Field = "email"' 'SHOW FULL COLUMNS FROM ' . MP_SUBSCRIBERS_TABLE . ' WHERE Field = "email"'
); );
$this->mailpoetEmailCollation = $mailpoetEmailColumn->Collation; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->mailpoetEmailCollation = $mailpoetEmailColumn->Collation; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$wpPostmetaValueColumn = $wpdb->get_row( $wpPostmetaValueColumn = $wpdb->get_row(
'SHOW FULL COLUMNS FROM ' . $wpdb->postmeta . ' WHERE Field = "meta_value"' 'SHOW FULL COLUMNS FROM ' . $wpdb->postmeta . ' WHERE Field = "meta_value"'
); );
$this->wpPostmetaValueCollation = $wpPostmetaValueColumn->Collation; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->wpPostmetaValueCollation = $wpPostmetaValueColumn->Collation; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
private function needsCollationChange(): bool { private function needsCollationChange(): bool {

4
lib/Settings/Pages.php
View File

@ -56,7 +56,7 @@ class Pages {
$page = null; $page = null;
if (!empty($pages)) { if (!empty($pages)) {
$page = array_shift($pages); $page = array_shift($pages);
if (strpos($page->post_content, '[mailpoet_page]') === false) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (strpos($page->post_content, '[mailpoet_page]') === false) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$page = null; $page = null;
} }
} }
@ -102,7 +102,7 @@ class Pages {
$subscriptionUrlFactory = Subscription\SubscriptionUrlFactory::getInstance(); $subscriptionUrlFactory = Subscription\SubscriptionUrlFactory::getInstance();
return [ return [
'id' => $page->ID, 'id' => $page->ID,
'title' => $page->post_title, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'title' => $page->post_title, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'url' => [ 'url' => [
'unsubscribe' => $subscriptionUrlFactory->getSubscriptionUrl($page, 'unsubscribe'), 'unsubscribe' => $subscriptionUrlFactory->getSubscriptionUrl($page, 'unsubscribe'),
'manage' => $subscriptionUrlFactory->getSubscriptionUrl($page, 'manage'), 'manage' => $subscriptionUrlFactory->getSubscriptionUrl($page, 'manage'),

4
lib/Statistics/Track/Clicks.php
View File

@ -142,9 +142,9 @@ class Clicks {
} }
public function abort() { public function abort() {
global $wp_query;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_query;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
WPFunctions::get()->statusHeader(404); WPFunctions::get()->statusHeader(404);
$wp_query->set_404();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wp_query->set_404();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
WPFunctions::get()->getTemplatePart((string)404); WPFunctions::get()->getTemplatePart((string)404);
exit; exit;
} }

2
lib/Subscribers/SubscriberSaveController.php
View File

@ -93,7 +93,7 @@ class SubscriberSaveController {
(int)$oldSubscriber->getId(), (int)$oldSubscriber->getId(),
StatisticsUnsubscribeEntity::SOURCE_ADMINISTRATOR, StatisticsUnsubscribeEntity::SOURCE_ADMINISTRATOR,
null, null,
$currentUser->display_name // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $currentUser->display_name // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
); );
} }

4
lib/Subscription/Comment.php
View File

@ -101,8 +101,8 @@ class Comment {
$result = $this->subscriberActions->subscribe( $result = $this->subscriberActions->subscribe(
[ [
'email' => $comment->comment_author_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $comment->comment_author_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'first_name' => $comment->comment_author, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'first_name' => $comment->comment_author, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
], ],
$segmentIds $segmentIds
); );

2
lib/Subscription/ManageSubscriptionFormRenderer.php
View File

@ -112,7 +112,7 @@ class ManageSubscriptionFormRenderer {
if ($subscriber->isWPUser() || $subscriber->isWooCommerceUser()) { if ($subscriber->isWPUser() || $subscriber->isWooCommerceUser()) {
$wpCurrentUser = $this->wp->wpGetCurrentUser(); $wpCurrentUser = $this->wp->wpGetCurrentUser();
if ($wpCurrentUser->user_email === $subscriber->email) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if ($wpCurrentUser->user_email === $subscriber->email) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$templateData['editEmailInfo'] = Helpers::replaceLinkTags( $templateData['editEmailInfo'] = Helpers::replaceLinkTags(
__('[link]Edit your profile[/link] to update your email.', 'mailpoet'), __('[link]Edit your profile[/link] to update your email.', 'mailpoet'),
$this->wp->getEditProfileUrl(), $this->wp->getEditProfileUrl(),

2
lib/Subscription/Pages.php
View File

@ -214,7 +214,7 @@ class Pages {
global $post; global $post;
if ( if (
($post->post_title !== $this->wp->__('MailPoet Page', 'mailpoet')) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps ($post->post_title !== $this->wp->__('MailPoet Page', 'mailpoet')) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
|| ||
($pageTitle !== $this->wp->singlePostTitle('', false)) ($pageTitle !== $this->wp->singlePostTitle('', false))
) { ) {

30
lib/Util/ConflictResolver.php
View File

@ -84,12 +84,12 @@ class ConflictResolver {
$_this->permittedAssetsLocations['styles'] = WPFunctions::get()->applyFilters('mailpoet_conflict_resolver_whitelist_style', $_this->permittedAssetsLocations['styles']); $_this->permittedAssetsLocations['styles'] = WPFunctions::get()->applyFilters('mailpoet_conflict_resolver_whitelist_style', $_this->permittedAssetsLocations['styles']);
// unload all styles except from the list of allowed // unload all styles except from the list of allowed
$dequeueStyles = function() use($_this) { $dequeueStyles = function() use($_this) {
global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!isset($wp_styles->registered)) return; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (!isset($wp_styles->registered)) return; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (empty($wp_styles->queue)) return; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($wp_styles->queue)) return; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
foreach ($wp_styles->queue as $wpStyle) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps foreach ($wp_styles->queue as $wpStyle) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (empty($wp_styles->registered[$wpStyle])) continue; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($wp_styles->registered[$wpStyle])) continue; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$registeredStyle = $wp_styles->registered[$wpStyle]; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $registeredStyle = $wp_styles->registered[$wpStyle]; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!is_string($registeredStyle->src)) { if (!is_string($registeredStyle->src)) {
continue; continue;
} }
@ -115,10 +115,10 @@ class ConflictResolver {
$_this->permittedAssetsLocations['scripts'] = WPFunctions::get()->applyFilters('mailpoet_conflict_resolver_whitelist_script', $_this->permittedAssetsLocations['scripts']); $_this->permittedAssetsLocations['scripts'] = WPFunctions::get()->applyFilters('mailpoet_conflict_resolver_whitelist_script', $_this->permittedAssetsLocations['scripts']);
// unload all scripts except from the list of allowed // unload all scripts except from the list of allowed
$dequeueScripts = function() use($_this) { $dequeueScripts = function() use($_this) {
global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
foreach ($wp_scripts->queue as $wpScript) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps foreach ($wp_scripts->queue as $wpScript) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (empty($wp_scripts->registered[$wpScript])) continue; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($wp_scripts->registered[$wpScript])) continue; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$registeredScript = $wp_scripts->registered[$wpScript]; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $registeredScript = $wp_scripts->registered[$wpScript]; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (!is_string($registeredScript->src)) { if (!is_string($registeredScript->src)) {
continue; continue;
} }
@ -143,8 +143,8 @@ class ConflictResolver {
// mark editor as already enqueued to prevent loading its assets // mark editor as already enqueued to prevent loading its assets
// when wp_enqueue_editor() used by some other plugin // when wp_enqueue_editor() used by some other plugin
global $wp_actions; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_actions; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$wp_actions['wp_enqueue_editor'] = 1; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wp_actions['wp_enqueue_editor'] = 1; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// prevent editor loading when used wp_editor() used by some other plugin // prevent editor loading when used wp_editor() used by some other plugin
WPFunctions::get()->addFilter('wp_editor_settings', function () { WPFunctions::get()->addFilter('wp_editor_settings', function () {
@ -177,12 +177,12 @@ class ConflictResolver {
]; ];
$disableWpTinymce = function() use ($tinyMceFooterScriptHooks) { $disableWpTinymce = function() use ($tinyMceFooterScriptHooks) {
global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$actionName = 'admin_print_footer_scripts'; $actionName = 'admin_print_footer_scripts';
if (!isset($wp_filter[$actionName])) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (!isset($wp_filter[$actionName])) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return; return;
} }
foreach ($wp_filter[$actionName]->callbacks as $priority => $callbacks) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps foreach ($wp_filter[$actionName]->callbacks as $priority => $callbacks) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
foreach ($tinyMceFooterScriptHooks as $hook) { foreach ($tinyMceFooterScriptHooks as $hook) {
if (isset($callbacks[$hook])) { if (isset($callbacks[$hook])) {
WPFunctions::get()->removeAction($actionName, $callbacks[$hook]['function'], $priority); WPFunctions::get()->removeAction($actionName, $callbacks[$hook]['function'], $priority);

6
lib/Util/Notices/DeprecatedShortcodeNotice.php
View File

@ -28,10 +28,10 @@ class DeprecatedShortcodeNotice {
} }
public function isUsingDeprecatedShortcode() { public function isUsingDeprecatedShortcode() {
global $wp_filter;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$hook = 'mailpoet_newsletter_shortcode'; $hook = 'mailpoet_newsletter_shortcode';
if (empty($wp_filter[$hook])) return false;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps if (empty($wp_filter[$hook])) return false;// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$callbacks = $wp_filter[$hook];// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $callbacks = $wp_filter[$hook];// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (empty($callbacks->callbacks) || !is_array($callbacks->callbacks)) return false; if (empty($callbacks->callbacks) || !is_array($callbacks->callbacks)) return false;
foreach ($callbacks->callbacks as $callbackByPriority) { foreach ($callbacks->callbacks as $callbackByPriority) {
if (empty($callbackByPriority) || !is_array($callbackByPriority)) continue; if (empty($callbackByPriority) || !is_array($callbackByPriority)) continue;

4
lib/WP/AutocompletePostListLoader.php
View File

@ -67,7 +67,7 @@ class AutocompletePostListLoader {
foreach ($posts as $post) { foreach ($posts as $post) {
$result[] = [ $result[] = [
'id' => (string)$post->ID, 'id' => (string)$post->ID,
'name' => $post->post_title,// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'name' => $post->post_title,// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
]; ];
} }
return $result; return $result;
@ -79,7 +79,7 @@ class AutocompletePostListLoader {
$result = []; $result = [];
foreach ($terms as $term) { foreach ($terms as $term) {
$result[] = [ $result[] = [
'id' => (string)$term->term_id,// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'id' => (string)$term->term_id,// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'name' => $term->name, 'name' => $term->name,
]; ];
} }

2
tasks/code_sniffer/MailPoet/ruleset.xml
View File

@ -198,7 +198,7 @@
<rule ref="Squiz.Scope.MethodScope"/> <rule ref="Squiz.Scope.MethodScope"/>
<!-- Enforce camelCase naming of variables and properties --> <!-- Enforce camelCase naming of variables and properties -->
<rule ref="Squiz.NamingConventions.ValidVariableName.NotCamelCaps"/> <rule ref="Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps"/>
<rule ref="Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps"/> <rule ref="Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps"/>
<rule ref="Squiz.NamingConventions.ValidVariableName.StringNotCamelCaps"/> <rule ref="Squiz.NamingConventions.ValidVariableName.StringNotCamelCaps"/>
</ruleset> </ruleset>

4
tests/DataGenerator/Generators/WooCommercePastRevenues.php
View File

@ -61,7 +61,7 @@ class WooCommercePastRevenues implements Generator {
$productCategory = $this->createProductCategory('WC Revenues Test Category ' . $this->getRandomString(), 'revenues-test-cat-' . $this->getRandomString()); $productCategory = $this->createProductCategory('WC Revenues Test Category ' . $this->getRandomString(), 'revenues-test-cat-' . $this->getRandomString());
$products = []; $products = [];
for ($i = 1; $i <= self::PRODUCTS_COUNT; $i++) { for ($i = 1; $i <= self::PRODUCTS_COUNT; $i++) {
$products[] = $this->createProduct("Product $i " . $this->getRandomString(), 100, [$productCategory->term_id]); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $products[] = $this->createProduct("Product $i " . $this->getRandomString(), 100, [$productCategory->term_id]); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
yield "Products done"; yield "Products done";
@ -155,7 +155,7 @@ class WooCommercePastRevenues implements Generator {
'id' => $products[$i]->get_name(), 'id' => $products[$i]->get_name(),
'name' => $products[$i]->get_id(), 'name' => $products[$i]->get_id(),
'categories' => [[ 'categories' => [[
'id' => $productCategory->term_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'id' => $productCategory->term_id, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'name' => $productCategory->name, 'name' => $productCategory->name,
]], ]],
]; ];

8
tests/_support/DefaultsExtension.php
View File

@ -46,9 +46,9 @@ class DefaultsExtension extends Extension {
// get rid of 'blog/' prefix that is added automatically to rewrite rules on multisite by default // get rid of 'blog/' prefix that is added automatically to rewrite rules on multisite by default
// (init() loads 'permalink_structure' option from DB, flush_rules() regenerates 'rewrite_rules') // (init() loads 'permalink_structure' option from DB, flush_rules() regenerates 'rewrite_rules')
global $wp_rewrite; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_rewrite; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$wp_rewrite->init(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wp_rewrite->init(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$wp_rewrite->flush_rules(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $wp_rewrite->flush_rules(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
private function setupWooCommerce() { private function setupWooCommerce() {
@ -93,7 +93,7 @@ class DefaultsExtension extends Extension {
delete_transient('_wc_activation_redirect'); delete_transient('_wc_activation_redirect');
// mark all WC cron actions complete // mark all WC cron actions complete
$tableName = ! empty($wpdb->actionscheduler_actions) ? $wpdb->actionscheduler_actions : $wpdb->prefix . 'actionscheduler_actions';// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $tableName = ! empty($wpdb->actionscheduler_actions) ? $wpdb->actionscheduler_actions : $wpdb->prefix . 'actionscheduler_actions';// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$sql = "UPDATE {$tableName} SET status = 'complete'"; $sql = "UPDATE {$tableName} SET status = 'complete'";
$wpdb->query($sql); $wpdb->query($sql);
} }

2
tests/integration/API/JSON/v1/AutomatedLatestContentTest.php
View File

@ -23,7 +23,7 @@ class AutomatedLatestContentTest extends \MailPoetTest {
// https://codex.wordpress.org/Post_Types // https://codex.wordpress.org/Post_Types
$revisionPostType = get_post_type_object('revision'); $revisionPostType = get_post_type_object('revision');
assert($revisionPostType instanceof \WP_Post_Type); assert($revisionPostType instanceof \WP_Post_Type);
expect($revisionPostType->exclude_from_search)->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($revisionPostType->exclude_from_search)->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(isset($response->data['revision']))->false(); expect(isset($response->data['revision']))->false();
} }
} }

4
tests/integration/Config/InitializerTest.php
View File

@ -4,10 +4,10 @@ namespace MailPoet\Test\Config;
class InitializerTest extends \MailPoetTest { class InitializerTest extends \MailPoetTest {
public function testItConfiguresHooks() { public function testItConfiguresHooks() {
global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$isHooked = false; $isHooked = false;
// mailpoet should hook to 'wp_loaded' with priority of 10 // mailpoet should hook to 'wp_loaded' with priority of 10
foreach ($wp_filter['wp_loaded'][10] as $name => $hook) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps foreach ($wp_filter['wp_loaded'][10] as $name => $hook) { // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
if (preg_match('/postInitialize/', $name)) $isHooked = true; if (preg_match('/postInitialize/', $name)) $isHooked = true;
} }
expect($isHooked)->true(); expect($isHooked)->true();

12
tests/integration/Config/InstallerTest.php
View File

@ -46,18 +46,18 @@ class InstallerTest extends \MailPoetTest {
$obj = new \stdClass(); $obj = new \stdClass();
$obj->slug = $this->slug; $obj->slug = $this->slug;
$obj->name = 'MailPoet Premium'; $obj->name = 'MailPoet Premium';
$obj->new_version = '3.0.0-alpha.0.0.3.1'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $obj->new_version = '3.0.0-alpha.0.0.3.1'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$obj->requires = '4.6'; $obj->requires = '4.6';
$obj->tested = '4.7.4'; $obj->tested = '4.7.4';
$obj->downloaded = 12540; $obj->downloaded = 12540;
$obj->last_updated = date('Y-m-d'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $obj->last_updated = date('Y-m-d'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$obj->sections = [ $obj->sections = [
'description' => 'The new version of the Premium plugin', 'description' => 'The new version of the Premium plugin',
'another_section' => 'This is another section', 'another_section' => 'This is another section',
'changelog' => 'Some new features', 'changelog' => 'Some new features',
]; ];
$obj->download_link = home_url() . '/wp-content/uploads/mailpoet-premium.zip'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $obj->download_link = home_url() . '/wp-content/uploads/mailpoet-premium.zip'; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$obj->package = $obj->download_link; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $obj->package = $obj->download_link; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return $obj; return $obj;
}, },
], ],
@ -65,8 +65,8 @@ class InstallerTest extends \MailPoetTest {
); );
$result = $installer->getPluginInformation(false, 'plugin_information', $args); $result = $installer->getPluginInformation(false, 'plugin_information', $args);
expect($result->slug)->equals($this->slug); expect($result->slug)->equals($this->slug);
expect($result->new_version)->notEmpty(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($result->new_version)->notEmpty(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($result->download_link)->notEmpty(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($result->download_link)->notEmpty(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($result->package)->notEmpty(); expect($result->package)->notEmpty();
} }

10
tests/integration/Config/MP2MigratorTest.php
View File

@ -64,7 +64,7 @@ class MP2MigratorTest extends \MailPoetTest {
// Check if the subscribers number is equal to the WordPress users number // Check if the subscribers number is equal to the WordPress users number
// On multisite environment, there's only 1 users table that's shared by subsites // On multisite environment, there's only 1 users table that's shared by subsites
$WPUsersCount = ORM::for_table($wpdb->base_prefix . 'users')->count(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $WPUsersCount = ORM::for_table($wpdb->base_prefix . 'users')->count(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(Subscriber::count())->equals($WPUsersCount); expect(Subscriber::count())->equals($WPUsersCount);
// Check if the custom fields number is 0 // Check if the custom fields number is 0
@ -310,10 +310,10 @@ class MP2MigratorTest extends \MailPoetTest {
$table = MP_SUBSCRIBERS_TABLE; $table = MP_SUBSCRIBERS_TABLE;
$subscriber = $wpdb->get_row("SELECT * FROM $table WHERE email='$email'"); $subscriber = $wpdb->get_row("SELECT * FROM $table WHERE email='$email'");
expect($subscriber->email)->equals($email); expect($subscriber->email)->equals($email);
expect($subscriber->first_name)->equals($firstname); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->first_name)->equals($firstname); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->last_name)->equals($lastname); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->last_name)->equals($lastname); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->subscribed_ip)->equals($ip); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->subscribed_ip)->equals($ip); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->confirmed_ip)->equals($confirmedIp); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->confirmed_ip)->equals($confirmedIp); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->status)->equals('subscribed'); expect($subscriber->status)->equals('subscribed');
} }

10
tests/integration/Config/ShortcodesTest.php
View File

@ -69,7 +69,7 @@ class ShortcodesTest extends \MailPoetTest {
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -86,7 +86,7 @@ class ShortcodesTest extends \MailPoetTest {
expect($wp->isUserLoggedIn())->true(); expect($wp->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -105,7 +105,7 @@ class ShortcodesTest extends \MailPoetTest {
public function testItDoesNotDisplayManageSubscriptionFormForLoggedinNonexistentSubscribers() { public function testItDoesNotDisplayManageSubscriptionFormForLoggedinNonexistentSubscribers() {
$wpUser = wp_set_current_user(1); $wpUser = wp_set_current_user(1);
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
expect(Subscriber::findOne($wpUser->user_email))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(Subscriber::findOne($wpUser->user_email))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class); $shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class);
$shortcodes->init(); $shortcodes->init();
@ -128,7 +128,7 @@ class ShortcodesTest extends \MailPoetTest {
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
$subscriber = Subscriber::create(); $subscriber = Subscriber::create();
$subscriber->hydrate(Fixtures::get('subscriber_template')); $subscriber->hydrate(Fixtures::get('subscriber_template'));
$subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber->email = $wpUser->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$subscriber->wpUserId = $wpUser->ID; $subscriber->wpUserId = $wpUser->ID;
$subscriber->save(); $subscriber->save();
@ -141,7 +141,7 @@ class ShortcodesTest extends \MailPoetTest {
public function testItDoesNotDisplayLinkToManageSubscriptionPageForLoggedinNonexistentSubscribers() { public function testItDoesNotDisplayLinkToManageSubscriptionPageForLoggedinNonexistentSubscribers() {
$wpUser = wp_set_current_user(1); $wpUser = wp_set_current_user(1);
expect((new WPFunctions)->isUserLoggedIn())->true(); expect((new WPFunctions)->isUserLoggedIn())->true();
expect(Subscriber::findOne($wpUser->user_email))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(Subscriber::findOne($wpUser->user_email))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class); $shortcodes = ContainerWrapper::getInstance()->get(Shortcodes::class);
$shortcodes->init(); $shortcodes->init();

4
tests/integration/Config/UpdaterTest.php
View File

@ -39,7 +39,7 @@ class UpdaterTest extends \MailPoetTest {
public function testItChecksForUpdates() { public function testItChecksForUpdates() {
$updateTransient = new \stdClass; $updateTransient = new \stdClass;
$updateTransient->last_checked = time(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $updateTransient->last_checked = time(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$updater = Stub::construct( $updater = Stub::construct(
$this->updater, $this->updater,
[ [
@ -62,7 +62,7 @@ class UpdaterTest extends \MailPoetTest {
$this $this
); );
$result = $updater->checkForUpdate($updateTransient); $result = $updater->checkForUpdate($updateTransient);
expect($result->last_checked)->greaterOrEquals($updateTransient->last_checked); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($result->last_checked)->greaterOrEquals($updateTransient->last_checked); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($result->checked[$this->pluginName])->equals($this->version); expect($result->checked[$this->pluginName])->equals($this->version);
expect($result->response[$this->pluginName]->slug)->equals($this->slug); expect($result->response[$this->pluginName]->slug)->equals($this->slug);
expect($result->response[$this->pluginName]->plugin)->equals($this->pluginName); expect($result->response[$this->pluginName]->plugin)->equals($this->pluginName);

2
tests/integration/Cron/Workers/SendingQueue/Tasks/ShortcodesTest.php
View File

@ -52,7 +52,7 @@ class ShortcodesTest extends \MailPoetTest {
expect(trim(Shortcodes::process($content)))->equals('Subject line with one shortcode:'); expect(trim(Shortcodes::process($content)))->equals('Subject line with one shortcode:');
// when tag is found, the shortcode will be processed and replaced // when tag is found, the shortcode will be processed and replaced
expect(Shortcodes::process($content, $contentSource))->equals('Subject line with one shortcode: ' . $wpPost->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(Shortcodes::process($content, $contentSource))->equals('Subject line with one shortcode: ' . $wpPost->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function _after() { public function _after() {

22
tests/integration/Mailer/Methods/PHPMailTest.php
View File

@ -54,7 +54,7 @@ class PHPMailTest extends \MailPoetTest {
expect($mailer)->isInstanceOf('PHPMailer'); expect($mailer)->isInstanceOf('PHPMailer');
// uses PHP's mail() function // uses PHP's mail() function
expect($mailer->Mailer)->equals('mail'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->Mailer)->equals('mail'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testWhenReturnPathIsNullItIsSetToSenderEmail() { public function testWhenReturnPathIsNullItIsSetToSenderEmail() {
@ -70,7 +70,7 @@ class PHPMailTest extends \MailPoetTest {
public function testItCanConfigureMailerWithMessage() { public function testItCanConfigureMailerWithMessage() {
$mailer = $this->mailer $mailer = $this->mailer
->configureMailerWithMessage($this->newsletter, $this->subscriber, $this->extraParams); ->configureMailerWithMessage($this->newsletter, $this->subscriber, $this->extraParams);
expect($mailer->CharSet)->equals('UTF-8'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->CharSet)->equals('UTF-8'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->getToAddresses())->equals( expect($mailer->getToAddresses())->equals(
[ [
[ [
@ -81,8 +81,8 @@ class PHPMailTest extends \MailPoetTest {
); );
expect($mailer->getAllRecipientAddresses()) expect($mailer->getAllRecipientAddresses())
->equals(['mailpoet-phoenix-test@mailinator.com' => true]); ->equals(['mailpoet-phoenix-test@mailinator.com' => true]);
expect($mailer->From)->equals($this->sender['from_email']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->From)->equals($this->sender['from_email']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->FromName)->equals($this->sender['from_name']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->FromName)->equals($this->sender['from_name']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->getReplyToAddresses())->equals( expect($mailer->getReplyToAddresses())->equals(
[ [
'reply-to@mailpoet.com' => [ 'reply-to@mailpoet.com' => [
@ -91,12 +91,12 @@ class PHPMailTest extends \MailPoetTest {
], ],
] ]
); );
expect($mailer->Sender)->equals($this->returnPath); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->Sender)->equals($this->returnPath); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->ContentType)->equals('text/html'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->ContentType)->equals('text/html'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->Subject)->equals($this->newsletter['subject']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->Subject)->equals($this->newsletter['subject']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->Body) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->Body) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
->equals($this->newsletter['body']['html']); ->equals($this->newsletter['body']['html']);
expect($mailer->AltBody) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->AltBody) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
->equals($this->newsletter['body']['text']); ->equals($this->newsletter['body']['text']);
expect($mailer->getCustomHeaders())->equals( expect($mailer->getCustomHeaders())->equals(
[ [
@ -116,8 +116,8 @@ class PHPMailTest extends \MailPoetTest {
'text' => 'TEXT body', 'text' => 'TEXT body',
], ],
], $this->subscriber); ], $this->subscriber);
expect($mailer->ContentType)->equals('text/plain'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->ContentType)->equals('text/plain'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($mailer->Body)->equals('TEXT body'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($mailer->Body)->equals('TEXT body'); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testItCanProcessSubscriber() { public function testItCanProcessSubscriber() {

2
tests/integration/Mailer/WordPress/WordpressMailerTest.php
View File

@ -8,7 +8,7 @@ use MailPoet\Mailer\MailerError;
use MailPoet\Mailer\MetaInfo; use MailPoet\Mailer\MetaInfo;
use MailPoet\Subscribers\SubscribersRepository; use MailPoet\Subscribers\SubscribersRepository;
// phpcs:disable Squiz.NamingConventions.ValidVariableName.NotCamelCaps // phpcs:disable Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
class WordpressMailerTest extends \MailPoetTest { class WordpressMailerTest extends \MailPoetTest {
/** @var SubscribersRepository */ /** @var SubscribersRepository */
private $subscribersRepository; private $subscribersRepository;

2
tests/integration/Newsletter/ShortcodesTest.php
View File

@ -159,7 +159,7 @@ class ShortcodesTest extends \MailPoetTest {
$shortcodesObject->process(['[newsletter:post_title]'], $content); $shortcodesObject->process(['[newsletter:post_title]'], $content);
$wpPost = get_post($this->wPPost); $wpPost = get_post($this->wPPost);
assert($wpPost instanceof WP_Post); assert($wpPost instanceof WP_Post);
expect($result['0'])->equals($wpPost->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($result['0'])->equals($wpPost->post_title); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function itCanProcessPostNotificationNewsletterNumberShortcode() { public function itCanProcessPostNotificationNewsletterNumberShortcode() {

34
tests/integration/Segments/WooCommerceTest.php
View File

@ -46,7 +46,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber->hydrate([ $subscriber->hydrate([
'first_name' => 'Mike', 'first_name' => 'Mike',
'last_name' => 'Mike', 'last_name' => 'Mike',
'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'wp_user_id' => $user->ID, 'wp_user_id' => $user->ID,
]); ]);
$subscriber->status = Subscriber::STATUS_SUBSCRIBED; $subscriber->status = Subscriber::STATUS_SUBSCRIBED;
@ -59,7 +59,7 @@ class WooCommerceTest extends \MailPoetTest {
->where('wp_user_id', $user->ID) ->where('wp_user_id', $user->ID)
->findOne(); ->findOne();
expect($subscriber)->notEmpty(); expect($subscriber)->notEmpty();
expect($subscriber->email)->equals($user->user_email); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->email)->equals($user->user_email); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->firstName)->equals($firstName); expect($subscriber->firstName)->equals($firstName);
expect($subscriber->lastName)->equals($lastName); expect($subscriber->lastName)->equals($lastName);
expect($subscriber->isWoocommerceUser)->equals(1); expect($subscriber->isWoocommerceUser)->equals(1);
@ -75,7 +75,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber->hydrate([ $subscriber->hydrate([
'first_name' => 'Mike', 'first_name' => 'Mike',
'last_name' => 'Mike', 'last_name' => 'Mike',
'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'wp_user_id' => $user->ID, 'wp_user_id' => $user->ID,
]); ]);
$subscriber->status = Subscriber::STATUS_UNSUBSCRIBED; $subscriber->status = Subscriber::STATUS_UNSUBSCRIBED;
@ -87,7 +87,7 @@ class WooCommerceTest extends \MailPoetTest {
->where('wp_user_id', $user->ID) ->where('wp_user_id', $user->ID)
->findOne(); ->findOne();
expect($subscriber)->notEmpty(); expect($subscriber)->notEmpty();
expect($subscriber->email)->equals($user->user_email); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->email)->equals($user->user_email); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->firstName)->equals($firstName); expect($subscriber->firstName)->equals($firstName);
expect($subscriber->lastName)->equals($lastName); expect($subscriber->lastName)->equals($lastName);
expect($subscriber->isWoocommerceUser)->equals(1); expect($subscriber->isWoocommerceUser)->equals(1);
@ -102,7 +102,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber->hydrate([ $subscriber->hydrate([
'first_name' => 'Mike', 'first_name' => 'Mike',
'last_name' => 'Mike', 'last_name' => 'Mike',
'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'wp_user_id' => $user->ID, 'wp_user_id' => $user->ID,
]); ]);
$subscriber->status = Subscriber::STATUS_UNSUBSCRIBED; $subscriber->status = Subscriber::STATUS_UNSUBSCRIBED;
@ -158,7 +158,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscribersCount = $this->getSubscribersCount(); $subscribersCount = $this->getSubscribersCount();
expect($subscribersCount)->equals(2); expect($subscribersCount)->equals(2);
$subscriber = Subscriber::where('email', $user->user_email)->findOne(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber = Subscriber::where('email', $user->user_email)->findOne(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect($subscriber->status)->equals(Subscriber::STATUS_UNCONFIRMED); expect($subscriber->status)->equals(Subscriber::STATUS_UNCONFIRMED);
expect($subscriber->source)->equals(Source::WOOCOMMERCE_USER); expect($subscriber->source)->equals(Source::WOOCOMMERCE_USER);
$subscriber = Subscriber::where('email', $guest['email'])->findOne(); $subscriber = Subscriber::where('email', $guest['email'])->findOne();
@ -234,7 +234,7 @@ class WooCommerceTest extends \MailPoetTest {
$user = $this->insertRegisteredCustomerWithOrder(null, ['first_name' => '']); $user = $this->insertRegisteredCustomerWithOrder(null, ['first_name' => '']);
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
update_post_meta($user->orderId, '_billing_first_name', 'First name'); update_post_meta($user->orderId, '_billing_first_name', 'First name');
$this->createOrder(['email' => $user->user_email, 'first_name' => 'First name (newer)']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->createOrder(['email' => $user->user_email, 'first_name' => 'First name (newer)']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where('wp_user_id', $user->ID)->findOne(); $subscriber = Subscriber::where('wp_user_id', $user->ID)->findOne();
expect($subscriber->firstName)->equals('First name (newer)'); expect($subscriber->firstName)->equals('First name (newer)');
@ -244,7 +244,7 @@ class WooCommerceTest extends \MailPoetTest {
$user = $this->insertRegisteredCustomerWithOrder(null, ['last_name' => '']); $user = $this->insertRegisteredCustomerWithOrder(null, ['last_name' => '']);
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
update_post_meta($user->orderId, '_billing_last_name', 'Last name'); update_post_meta($user->orderId, '_billing_last_name', 'Last name');
$this->createOrder(['email' => $user->user_email, 'last_name' => 'Last name (newer)']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->createOrder(['email' => $user->user_email, 'last_name' => 'Last name (newer)']); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where('wp_user_id', $user->ID)->findOne(); $subscriber = Subscriber::where('wp_user_id', $user->ID)->findOne();
expect($subscriber->lastName)->equals('Last name (newer)'); expect($subscriber->lastName)->equals('Last name (newer)');
@ -285,13 +285,13 @@ class WooCommerceTest extends \MailPoetTest {
public function testItDoesntRemoveRegisteredCustomersFromTrash() { public function testItDoesntRemoveRegisteredCustomersFromTrash() {
$user = $this->insertRegisteredCustomer(); $user = $this->insertRegisteredCustomer();
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
->where('is_woocommerce_user', 1) ->where('is_woocommerce_user', 1)
->findOne(); ->findOne();
$subscriber->deletedAt = Carbon::now(); $subscriber->deletedAt = Carbon::now();
$subscriber->save(); $subscriber->save();
$this->woocommerceSegment->synchronizeCustomers(); $this->woocommerceSegment->synchronizeCustomers();
$subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $subscriber = Subscriber::where("email", $user->user_email) // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
->where('is_woocommerce_user', 1) ->where('is_woocommerce_user', 1)
->findOne(); ->findOne();
expect($subscriber->deletedAt)->notNull(); expect($subscriber->deletedAt)->notNull();
@ -338,7 +338,7 @@ class WooCommerceTest extends \MailPoetTest {
$subscriber->hydrate([ $subscriber->hydrate([
'first_name' => 'John', 'first_name' => 'John',
'last_name' => 'John', 'last_name' => 'John',
'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'wp_user_id' => $user->ID, 'wp_user_id' => $user->ID,
]); ]);
$subscriber->status = Subscriber::STATUS_UNCONFIRMED; $subscriber->status = Subscriber::STATUS_UNCONFIRMED;
@ -464,7 +464,7 @@ class WooCommerceTest extends \MailPoetTest {
$user2 = $this->insertRegisteredCustomer(); $user2 = $this->insertRegisteredCustomer();
$subscriber1 = Subscriber::createOrUpdate([ $subscriber1 = Subscriber::createOrUpdate([
'email' => $user1->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user1->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'is_woocommerce_user' => 1, 'is_woocommerce_user' => 1,
'status' => Subscriber::STATUS_UNSUBSCRIBED, 'status' => Subscriber::STATUS_UNSUBSCRIBED,
]); ]);
@ -475,7 +475,7 @@ class WooCommerceTest extends \MailPoetTest {
$association1->save(); $association1->save();
$subscriber2 = Subscriber::createOrUpdate([ $subscriber2 = Subscriber::createOrUpdate([
'email' => $user2->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user2->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'is_woocommerce_user' => 1, 'is_woocommerce_user' => 1,
'status' => Subscriber::STATUS_UNSUBSCRIBED, 'status' => Subscriber::STATUS_UNSUBSCRIBED,
'confirmed_ip' => '123', 'confirmed_ip' => '123',
@ -508,7 +508,7 @@ class WooCommerceTest extends \MailPoetTest {
$user2 = $this->insertRegisteredCustomer(); $user2 = $this->insertRegisteredCustomer();
$subscriber1 = Subscriber::createOrUpdate([ $subscriber1 = Subscriber::createOrUpdate([
'email' => $user1->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user1->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'is_woocommerce_user' => 1, 'is_woocommerce_user' => 1,
'status' => Subscriber::STATUS_SUBSCRIBED, 'status' => Subscriber::STATUS_SUBSCRIBED,
]); ]);
@ -519,7 +519,7 @@ class WooCommerceTest extends \MailPoetTest {
$association1->save(); $association1->save();
$subscriber2 = Subscriber::createOrUpdate([ $subscriber2 = Subscriber::createOrUpdate([
'email' => $user2->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps 'email' => $user2->user_email, // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
'is_woocommerce_user' => 1, 'is_woocommerce_user' => 1,
'status' => Subscriber::STATUS_SUBSCRIBED, 'status' => Subscriber::STATUS_SUBSCRIBED,
'confirmed_ip' => '123', 'confirmed_ip' => '123',
@ -673,7 +673,7 @@ class WooCommerceTest extends \MailPoetTest {
// add customer role // add customer role
$user = new WPUserWithExtraProps($id); $user = new WPUserWithExtraProps($id);
$user->add_role('customer'); $user->add_role('customer');
$this->userEmails[] = $user->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->userEmails[] = $user->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
return $user; return $user;
} }
@ -697,7 +697,7 @@ class WooCommerceTest extends \MailPoetTest {
$number = !is_null($number) ? (int)$number : mt_rand(); $number = !is_null($number) ? (int)$number : mt_rand();
$data = is_array($data) ? $data : []; $data = is_array($data) ? $data : [];
$user = $this->insertRegisteredCustomer($number, $data['first_name'] ?? null, $data['last_name'] ?? null); $user = $this->insertRegisteredCustomer($number, $data['first_name'] ?? null, $data['last_name'] ?? null);
$data['email'] = $user->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $data['email'] = $user->user_email; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$data['user_id'] = $user->ID; $data['user_id'] = $user->ID;
$user->orderId = $this->createOrder($data); $user->orderId = $this->createOrder($data);
return $user; return $user;

26
tests/integration/Util/ConflictResolverTest.php
View File

@ -13,8 +13,8 @@ class ConflictResolverTest extends \MailPoetTest {
parent::__construct(); parent::__construct();
$this->conflictResolver = new ConflictResolver(); $this->conflictResolver = new ConflictResolver();
$this->conflictResolver->init(); $this->conflictResolver->init();
global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$this->wpFilter = $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->wpFilter = $wp_filter; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testItResolvesRouterUrlQueryParametersConflict() { public function testItResolvesRouterUrlQueryParametersConflict() {
@ -39,10 +39,10 @@ class ConflictResolverTest extends \MailPoetTest {
do_action('admin_print_styles'); do_action('admin_print_styles');
do_action('admin_print_footer_scripts'); do_action('admin_print_footer_scripts');
do_action('admin_footer'); do_action('admin_footer');
global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// it should dequeue all styles except those found on the list of permitted locations // it should dequeue all styles except those found on the list of permitted locations
expect(in_array('select2', $wp_styles->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('select2', $wp_styles->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(in_array('permitted_style', $wp_styles->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('permitted_style', $wp_styles->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testItWhitelistsStyles() { public function testItWhitelistsStyles() {
@ -60,9 +60,9 @@ class ConflictResolverTest extends \MailPoetTest {
do_action('admin_print_styles'); do_action('admin_print_styles');
do_action('admin_print_footer_scripts'); do_action('admin_print_footer_scripts');
do_action('admin_footer'); do_action('admin_footer');
global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_styles; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// it should not dequeue select2 style // it should not dequeue select2 style
expect(in_array('select2', $wp_styles->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('select2', $wp_styles->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testItUnloadsAllScriptsFromLocationsNotOnPermittedList() { public function testItUnloadsAllScriptsFromLocationsNotOnPermittedList() {
@ -76,11 +76,11 @@ class ConflictResolverTest extends \MailPoetTest {
$this->conflictResolver->resolveScriptsConflict(); $this->conflictResolver->resolveScriptsConflict();
do_action('wp_print_scripts'); do_action('wp_print_scripts');
do_action('admin_print_footer_scripts'); do_action('admin_print_footer_scripts');
global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// it should dequeue all scripts except those found on the list of permitted locations // it should dequeue all scripts except those found on the list of permitted locations
expect(in_array('select2', $wp_scripts->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('select2', $wp_scripts->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(in_array('some_random_script', $wp_scripts->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('some_random_script', $wp_scripts->queue))->false(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
expect(in_array('permitted_script', $wp_scripts->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('permitted_script', $wp_scripts->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testItWhitelistsScripts() { public function testItWhitelistsScripts() {
@ -96,9 +96,9 @@ class ConflictResolverTest extends \MailPoetTest {
$this->conflictResolver->resolveStylesConflict(); $this->conflictResolver->resolveStylesConflict();
do_action('wp_print_scripts'); do_action('wp_print_scripts');
do_action('admin_print_footer_scripts'); do_action('admin_print_footer_scripts');
global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $wp_scripts; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
// it should not dequeue select2 script // it should not dequeue select2 script
expect(in_array('select2', $wp_scripts->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect(in_array('select2', $wp_scripts->queue))->true(); // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function _after() { public function _after() {

10
tests/integration/WP/FunctionsTest.php
View File

@ -13,9 +13,9 @@ class FunctionsTest extends \MailPoetTest {
public function _before() { public function _before() {
parent::_before(); parent::_before();
global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$this->contentWidth = $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $this->contentWidth = $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$content_width = 150; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $content_width = 150; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$this->action = 'mailpoet_test_action'; $this->action = 'mailpoet_test_action';
$this->filter = 'mailpoet_test_filter'; $this->filter = 'mailpoet_test_filter';
$this->wp = new WPFunctions; $this->wp = new WPFunctions;
@ -94,7 +94,7 @@ class FunctionsTest extends \MailPoetTest {
} }
public function _after() { public function _after() {
global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps global $content_width; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
$content_width = $this->contentWidth; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps $content_width = $this->contentWidth; // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
} }

4
tests/unit/Entities/SubscriberEntityTest.php
View File

@ -6,11 +6,11 @@ class SubscriberEntityTest extends \MailPoetUnitTest {
public function testMagicGetterReturnsData() { public function testMagicGetterReturnsData() {
$subscriber = new SubscriberEntity(); $subscriber = new SubscriberEntity();
$subscriber->setWpUserId(4); $subscriber->setWpUserId(4);
expect($subscriber->wp_user_id)->equals(4);// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->wp_user_id)->equals(4);// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
public function testMagicGetterReturnsNullForUnknown() { public function testMagicGetterReturnsNullForUnknown() {
$subscriber = new SubscriberEntity(); $subscriber = new SubscriberEntity();
expect($subscriber->non_existing_property)->null();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.NotCamelCaps expect($subscriber->non_existing_property)->null();// phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
} }
} }