Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace calls to assert() with Assert::assertInstanceOf()

Browse Source 
Doing this as it was mentioned in the review process of the PR.

For more context see: https://wp.me/pcNwfB-wR

[MAILPOET-4363]
This commit is contained in:
Rodrigo Primo
2022-09-19 11:45:58 -03:00
committed by Aschepikov
parent d79cecbef2
commit 686ee18d16
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/tests/integration/Cron/Workers/SendingQueue/Tasks/LinksTest.php
View File

@@ -43,7 +43,7 @@ class LinksTest extends \MailPoetTest {
$this->links->saveLinks($links, $this->newsletter, $queue);
$newsletterLink = $this->newsletterLinkRepository->findOneBy(['hash' => $links[0]['hash']]);
assert($newsletterLink instanceof NewsletterLinkEntity);
$this->assertInstanceOf(NewsletterLinkEntity::class, $newsletterLink);
$this->assertInstanceOf(NewsletterEntity::class, $newsletterLink->getNewsletter());
expect($newsletterLink->getNewsletter()->getId())->equals($this->newsletter->getId());
$this->assertInstanceOf(SendingQueueEntity::class, $newsletterLink->getQueue());
@@ -75,7 +75,7 @@ class LinksTest extends \MailPoetTest {
$result = $this->links->process($renderedNewsletter, $this->newsletter, $this->queue);
$newsletterLink = $this->newsletterLinkRepository->findOneBy(['newsletter' => $this->newsletter->getId()]);
assert($newsletterLink instanceof NewsletterLinkEntity);
$this->assertInstanceOf(NewsletterLinkEntity::class, $newsletterLink);
expect($result['html'])->stringContainsString($newsletterLink->getHash());
}