Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Replace calls to assert() with Assert::assertInstanceOf()

Browse Source 
Doing this as it was mentioned in the review process of the PR.

For more context see: https://wp.me/pcNwfB-wR

[MAILPOET-4363]
This commit is contained in:
Rodrigo Primo
2022-09-19 11:45:58 -03:00
committed by Aschepikov
parent d79cecbef2
commit 686ee18d16
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/tests/integration/Cron/Workers/SendingQueue/Tasks/LinksTest.php
View File

@@ -43,7 +43,7 @@ class LinksTest extends \MailPoetTest {
$this->links->saveLinks($links, $this->newsletter, $queue); $this->links->saveLinks($links, $this->newsletter, $queue);
$newsletterLink = $this->newsletterLinkRepository->findOneBy(['hash' => $links[0]['hash']]); $newsletterLink = $this->newsletterLinkRepository->findOneBy(['hash' => $links[0]['hash']]);
assert($newsletterLink instanceof NewsletterLinkEntity); $this->assertInstanceOf(NewsletterLinkEntity::class, $newsletterLink);
$this->assertInstanceOf(NewsletterEntity::class, $newsletterLink->getNewsletter()); $this->assertInstanceOf(NewsletterEntity::class, $newsletterLink->getNewsletter());
expect($newsletterLink->getNewsletter()->getId())->equals($this->newsletter->getId()); expect($newsletterLink->getNewsletter()->getId())->equals($this->newsletter->getId());
$this->assertInstanceOf(SendingQueueEntity::class, $newsletterLink->getQueue()); $this->assertInstanceOf(SendingQueueEntity::class, $newsletterLink->getQueue());
@@ -75,7 +75,7 @@ class LinksTest extends \MailPoetTest {
$result = $this->links->process($renderedNewsletter, $this->newsletter, $this->queue); $result = $this->links->process($renderedNewsletter, $this->newsletter, $this->queue);
$newsletterLink = $this->newsletterLinkRepository->findOneBy(['newsletter' => $this->newsletter->getId()]); $newsletterLink = $this->newsletterLinkRepository->findOneBy(['newsletter' => $this->newsletter->getId()]);
assert($newsletterLink instanceof NewsletterLinkEntity); $this->assertInstanceOf(NewsletterLinkEntity::class, $newsletterLink);
expect($result['html'])->stringContainsString($newsletterLink->getHash()); expect($result['html'])->stringContainsString($newsletterLink->getHash());
} }

10
mailpoet/tests/integration/Cron/Workers/SendingQueue/Tasks/NewsletterTest.php
View File

@@ -170,7 +170,7 @@ class NewsletterTest extends \MailPoetTest {
$newsletterTask->trackingEnabled = true; $newsletterTask->trackingEnabled = true;
$newsletterTask->preProcessNewsletter($this->newsletter, $this->sendingTask); $newsletterTask->preProcessNewsletter($this->newsletter, $this->sendingTask);
$link = $this->newsletterLinkRepository->findOneBy(['newsletter' => $this->newsletter->id]); $link = $this->newsletterLinkRepository->findOneBy(['newsletter' => $this->newsletter->id]);
assert($link instanceof NewsletterLinkEntity); $this->assertInstanceOf(NewsletterLinkEntity::class, $link);
$updatedQueue = SendingTask::getByNewsletterId($this->newsletter->id); $updatedQueue = SendingTask::getByNewsletterId($this->newsletter->id);
$renderedNewsletter = $updatedQueue->getNewsletterRenderedBody(); $renderedNewsletter = $updatedQueue->getNewsletterRenderedBody();
expect($renderedNewsletter['html']) expect($renderedNewsletter['html'])
@@ -254,7 +254,7 @@ class NewsletterTest extends \MailPoetTest {
$this->newslettersRepository->flush(); $this->newslettersRepository->flush();
$this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask); $this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask);
$updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId()); $updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId());
assert($updatedNewsletter instanceof NewsletterEntity); $this->assertInstanceOf(NewsletterEntity::class, $updatedNewsletter);
expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT); expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT);
$sentAt = $updatedNewsletter->getSentAt(); $sentAt = $updatedNewsletter->getSentAt();
$this->assertInstanceOf(\DateTime::class, $sentAt); $this->assertInstanceOf(\DateTime::class, $sentAt);
@@ -267,7 +267,7 @@ class NewsletterTest extends \MailPoetTest {
$this->newslettersRepository->flush(); $this->newslettersRepository->flush();
$this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask); $this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask);
$updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId()); $updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId());
assert($updatedNewsletter instanceof NewsletterEntity); $this->assertInstanceOf(NewsletterEntity::class, $updatedNewsletter);
expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT); expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT);
$sentAt = $updatedNewsletter->getSentAt(); $sentAt = $updatedNewsletter->getSentAt();
$this->assertInstanceOf(\DateTime::class, $sentAt); $this->assertInstanceOf(\DateTime::class, $sentAt);
@@ -280,7 +280,7 @@ class NewsletterTest extends \MailPoetTest {
$this->newslettersRepository->flush(); $this->newslettersRepository->flush();
$this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask); $this->newsletterTask->markNewsletterAsSent($newsletter, $this->sendingTask);
$updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId()); $updatedNewsletter = $this->newslettersRepository->findOneById($newsletter->getId());
assert($updatedNewsletter instanceof NewsletterEntity); $this->assertInstanceOf(NewsletterEntity::class, $updatedNewsletter);
expect($updatedNewsletter->getStatus())->notEquals(NewsletterEntity::STATUS_SENT); expect($updatedNewsletter->getStatus())->notEquals(NewsletterEntity::STATUS_SENT);
} }
@@ -479,7 +479,7 @@ class NewsletterTest extends \MailPoetTest {
// properly serialized object // properly serialized object
$sendingQueue = $this->sendingQueuesRepository->findOneById($this->sendingTask->id); $sendingQueue = $this->sendingQueuesRepository->findOneById($this->sendingTask->id);
assert($sendingQueue instanceof SendingQueueEntity); $this->assertInstanceOf(SendingQueueEntity::class, $sendingQueue);
$sendingQueue->setNewsletterRenderedBody(['html' => 'test', 'text' => 'test']); $sendingQueue->setNewsletterRenderedBody(['html' => 'test', 'text' => 'test']);
$this->sendingQueuesRepository->persist($sendingQueue); $this->sendingQueuesRepository->persist($sendingQueue);
$this->sendingQueuesRepository->flush(); $this->sendingQueuesRepository->flush();