Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor SubscribersFinder to be always injected by container

Browse Source 
[MAILPOET-3077]
This commit is contained in:
Rostislav Wolny
2020-09-23 13:53:36 +02:00
committed by Veljko V
parent b91687cbc1
commit 694d1fae10
8 changed files with 111 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/API/JSON/v1/SendingQueue.php
View File

@ -22,8 +22,15 @@ class SendingQueue extends APIEndpoint {
/** @var SubscribersFeature */
private $subscribersFeature;
public function __construct(SubscribersFeature $subscribersFeature) {
/** @var SubscribersFinder */
private $subscribersFinder;
public function __construct(
SubscribersFeature $subscribersFeature,
SubscribersFinder $subscribersFinder
) {
$this->subscribersFeature = $subscribersFeature;
$this->subscribersFinder = $subscribersFinder;
}
public function add($data = []) {
@ -90,8 +97,7 @@ class SendingQueue extends APIEndpoint {
$queue->scheduledAt = Scheduler::formatDatetimeString($newsletter->scheduledAt);
} else {
$segments = $newsletter->segments()->findMany();
$finder = new SubscribersFinder();
$subscribersCount = $finder->addSubscribersToTaskFromSegments($queue->task(), $segments);
$subscribersCount = $this->subscribersFinder->addSubscribersToTaskFromSegments($queue->task(), $segments);
if (!$subscribersCount) {
return $this->errorResponse([
APIError::UNKNOWN => __('There are no subscribers in that list!', 'mailpoet'),