Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove unnecessary query for calculation segment score

Browse Source 
[MAILPOET-3633]
This commit is contained in:
Jan Lysý
2021-05-21 13:31:11 +02:00
committed by Veljko V
parent 55b4051e3f
commit 69ddfb2e96
1 changed files with 3 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lib/Statistics/StatisticsOpensRepository.php
View File

@@ -62,44 +62,21 @@ class StatisticsOpensRepository extends Repository {
public function recalculateSegmentScore(SegmentEntity $segment): void { public function recalculateSegmentScore(SegmentEntity $segment): void {
$segment->setAverageEngagementScoreUpdatedAt(new \DateTimeImmutable()); $segment->setAverageEngagementScoreUpdatedAt(new \DateTimeImmutable());
$dateTime = (new Carbon())->subYear();
$newslettersSentCount = $this
->entityManager
->createQueryBuilder()
->select('count(DISTINCT statisticsNewsletter.newsletter)')
->from(StatisticsNewsletterEntity::class, 'statisticsNewsletter')
->join('statisticsNewsletter.subscriber', 'subscriber')
->join('subscriber.subscriberSegments', 'subscriberSegments')
->where('subscriber.status = :subscribed')
->andWhere('subscriberSegments.segment = :segment')
->andWhere('subscriberSegments.status = :subscribed')
->andWhere('subscriber.deletedAt IS NULL')
->andWhere('subscriber.engagementScore IS NOT NULL')
->andWhere('statisticsNewsletter.sentAt > :dateTime')
->setParameter('segment', $segment)
->setParameter('subscribed', SubscriberEntity::STATUS_SUBSCRIBED)
->setParameter('dateTime', $dateTime)
->getQuery()
->getSingleScalarResult();
if ($newslettersSentCount < 3) {
$this->entityManager->flush();
return;
}
$avgScore = $this $avgScore = $this
->entityManager ->entityManager
->createQueryBuilder() ->createQueryBuilder()
->select('avg(DISTINCT subscriber.engagementScore)') ->select('avg(subscriber.engagementScore)')
->from(SubscriberEntity::class, 'subscriber') ->from(SubscriberEntity::class, 'subscriber')
->join('subscriber.subscriberSegments', 'subscriberSegments') ->join('subscriber.subscriberSegments', 'subscriberSegments')
->where('subscriberSegments.segment = :segment') ->where('subscriberSegments.segment = :segment')
->andWhere('subscriber.status = :subscribed') ->andWhere('subscriber.status = :subscribed')
->andWhere('subscriber.deletedAt IS NULL')
->andWhere('subscriberSegments.status = :subscribed') ->andWhere('subscriberSegments.status = :subscribed')
->andWhere('subscriber.engagementScore IS NOT NULL')
->setParameter('segment', $segment) ->setParameter('segment', $segment)
->setParameter('subscribed', SubscriberEntity::STATUS_SUBSCRIBED) ->setParameter('subscribed', SubscriberEntity::STATUS_SUBSCRIBED)
->getQuery() ->getQuery()
->getSingleScalarResult(); ->getSingleScalarResult();
$segment->setAverageEngagementScore((float)$avgScore); $segment->setAverageEngagementScore($avgScore === null ? $avgScore : (float)$avgScore);
$this->entityManager->flush(); $this->entityManager->flush();
} }