Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove duplicated method in ScheduledTaskSubscribersRepository

Browse Source 
[MAILPOET-5422]
This commit is contained in:
Rodrigo Primo
2023-06-21 17:17:19 -03:00
committed by Jan Lysý
parent f37e73d68e
commit 6a438f68d8
2 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mailpoet/lib/Newsletter/Scheduler/AutomaticEmailScheduler.php
View File

@@ -126,7 +126,7 @@ class AutomaticEmailScheduler {
if ($queue instanceof SendingQueueEntity) {
$this->sendingQueuesRepository->remove($queue);
}
$this->scheduledTaskSubscribersRepository->deleteByTask($task);
$this->scheduledTaskSubscribersRepository->deleteByScheduledTask($task);
// In case any of task associated SchedulesTaskSubscriberEntity was loaded we need to detach them
foreach ($task->getSubscribers() as $taskSubscriber) {
$this->scheduledTaskSubscribersRepository->detach($taskSubscriber);

9
mailpoet/lib/Newsletter/Sending/ScheduledTaskSubscribersRepository.php
View File

@@ -78,15 +78,6 @@ class ScheduledTaskSubscribersRepository extends Repository {
return $subscribersIds;
}
public function deleteByTask(ScheduledTaskEntity $scheduledTask): void {
$this->entityManager->createQueryBuilder()
->delete(ScheduledTaskSubscriberEntity::class, 'sts')
->where('sts.task = :task')
->setParameter('task', $scheduledTask)
->getQuery()
->execute();
}
/**
* @param int[] $subscriberIds
*/