Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Extract Newsletters API service mocking to a private method

Browse Source 
[MAILPOET-2646]
This commit is contained in:
Jan Jakeš
2020-04-29 17:04:20 +02:00
committed by Veljko V
parent 9a17d89d28
commit 6a44f820ee
1 changed files with 49 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

129
tests/integration/API/JSON/v1/NewslettersTest.php
View File

@@ -154,22 +154,12 @@ class NewslettersTest extends \MailPoetTest {
$wp = Stub::make(new WPFunctions, [ $wp = Stub::make(new WPFunctions, [
'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']), 'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']),
]); ]);
$this->endpoint = new Newsletters( $this->endpoint = $this->createNewslettersEndpointWithMocks([
ContainerWrapper::getInstance()->get(BulkActionController::class), 'wp' => $wp,
ContainerWrapper::getInstance()->get(Handler::class), 'cronHelper' => $this->cronHelper,
$wp, 'authorizedEmailsController' => $this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::never()]),
SettingsController::getInstance(), 'subscribersFeature' => Stub::make(SubscribersFeature::class),
$this->cronHelper, ]);
$this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::never()]),
ContainerWrapper::getInstance()->get(NewslettersRepository::class),
ContainerWrapper::getInstance()->get(NewsletterListingRepository::class),
ContainerWrapper::getInstance()->get(NewslettersResponseBuilder::class),
ContainerWrapper::getInstance()->get(PostNotificationScheduler::class),
ContainerWrapper::getInstance()->get(Mailer::class),
ContainerWrapper::getInstance()->get(MetaInfo::class),
ContainerWrapper::getInstance()->get(Emoji::class),
Stub::make(SubscribersFeature::class)
);
$response = $this->endpoint->get(['id' => $this->newsletter->id]); $response = $this->endpoint->get(['id' => $this->newsletter->id]);
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
expect($response->data)->equals( expect($response->data)->equals(
@@ -210,22 +200,13 @@ class NewslettersTest extends \MailPoetTest {
'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']), 'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']),
'doAction' => asCallable([WPHooksHelper::class, 'doAction']), 'doAction' => asCallable([WPHooksHelper::class, 'doAction']),
]); ]);
$this->endpoint = new Newsletters( $this->endpoint = $this->createNewslettersEndpointWithMocks([
ContainerWrapper::getInstance()->get(BulkActionController::class), 'wp' => $wp,
ContainerWrapper::getInstance()->get(Handler::class), 'cronHelper' => $this->cronHelper,
$wp, 'authorizedEmailsController' => $this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::once()]),
SettingsController::getInstance(), 'emoji' => $emoji,
$this->cronHelper, 'subscribersFeature' => Stub::make(SubscribersFeature::class),
$this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::once()]), ]);
ContainerWrapper::getInstance()->get(NewslettersRepository::class),
ContainerWrapper::getInstance()->get(NewsletterListingRepository::class),
ContainerWrapper::getInstance()->get(NewslettersResponseBuilder::class),
ContainerWrapper::getInstance()->get(PostNotificationScheduler::class),
ContainerWrapper::getInstance()->get(Mailer::class),
ContainerWrapper::getInstance()->get(MetaInfo::class),
$emoji,
Stub::make(SubscribersFeature::class)
);
$response = $this->endpoint->save($validData); $response = $this->endpoint->save($validData);
$savedNewsletter = Newsletter::filter('filterWithOptions', Newsletter::TYPE_STANDARD) $savedNewsletter = Newsletter::filter('filterWithOptions', Newsletter::TYPE_STANDARD)
@@ -443,22 +424,11 @@ class NewslettersTest extends \MailPoetTest {
} }
public function testItReturnsErrorIfSubscribersLimitReached() { public function testItReturnsErrorIfSubscribersLimitReached() {
$endpoint = new Newsletters( $endpoint = $this->createNewslettersEndpointWithMocks([
ContainerWrapper::getInstance()->get(BulkActionController::class), 'cronHelper' => $this->cronHelper,
ContainerWrapper::getInstance()->get(Handler::class), 'authorizedEmailsController' => $this->make(AuthorizedEmailsController::class),
ContainerWrapper::getInstance()->get(WPFunctions::class), 'subscribersFeature' => Stub::make(SubscribersFeature::class, ['check' => true]),
SettingsController::getInstance(), ]);
$this->cronHelper,
$this->make(AuthorizedEmailsController::class),
ContainerWrapper::getInstance()->get(NewslettersRepository::class),
ContainerWrapper::getInstance()->get(NewsletterListingRepository::class),
ContainerWrapper::getInstance()->get(NewslettersResponseBuilder::class),
ContainerWrapper::getInstance()->get(PostNotificationScheduler::class),
ContainerWrapper::getInstance()->get(Mailer::class),
ContainerWrapper::getInstance()->get(MetaInfo::class),
ContainerWrapper::getInstance()->get(Emoji::class),
Stub::make(SubscribersFeature::class, ['check' => true])
);
$res = $endpoint->setStatus([ $res = $endpoint->setStatus([
'id' => $this->newsletter->id, 'id' => $this->newsletter->id,
'status' => Newsletter::STATUS_ACTIVE, 'status' => Newsletter::STATUS_ACTIVE,
@@ -614,22 +584,12 @@ class NewslettersTest extends \MailPoetTest {
$wp = Stub::make(new WPFunctions, [ $wp = Stub::make(new WPFunctions, [
'doAction' => asCallable([WPHooksHelper::class, 'doAction']), 'doAction' => asCallable([WPHooksHelper::class, 'doAction']),
]); ]);
$this->endpoint = new Newsletters( $this->endpoint = $this->createNewslettersEndpointWithMocks([
ContainerWrapper::getInstance()->get(BulkActionController::class), 'wp' => $wp,
ContainerWrapper::getInstance()->get(Handler::class), 'cronHelper' => $this->cronHelper,
$wp, 'authorizedEmailsController' => $this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::never()]),
SettingsController::getInstance(), 'subscribersFeature' => Stub::make(SubscribersFeature::class),
$this->cronHelper, ]);
$this->make(AuthorizedEmailsController::class, ['onNewsletterUpdate' => Expected::never()]),
ContainerWrapper::getInstance()->get(NewslettersRepository::class),
ContainerWrapper::getInstance()->get(NewsletterListingRepository::class),
ContainerWrapper::getInstance()->get(NewslettersResponseBuilder::class),
ContainerWrapper::getInstance()->get(PostNotificationScheduler::class),
ContainerWrapper::getInstance()->get(Mailer::class),
ContainerWrapper::getInstance()->get(MetaInfo::class),
ContainerWrapper::getInstance()->get(Emoji::class),
Stub::make(SubscribersFeature::class)
);
$response = $this->endpoint->duplicate(['id' => $this->newsletter->id]); $response = $this->endpoint->duplicate(['id' => $this->newsletter->id]);
expect($response->status)->equals(APIResponse::STATUS_OK); expect($response->status)->equals(APIResponse::STATUS_OK);
@@ -963,22 +923,12 @@ class NewslettersTest extends \MailPoetTest {
'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']), 'applyFilters' => asCallable([WPHooksHelper::class, 'applyFilters']),
'doAction' => asCallable([WPHooksHelper::class, 'doAction']), 'doAction' => asCallable([WPHooksHelper::class, 'doAction']),
]); ]);
$this->endpoint = new Newsletters( $this->endpoint = $this->createNewslettersEndpointWithMocks([
ContainerWrapper::getInstance()->get(BulkActionController::class), 'wp' => $wp,
ContainerWrapper::getInstance()->get(Handler::class), 'cronHelper' => $this->cronHelper,
$wp, 'emoji' => $emoji,
SettingsController::getInstance(), 'subscribersFeature' => Stub::make(SubscribersFeature::class),
$this->cronHelper, ]);
ContainerWrapper::getInstance()->get(AuthorizedEmailsController::class),
ContainerWrapper::getInstance()->get(NewslettersRepository::class),
ContainerWrapper::getInstance()->get(NewsletterListingRepository::class),
ContainerWrapper::getInstance()->get(NewslettersResponseBuilder::class),
ContainerWrapper::getInstance()->get(PostNotificationScheduler::class),
ContainerWrapper::getInstance()->get(Mailer::class),
ContainerWrapper::getInstance()->get(MetaInfo::class),
$emoji,
Stub::make(SubscribersFeature::class)
);
$response = $this->endpoint->showPreview($data); $response = $this->endpoint->showPreview($data);
expect($response->meta['preview_url'])->notContains('http'); expect($response->meta['preview_url'])->notContains('http');
@@ -1087,4 +1037,23 @@ class NewslettersTest extends \MailPoetTest {
ORM::raw_execute('TRUNCATE ' . SubscriberSegment::$_table); ORM::raw_execute('TRUNCATE ' . SubscriberSegment::$_table);
ORM::raw_execute('TRUNCATE ' . SendingQueue::$_table); ORM::raw_execute('TRUNCATE ' . SendingQueue::$_table);
} }
private function createNewslettersEndpointWithMocks(array $mocks): Newsletters {
return new Newsletters(
$this->diContainer->get(BulkActionController::class),
$this->diContainer->get(Handler::class),
$mocks['wp'] ?? $this->diContainer->get(WPFunctions::class),
$this->diContainer->get(SettingsController::class),
$mocks['cronHelper'] ?? $this->diContainer->get(CronHelper::class),
$mocks['authorizedEmailsController'] ?? $this->diContainer->get(AuthorizedEmailsController::class),
$this->diContainer->get(NewslettersRepository::class),
$this->diContainer->get(NewsletterListingRepository::class),
$this->diContainer->get(NewslettersResponseBuilder::class),
$this->diContainer->get(PostNotificationScheduler::class),
$this->diContainer->get(Mailer::class),
$this->diContainer->get(MetaInfo::class),
$mocks['emoji'] ?? $this->diContainer->get(Emoji::class),
$mocks['subscribersFeature'] ?? $this->diContainer->get(SubscribersFeature::class)
);
}
} }