Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

adding unit tests

Browse Source
This commit is contained in:
Amine Ben hammou
2017-10-17 13:09:37 +00:00
parent 60ed294302
commit 6f80dcb1de
2 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Newsletter/Renderer/Blocks/Image.php
View File

@@ -10,7 +10,7 @@ class Image {
if(empty($element['src'])) {
return '';
}
if(substr($element['src'], 0, 1) == '/') {
if(substr($element['src'], 0, 1) == '/' && substr($element['src'], 1, 1) != '/') {
$element['src'] = get_option('siteurl') . $element['src'];
}

25
tests/unit/Newsletter/RendererTest.php
View File

@@ -168,6 +168,31 @@ class RendererTest extends \MailPoetTest {
expect($rendered_image)->equals('');
}
function testItForcesAbsoluteSrcForImages() {
$image = array(
'src' => '/relative-path',
'width' => '100',
'height' => '200',
'link' => '',
'fullWidth' => false,
'alt' => 'some test alt text'
);
$rendered_image = Image::render($image, $columnCount = 1);
$site_url = get_option('siteurl');
expect($rendered_image)->contains('src="'.$site_url.'/relative-path"');
$image = array(
'src' => '//path-without-protocol',
'width' => '100',
'height' => '200',
'link' => '',
'fullWidth' => false,
'alt' => 'some test alt text'
);
$rendered_image = Image::render($image, $columnCount = 1);
expect($rendered_image)->contains('src="//path-without-protocol"');
}
function testItRendersImageWithLink() {
$newsletter = $this->newsletter['body'];
$template = $newsletter['content']['blocks'][0]['blocks'][0]['blocks'][1];