From 70138089d7bb43c25385b64a28f60dc6a044a975 Mon Sep 17 00:00:00 2001
From: Rodrigo Primo <rodrigosprimo@gmail.com>
Date: Fri, 19 Feb 2021 16:29:44 -0300
Subject: [PATCH] PHPCS: set the supported PHP versions in the ruleset file

This commit moves the definition of the supported PHP versions from
RoboFile.php file to the PHPCS configuration file, ruleset.xml. This
should make it easier to configure PHPCS in other places like the IDE.

I also removed the constraint of the highest supported PHP version
(previously, it was hard-coded to 8.0) as I believe we support new PHP
versions as soon as they are released. With this change, we don't need to
remember to update testVersion tag whenever there is a new PHP version.

[MAILPOET-3439]
---
 RoboFile.php                            | 1 -
 tasks/code_sniffer/MailPoet/ruleset.xml | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/RoboFile.php b/RoboFile.php
index 10ba222a21..892c719607 100644
--- a/RoboFile.php
+++ b/RoboFile.php
@@ -407,7 +407,6 @@ class RoboFile extends \Robo\Tasks {
 
     return $this
       ->taskExec($task)
-      ->rawArg('--runtime-set testVersion 7.1-8.0')
       ->arg('--ignore=' . implode(',', $foldersToIgnore))
       ->rawArg($stringFilesToCheck)
       ->run();
diff --git a/tasks/code_sniffer/MailPoet/ruleset.xml b/tasks/code_sniffer/MailPoet/ruleset.xml
index 3e3f6d2e34..b6e59c57f4 100644
--- a/tasks/code_sniffer/MailPoet/ruleset.xml
+++ b/tasks/code_sniffer/MailPoet/ruleset.xml
@@ -3,6 +3,7 @@
   <config name="installed_paths" value="tasks/code_sniffer/vendor/squizlabs/php_codesniffer,tasks/code_sniffer/vendor/phpcompatibility/php-compatibility,tasks/code_sniffer/vendor/slevomat/coding-standard"/>
   <description>MailPoet specific rule set</description>
   <exclude-pattern>*/phpstan/woocommerce.php</exclude-pattern>
+  <config name="testVersion" value="7.1-"/>
 
   <!-- Files -->
   <rule ref="Generic.Files.ByteOrderMark"/> <!-- Disallow usage of BOMs -->