From 723dc2c9d3df1f93e7ea2f66ff3db53008b6ffac Mon Sep 17 00:00:00 2001 From: Jan Jakes Date: Fri, 18 Nov 2022 11:44:20 +0100 Subject: [PATCH] Fix type errors in tests [MAILPOET-2688] --- .../tests/DataFactories/StatisticsWooCommercePurchases.php | 2 +- mailpoet/tests/integration/Cron/DaemonHttpRunnerTest.php | 2 +- .../Cron/Workers/SendingQueue/SendingQueueTest.php | 4 ++-- .../tests/integration/Statistics/Track/UnsubscribesTest.php | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mailpoet/tests/DataFactories/StatisticsWooCommercePurchases.php b/mailpoet/tests/DataFactories/StatisticsWooCommercePurchases.php index 6a62da412b..0c8ff285e0 100644 --- a/mailpoet/tests/DataFactories/StatisticsWooCommercePurchases.php +++ b/mailpoet/tests/DataFactories/StatisticsWooCommercePurchases.php @@ -45,7 +45,7 @@ class StatisticsWooCommercePurchases { $this->click, $this->data['order_id'], $this->data['order_currency'], - $this->data['order_price_total'] + (float)$this->data['order_price_total'] ); $entity->setSubscriber($this->subscriber); diff --git a/mailpoet/tests/integration/Cron/DaemonHttpRunnerTest.php b/mailpoet/tests/integration/Cron/DaemonHttpRunnerTest.php index f9b2987131..67b81a76fa 100644 --- a/mailpoet/tests/integration/Cron/DaemonHttpRunnerTest.php +++ b/mailpoet/tests/integration/Cron/DaemonHttpRunnerTest.php @@ -34,7 +34,7 @@ class DaemonHttpRunnerTest extends \MailPoetTest { [] ); $daemon = $this->diContainer->get(DaemonHttpRunner::class); - expect(strlen($daemon->timer))->greaterOrEquals(5); + expect(strlen((string)$daemon->timer))->greaterOrEquals(5); expect(strlen($daemon->token))->greaterOrEquals(5); } diff --git a/mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php b/mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php index e977e77b50..2319e5a1bf 100644 --- a/mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php +++ b/mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php @@ -158,7 +158,7 @@ class SendingQueueTest extends \MailPoetTest { } private function getDirectUnsubscribeURL() { - return SubscriptionUrlFactory::getInstance()->getUnsubscribeUrl($this->subscriber, $this->queue->id); + return SubscriptionUrlFactory::getInstance()->getUnsubscribeUrl($this->subscriber, (int)$this->queue->id); } private function getTrackedUnsubscribeURL() { @@ -494,7 +494,7 @@ class SendingQueueTest extends \MailPoetTest { $subscriberId = (int)$subscriberId[0]; $subscriber = $subscribersRepository->findOneById($subscriberId); $subscriptionUrlFactory = SubscriptionUrlFactory::getInstance(); - $unsubscribeUrl = $subscriptionUrlFactory->getUnsubscribeUrl($subscriber, $queue->id); + $unsubscribeUrl = $subscriptionUrlFactory->getUnsubscribeUrl($subscriber, (int)$queue->id); expect($newsletter['subject'])->equals('News for ' . $subscriberEmail); expect($newsletter['body']['html'])->equals('

Hello ' . $subscriberEmail . '

'); expect($newsletter['body']['text'])->equals('Hello ' . $subscriberEmail); diff --git a/mailpoet/tests/integration/Statistics/Track/UnsubscribesTest.php b/mailpoet/tests/integration/Statistics/Track/UnsubscribesTest.php index d8a841dea9..2aad9a353c 100644 --- a/mailpoet/tests/integration/Statistics/Track/UnsubscribesTest.php +++ b/mailpoet/tests/integration/Statistics/Track/UnsubscribesTest.php @@ -57,7 +57,7 @@ class UnsubscribesTest extends \MailPoetTest { $this->unsubscribes->track( $subscriberId, 'source', - $this->queue->id, + (int)$this->queue->id, null, StatisticsUnsubscribeEntity::METHOD_ONE_CLICK ); @@ -69,12 +69,12 @@ class UnsubscribesTest extends \MailPoetTest { public function testItDoesNotTrackRepeatedUnsubscribeEvents() { $subscriberId = $this->subscriber->getId(); $this->assertIsInt($subscriberId); - + for ($count = 0; $count <= 2; $count++) { $this->unsubscribes->track( $subscriberId, 'source', - $this->queue->id + (int)$this->queue->id ); } expect(count($this->statisticsUnsubscribesRepository->findAll()))->equals(1);