Fix minor PR remarks [MAILPOET-2015]

Reuse updateCaptcha() function
Inject Captcha class using DI
Add no-cache headers to captcha image
Fix an error when accessing the captcha page directly
Edit the line in settings regarding missing dependencies
This commit is contained in:
wxa
2019-07-11 13:42:47 +03:00
committed by M. Shull
parent 0b8dbf1d27
commit 7788aebe83
12 changed files with 54 additions and 22 deletions

View File

@@ -10,6 +10,7 @@ use MailPoet\Models\SubscriberCustomField;
use MailPoet\Newsletter\Shortcodes\Categories\Date;
use MailPoet\Newsletter\Url as NewsletterUrl;
use MailPoet\Settings\SettingsController;
use MailPoet\Subscription\Captcha;
use MailPoet\Subscription\Url as SubscriptionUrl;
use MailPoet\WP\Functions as WPFunctions;
@@ -25,7 +26,7 @@ class ShortcodesTest extends \MailPoetTest {
function _before() {
parent::_before();
$this->settings = new SettingsController();
$populator = new Populator($this->settings, WPFunctions::get());
$populator = new Populator($this->settings, WPFunctions::get(), new Captcha);
$populator->up();
$this->WP_user = $this->_createWPUser();
$this->WP_post = $this->_createWPPost();