Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use early returns in already refactored endpoints

Browse Source 
[MAILPOET-2646]
This commit is contained in:
Jan Jakeš
2020-04-30 13:29:47 +02:00
committed by Veljko V
parent edf4f5b29a
commit 79bfd8ec44
1 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
lib/API/JSON/v1/Newsletters.php
View File

@ -109,40 +109,39 @@ class Newsletters extends APIEndpoint {
public function get($data = []) { public function get($data = []) {
$newsletter = $this->getNewsletter($data); $newsletter = $this->getNewsletter($data);
if ($newsletter) { if (!$newsletter) {
$response = $this->newslettersResponseBuilder->build($newsletter, [
NewslettersResponseBuilder::RELATION_SEGMENTS,
NewslettersResponseBuilder::RELATION_OPTIONS,
NewslettersResponseBuilder::RELATION_QUEUE,
]);
$response = $this->wp->applyFilters('mailpoet_api_newsletters_get_after', $response);
return $this->successResponse($response, ['preview_url' => $this->getViewInBrowserUrl($newsletter)]);
} else {
return $this->errorResponse([ return $this->errorResponse([
APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'), APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'),
]); ]);
} }
$response = $this->newslettersResponseBuilder->build($newsletter, [
NewslettersResponseBuilder::RELATION_SEGMENTS,
NewslettersResponseBuilder::RELATION_OPTIONS,
NewslettersResponseBuilder::RELATION_QUEUE,
]);
$response = $this->wp->applyFilters('mailpoet_api_newsletters_get_after', $response);
return $this->successResponse($response, ['preview_url' => $this->getViewInBrowserUrl($newsletter)]);
} }
public function getWithStats($data = []) { public function getWithStats($data = []) {
$newsletter = $this->getNewsletter($data); $newsletter = $this->getNewsletter($data);
if ($newsletter) { if (!$newsletter) {
$response = $this->newslettersResponseBuilder->build($newsletter, [
NewslettersResponseBuilder::RELATION_SEGMENTS,
NewslettersResponseBuilder::RELATION_OPTIONS,
NewslettersResponseBuilder::RELATION_QUEUE,
NewslettersResponseBuilder::RELATION_TOTAL_SENT,
NewslettersResponseBuilder::RELATION_STATISTICS,
]);
$response = $this->wp->applyFilters('mailpoet_api_newsletters_get_after', $response);
$response['preview_url'] = $this->getViewInBrowserUrl($newsletter);
return $this->successResponse($response);
} else {
return $this->errorResponse([ return $this->errorResponse([
APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'), APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'),
]); ]);
} }
$response = $this->newslettersResponseBuilder->build($newsletter, [
NewslettersResponseBuilder::RELATION_SEGMENTS,
NewslettersResponseBuilder::RELATION_OPTIONS,
NewslettersResponseBuilder::RELATION_QUEUE,
NewslettersResponseBuilder::RELATION_TOTAL_SENT,
NewslettersResponseBuilder::RELATION_STATISTICS,
]);
$response = $this->wp->applyFilters('mailpoet_api_newsletters_get_after', $response);
$response['preview_url'] = $this->getViewInBrowserUrl($newsletter);
return $this->successResponse($response);
} }
public function save($data = []) { public function save($data = []) {